From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE453A04DE; Fri, 23 Oct 2020 09:38:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1287D7CC8; Fri, 23 Oct 2020 09:38:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id A08357CAE for ; Fri, 23 Oct 2020 09:38:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603438683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HipeV1ohzkF6C+NWP/dxUFY4spZtmBUCqidr4PoZ2Kk=; b=I1PWI88cLjOh5fVaGsWvgy0I4gX5tp5Kk9sckUkrD/tUotomXBp5ZYUCJx087fUbCPWzlG kzzIYHRhc68pqFdnEkXa4DYt4C/Sky/bLAFXpQlMzKLQrsroeUOjPQsHWKCyPDtRn98Vdh a7sf998ly3E2i5Uiztr39+I/o1k0ZYE= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-351-WVYJmpNPOUy_VlLvd92JWg-1; Fri, 23 Oct 2020 03:38:00 -0400 X-MC-Unique: WVYJmpNPOUy_VlLvd92JWg-1 Received: by mail-ua1-f69.google.com with SMTP id k5so200108uag.1 for ; Fri, 23 Oct 2020 00:38:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HipeV1ohzkF6C+NWP/dxUFY4spZtmBUCqidr4PoZ2Kk=; b=TLqPqQq+cLPNj/oRG7QW5Z91FIPNKM7nbmtEtThubpItfJx+Jf0fvovr+W+FQSXDb1 i0qbBAaKDiP9smsLaYfeEu8usPPi1WTXs04EqYzhZZ3E8Cd/5jeBcGYeJM4nVrkm+gYR 6PMzuPFpRQxiLfbRV2DFQI9SrmqoCNMWxVAQNTssfXbXYtkg2yfDxpNrsQ+4UcvHjmFY US5E8XhD6nmF+z3A7IUg182wpPL/Ar5ndtMPVb2lLuUaXQSf+ZNbwI8o2IepJKMXlfXW tDmDYNUVoCRo/H5WwEaSYBDNd6eaAJBvQSqlkQyUitTUlw9MqBJ2AyVhNHT1dZjEJHEB cwjw== X-Gm-Message-State: AOAM530TV/lPoxYkpZJMcxpdajvLEu8GKFpDRxMU1NCVwBhTDScGQSOa yV7WC4tp828d/MYOp3K3XtpZAFuBQ4gy6y5ri9S00oE1z0XPt2ir1dhOBM+iLpbKhSCsMoq5vkU zDoCWJPA7P0/yhsr9yzE= X-Received: by 2002:a67:ce16:: with SMTP id s22mr409802vsl.17.1603438679710; Fri, 23 Oct 2020 00:37:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmUP4S/l8e5nMoz8ZrOZEph1MVEHAi4VdxOoL2lpHXyNGleMYy0eQyKwTD2ewPmr8p7ILVKvIATZgHLZrAGzM= X-Received: by 2002:a67:ce16:: with SMTP id s22mr409784vsl.17.1603438679481; Fri, 23 Oct 2020 00:37:59 -0700 (PDT) MIME-Version: 1.0 References: <20201022220525.1532249-1-thomas@monjalon.net> In-Reply-To: <20201022220525.1532249-1-thomas@monjalon.net> From: David Marchand Date: Fri, 23 Oct 2020 09:37:48 +0200 Message-ID: To: Thomas Monjalon Cc: dev , "Yigit, Ferruh" , Bruce Richardson , "Burakov, Anatoly" , Olivier Matz , Ciara Power , Akhil Goyal , "Trahe, Fiona" , John Griffin , Deepak Kumar Jain Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 0/5] cleanup comments and logs about config options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 23, 2020 at 12:05 AM Thomas Monjalon wrote: > > Below patches are cleaning traces of CONFIG_RTE_ after make removal, > except one occurence in app/test/test_cryptodev.c (left as exercise). > PS: In reality I don't know what must be done for this case about QAT. It seems a reintroduction with raw datapath API merge. I would apply the same as Ciara previous: https://git.dpdk.org/dpdk/diff/app/test/test_cryptodev.c?id=c2c92c5d88522bb7f149de8ea6305691d1c65505 I.e. @@ -14022,9 +14022,7 @@ test_cryptodev_qat_raw_api(void /*argv __rte_unused, int argc __rte_unused*/) RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)); if (gbl_driver_id == -1) { - RTE_LOG(ERR, USER1, "QAT PMD must be loaded. Check that both " - "CONFIG_RTE_LIBRTE_PMD_QAT and CONFIG_RTE_LIBRTE_PMD_QAT_SYM " - "are enabled in config file to run this testsuite.\n"); + RTE_LOG(ERR, USER1, "QAT PMD must be loaded.\n"); return TEST_SKIPPED; } The rest of the series looks good to me. Acked-by: David Marchand -- David Marchand