From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com [209.85.221.195]) by dpdk.org (Postfix) with ESMTP id DDEAD1B6A1 for ; Wed, 17 Apr 2019 16:03:06 +0200 (CEST) Received: by mail-vk1-f195.google.com with SMTP id l17so5226090vke.7 for ; Wed, 17 Apr 2019 07:03:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LFsh4Ixr6VfJhUOPUDR6/n7F2rxGh722oDnUB1vFMd0=; b=Ma9F2JPdy59HYljccp8NfcXJZzjxgK6ySRDxMTndcAGW2yYik7qyWA/oI6xAYrsIrF OgvGfn10uxPf56g9JdUr5mnKThyV2tmEdhB4pod/Laac0KqfEK06MPxTU0xBb78bd7jw HOu9RPUsaazse5rdycQSkVpwqZJgJgVaCp2+G77CaGp1j6wOwCC1R5oUZyLamaI6OIxL UcPQSTpBwpz1e8MaNEP5qMJH0n4PJN80iDsoLfnSrvCzEplCvbpK34t8QcMzqnCAR/TF J+wEGfikXxH6J0BgTZXTizTiLI9H8P1wb+J9lcyZ3e8/NK3u8LElwp3QTtmOgUN/n6OE Na7A== X-Gm-Message-State: APjAAAUR+pe0a3VTCRA9HVbwvE0FDQ0lb1AtUcVRj9b+OukvjuBsqwoV Z0tqlQOqqTtUc916Bj0QUsWl3LUIZYOTFEV4sSDGOQ== X-Google-Smtp-Source: APXvYqyLvt9MubbDhzEFws8Kdoa2XCsN7YsxEZ1VIJkrMSyWHH2zxbMMnLAWExf9hAsD4B6E8CB3Qxca2/psslmCMvI= X-Received: by 2002:a1f:7d4e:: with SMTP id y75mr47523706vkc.53.1555509786302; Wed, 17 Apr 2019 07:03:06 -0700 (PDT) MIME-Version: 1.0 References: <20190417134946.1250-1-xiaolong.ye@intel.com> In-Reply-To: <20190417134946.1250-1-xiaolong.ye@intel.com> From: David Marchand Date: Wed, 17 Apr 2019 16:02:55 +0200 Message-ID: To: Xiaolong Ye Cc: dev , Ferruh Yigit , Qi Zhang , Karlsson Magnus , Topel Bjorn Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 0/4] some fixes for AF_XDP pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 14:03:07 -0000 On Wed, Apr 17, 2019 at 3:55 PM Xiaolong Ye wrote: > This patchset provides some fixes to af_xdp pmd, at first, I just added > a simple error handling when Tx queue allocation fails, then David > suggested a better way to do it and pointed out the inconsistent issue > of reserve/submit ops (for Tx queue) and peek/release ops (for Rx > queue), the third patch addressed this. > > v4 changes: > > - remove unnecessary mtu valid check in eth_dev_mtu_set > - add Reported-by and Reviewed-by tags of David > > v3 changes: > > - address David's review comments > - add one patch to specify the mtu range > - add one fix patch for typo > > v2 changes: > > - adopt David's suggestion to refactor the code > > Xiaolong Ye (4): > net/af_xdp: enqueue buf ring when allocate Tx queue fails > net/af_xdp: specify minimal and maximal MTU > net/af_xdp: make reserve/submit peek/release consistent > net/af_xdp: fix typos in Rx function > > drivers/net/af_xdp/rte_eth_af_xdp.c | 87 +++++++++++++++-------------- > 1 file changed, 46 insertions(+), 41 deletions(-) > > -- > 2.17.1 > > LGTM. Thanks Xiaolong. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A40ADA00E6 for ; Wed, 17 Apr 2019 16:03:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D55F1B6B6; Wed, 17 Apr 2019 16:03:08 +0200 (CEST) Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com [209.85.221.195]) by dpdk.org (Postfix) with ESMTP id DDEAD1B6A1 for ; Wed, 17 Apr 2019 16:03:06 +0200 (CEST) Received: by mail-vk1-f195.google.com with SMTP id l17so5226090vke.7 for ; Wed, 17 Apr 2019 07:03:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LFsh4Ixr6VfJhUOPUDR6/n7F2rxGh722oDnUB1vFMd0=; b=Ma9F2JPdy59HYljccp8NfcXJZzjxgK6ySRDxMTndcAGW2yYik7qyWA/oI6xAYrsIrF OgvGfn10uxPf56g9JdUr5mnKThyV2tmEdhB4pod/Laac0KqfEK06MPxTU0xBb78bd7jw HOu9RPUsaazse5rdycQSkVpwqZJgJgVaCp2+G77CaGp1j6wOwCC1R5oUZyLamaI6OIxL UcPQSTpBwpz1e8MaNEP5qMJH0n4PJN80iDsoLfnSrvCzEplCvbpK34t8QcMzqnCAR/TF J+wEGfikXxH6J0BgTZXTizTiLI9H8P1wb+J9lcyZ3e8/NK3u8LElwp3QTtmOgUN/n6OE Na7A== X-Gm-Message-State: APjAAAUR+pe0a3VTCRA9HVbwvE0FDQ0lb1AtUcVRj9b+OukvjuBsqwoV Z0tqlQOqqTtUc916Bj0QUsWl3LUIZYOTFEV4sSDGOQ== X-Google-Smtp-Source: APXvYqyLvt9MubbDhzEFws8Kdoa2XCsN7YsxEZ1VIJkrMSyWHH2zxbMMnLAWExf9hAsD4B6E8CB3Qxca2/psslmCMvI= X-Received: by 2002:a1f:7d4e:: with SMTP id y75mr47523706vkc.53.1555509786302; Wed, 17 Apr 2019 07:03:06 -0700 (PDT) MIME-Version: 1.0 References: <20190417134946.1250-1-xiaolong.ye@intel.com> In-Reply-To: <20190417134946.1250-1-xiaolong.ye@intel.com> From: David Marchand Date: Wed, 17 Apr 2019 16:02:55 +0200 Message-ID: To: Xiaolong Ye Cc: dev , Ferruh Yigit , Qi Zhang , Karlsson Magnus , Topel Bjorn Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 0/4] some fixes for AF_XDP pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417140255.fPS_-QN0DvMio8E1lZ7nikzMbxDsM_DqiQ7XId3wodI@z> On Wed, Apr 17, 2019 at 3:55 PM Xiaolong Ye wrote: > This patchset provides some fixes to af_xdp pmd, at first, I just added > a simple error handling when Tx queue allocation fails, then David > suggested a better way to do it and pointed out the inconsistent issue > of reserve/submit ops (for Tx queue) and peek/release ops (for Rx > queue), the third patch addressed this. > > v4 changes: > > - remove unnecessary mtu valid check in eth_dev_mtu_set > - add Reported-by and Reviewed-by tags of David > > v3 changes: > > - address David's review comments > - add one patch to specify the mtu range > - add one fix patch for typo > > v2 changes: > > - adopt David's suggestion to refactor the code > > Xiaolong Ye (4): > net/af_xdp: enqueue buf ring when allocate Tx queue fails > net/af_xdp: specify minimal and maximal MTU > net/af_xdp: make reserve/submit peek/release consistent > net/af_xdp: fix typos in Rx function > > drivers/net/af_xdp/rte_eth_af_xdp.c | 87 +++++++++++++++-------------- > 1 file changed, 46 insertions(+), 41 deletions(-) > > -- > 2.17.1 > > LGTM. Thanks Xiaolong. -- David Marchand