From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FC34A04DD; Fri, 23 Oct 2020 16:12:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2464FA971; Fri, 23 Oct 2020 16:12:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 355FAA977 for ; Fri, 23 Oct 2020 16:12:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603462330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GqdrKYrqygr3YLyivzLBi85Q3Pepnio5umo8+EwEB1U=; b=TTJi9Y2CTD+oqXktjlEguFKLVbS79SD4lu2mYBQi+HIGzGmKkbzI87ac//QSYUn5C0DOiP CdWEkO3GmZKeonmzVlTQcuY2iXsSfLiiAMf6/44G/RCrk5zF4aaEOMG1YkB8tJgseT6IGu fEy53VBKHBsFtaiQfLa39xRMCI+g+9c= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-ZymwpXy1NX-TIeMorMsaEA-1; Fri, 23 Oct 2020 10:12:08 -0400 X-MC-Unique: ZymwpXy1NX-TIeMorMsaEA-1 Received: by mail-vk1-f200.google.com with SMTP id f6so314064vkk.2 for ; Fri, 23 Oct 2020 07:12:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GqdrKYrqygr3YLyivzLBi85Q3Pepnio5umo8+EwEB1U=; b=kfMNIWj5UmEGYcXdVQpOqDf0lH6qVSmFDO9ktkbuaS+7D/3KZFR8nWWDPwPzO2mP4o WHoL0NPLzsOtHTUSTQtBNOp/iZgI2j/8Zz5/TcmLa2cKPs8BdwqvXn7KH6nHjTWm/b3S 0FEFiQ+hVOCDyp/3KJgBsewPwE4/61W8v1H9rxh+ysKNzzT0sXXOBiGbMJov3YkKDAVt 45YsIZJF45tMK6CROfjm41hY95LoxmLgtoaW8ALe0on4R4TgjnRMvus45Mthef6tBSaw PUAmEqRIIiAKosTqjo2gyYjOeJmCj8/QZ9+HJ2ufaoLWO1kXJFtkKKIvZQpoZvTnTpX7 rQYQ== X-Gm-Message-State: AOAM5337CE/adDP0M5STkVxC8mj1nGR1bP9GelpPnJIB4NL43+hh5rdl tcIRw9zl8JcPpsJv4CGuenTNZePiZ8p2vPtP8PRHJq/+YkkxPYySurTlSKYmHH1Qa/PEMWlxnoB efLawOvGNEr/Xwcvec1M= X-Received: by 2002:ab0:784d:: with SMTP id y13mr1368439uaq.86.1603462327485; Fri, 23 Oct 2020 07:12:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKbL2i3UOUxJDk6Q5EXnJRfDop05NtObxStfGkW3ZIib7M3s9Rh9LPOymzq1A2cAGwMw+8miEFngafoi6W+CM= X-Received: by 2002:ab0:784d:: with SMTP id y13mr1368419uaq.86.1603462327197; Fri, 23 Oct 2020 07:12:07 -0700 (PDT) MIME-Version: 1.0 References: <20191030052318.1167-1-pbhagavatula@marvell.com> <20200802181631.691-1-pbhagavatula@marvell.com> <20200802181631.691-2-pbhagavatula@marvell.com> In-Reply-To: <20200802181631.691-2-pbhagavatula@marvell.com> From: David Marchand Date: Fri, 23 Oct 2020 16:11:56 +0200 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob Kollanukkaran , Thomas Monjalon , Marko Kovacevic , Ori Kam , Bruce Richardson , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/3] examples/l3fwd: use IP reserved addresses for EM mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Aug 2, 2020 at 8:17 PM wrote: > > From: Pavan Nikhilesh > > The l3fwd example should use the reserved IPv4/v6 reserved address > ranges defined in RFC5735 and RFC5180 and RFC863 discard protocol for > the port number in the exact match mode of L3 forwarding. > > Signed-off-by: Pavan Nikhilesh > --- > examples/l3fwd/l3fwd_em.c | 87 ++++++++++++++++++++++++++------------- > 1 file changed, 59 insertions(+), 28 deletions(-) Would such a change affect current users? If so, please add a release note update. I see DTS uses l3fwd. If the change has an impact, probably worth reporting it on the dts ml. > > diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c > index fdbee70b4..481b6dcce 100644 > --- a/examples/l3fwd/l3fwd_em.c > +++ b/examples/l3fwd/l3fwd_em.c [snip] > @@ -429,7 +460,7 @@ populate_ipv4_many_flow_into_table(const struct rte_hash *h, > switch (i & (NUMBER_PORT_USED - 1)) { > case 0: > entry = ipv4_l3fwd_em_route_array[0]; > - entry.key.ip_dst = RTE_IPV4(101, c, b, a); > + entry.key.ip_dst = RTE_IPV4(9, c, b, a); > break; > case 1: > entry = ipv4_l3fwd_em_route_array[1]; > @@ -437,11 +468,11 @@ populate_ipv4_many_flow_into_table(const struct rte_hash *h, > break; > case 2: > entry = ipv4_l3fwd_em_route_array[2]; > - entry.key.ip_dst = RTE_IPV4(111, c, b, a); > + entry.key.ip_dst = RTE_IPV4(91, c, b, a); > break; > case 3: > entry = ipv4_l3fwd_em_route_array[3]; > - entry.key.ip_dst = RTE_IPV4(211, c, b, a); > + entry.key.ip_dst = RTE_IPV4(29, c, b, a); > break; > }; > convert_ipv4_5tuple(&entry.key, &newkey); Why such 9, 91, 29 values? Do they have special properties? -- David Marchand