From: David Marchand <david.marchand@redhat.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "Yang, SteveX" <stevex.yang@intel.com>, dev <dev@dpdk.org>,
"Zhang, Yuying" <yuying.zhang@intel.com>,
Ferruh Yigit <ferruh.yigit@xilinx.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] app/testpmd: support ddp dump command for ice
Date: Mon, 23 May 2022 09:14:06 +0200 [thread overview]
Message-ID: <CAJFAV8yYk1OdbdzjM2ud1NK4k-76Oay7ExOEvkAD7SR7S3z1ow@mail.gmail.com> (raw)
In-Reply-To: <DM4PR11MB59941E9B6553381615D77115D7D29@DM4PR11MB5994.namprd11.prod.outlook.com>
On Sat, May 21, 2022 at 3:20 AM Zhang, Qi Z <qi.z.zhang@intel.com> wrote:
> > > > Dump DDP runtime configure into a binary(package) file from ice PF port.
> > > >
> > > > Add command line:
> > > > ddp dump <port_id> <config_path>
> > > >
> > > > Parameters:
> > > > <port_id> the PF Port ID
> > > > <config_path> dumped runtime configure file, if not a absolute path,
> > > > it will be dumped to testpmd running directory.
> > > >
> > > > For example:
> > > > testpmd> ddp dump 0 current.pkg
> > > >
> > > > If you want to dump ice VF DDP runtime configure, you need bind
> > > > other unused PF port of the NIC first, and then dump the PF's
> > > > runtime configure as target output.
> > > >
> > > > Signed-off-by: Steve Yang <stevex.yang@intel.com>
> > >
> > > I proposed a way to move such code in drivers, please have a look
> > > at/give feedback to:
> > > https://patchwork.dpdk.org/project/dpdk/list/?series=23000&state=*
> >
> > This looks like a good idea, we will review and thanks for the heads-up
> >
>
> David
> Are these RFC patches target to DPDK 22.07?
> If not, is below proposal acceptable?
> 1. merge this patch in DPDK 22.07.
> 2. meanwhile we will also contribute the ice refactor patch based on your RFC, so it can be captured in next release.
My intention is to get them in 22.07, if other maintainers are happy with it.
I just posted a non-RFC series.
--
David Marchand
next prev parent reply other threads:[~2022-05-23 7:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 8:02 [PATCH v1 0/2] ICE ddp download tool Steve Yang
2022-05-11 8:02 ` [PATCH v1 1/2] net/ice: support dump ice ddp package Steve Yang
2022-05-18 4:22 ` Zhang, Qi Z
2022-05-24 2:49 ` Zhang, Qi Z
2022-05-18 15:21 ` Stephen Hemminger
2022-05-11 8:02 ` [PATCH v1 2/2] app/testpmd: support dump_pkg command for ice Steve Yang
2022-05-18 4:32 ` Zhang, Qi Z
2022-05-12 2:06 ` [PATCH v2 0/2] ICE ddp download tool Steve Yang
2022-05-12 2:06 ` [PATCH v2 1/2] net/ice: support dump ice ddp package Steve Yang
2022-05-12 2:06 ` [PATCH v2 2/2] app/testpmd: support dump_pkg command for ice Steve Yang
2022-05-18 6:58 ` [PATCH v3] app/testpmd: support ddp dump " Steve Yang
2022-05-18 15:24 ` Stephen Hemminger
2022-05-19 8:14 ` Andrew Rybchenko
2022-05-19 12:12 ` David Marchand
2022-05-20 3:07 ` Zhang, Qi Z
2022-05-21 1:19 ` Zhang, Qi Z
2022-05-23 7:14 ` David Marchand [this message]
2022-06-09 7:39 ` [PATCH v4] net/ice: support dump DDP runtime configure Steve Yang
2022-06-09 8:40 ` Zhang, Qi Z
2022-06-10 1:16 ` Zhang, Qi Z
2022-06-10 1:14 ` [PATCH v5] " Steve Yang
2022-06-10 2:25 ` Zhang, Qi Z
2022-06-23 13:10 ` Thomas Monjalon
2022-06-23 13:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yYk1OdbdzjM2ud1NK4k-76Oay7ExOEvkAD7SR7S3z1ow@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=qi.z.zhang@intel.com \
--cc=stevex.yang@intel.com \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).