From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E60042C6E; Fri, 9 Jun 2023 14:38:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F101C40EDB; Fri, 9 Jun 2023 14:38:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DE02540A84 for ; Fri, 9 Jun 2023 14:38:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686314334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GkZ4u8ldFGFz8M4dJNPEzdpj//4V3jd3F4GWT+P08pc=; b=AH+ugcTajUcMKhajpZSH5Hhe0uCGOUMsEwJM+2Cra7bleYRcqtYe6ksh12bTudI/YmQk4w 5D68YOFIcL8egH7iM17epIxUm2TurKTkYpLNL5SFaIX+N4hk3LgLYR26o3mqpIMVLMDsov EhW/NTg9SizQYgd/OgvneNimblInyWI= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-195-FW-gJWuvMbWph0UMlGDnXg-1; Fri, 09 Jun 2023 08:38:53 -0400 X-MC-Unique: FW-gJWuvMbWph0UMlGDnXg-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-25b79a5cf1aso517125a91.1 for ; Fri, 09 Jun 2023 05:38:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686314332; x=1688906332; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GkZ4u8ldFGFz8M4dJNPEzdpj//4V3jd3F4GWT+P08pc=; b=NTVSUNLVw7M98Av49rkWB19VjMWK22wOerLRPQBTAVUHIWCF3SZhmj3sTfOq8y1STW HgoWDfqlxnfUYcwC0HMlOIaEjgBMaVlW8E79VC8v2MTVmXiQM0JpcgCL7Gp1rneSw3Ql xGKXbkNzmjCcoiAuZi2BhOsVHPNADl7uxVJJ00ZheH1uF8izJRErm+7sGFME9sYPXoy8 aa4m2y1cTZx49bvpDfINi1UkNYe9vtFMEfMRRzG7Z3O8wmZO1h9MUITPwA+k/HyA4h5D fGZl5hCa+SHLNTcBvATiuWybN6biul0na+KeRDSgEgDevxBSVTcmqmQFgTHLtP/Xw44Z 1s2w== X-Gm-Message-State: AC+VfDzJpo89WOHjhL31xjDuqABIeLyjgWw1AlDpIixOgY1WuRsexH5V yEcJRUkNuRv8FO2S1gLK4OAV6JEe5BHJU9rZh+Szm9q051rTNOCWp8/jCX2lOSdN0PNicDFbVuI Szdj+6YJOsUs7rvSHqh0= X-Received: by 2002:a17:90a:6408:b0:259:ba4a:134d with SMTP id g8-20020a17090a640800b00259ba4a134dmr5838724pjj.20.1686314332259; Fri, 09 Jun 2023 05:38:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4gqiHo9fF3kFDcQ9YYDmsBJtPJatO6bYinHDhKCQAkLg/jL6wPZSFZu2PwGxhkYIqcw7z8XhaKPpA64cFDHnI= X-Received: by 2002:a17:90a:6408:b0:259:ba4a:134d with SMTP id g8-20020a17090a640800b00259ba4a134dmr5838712pjj.20.1686314331969; Fri, 09 Jun 2023 05:38:51 -0700 (PDT) MIME-Version: 1.0 References: <1679092460-9930-1-git-send-email-roretzla@linux.microsoft.com> <20230403053412.GB19270@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20230602162208.GA12490@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20230602162208.GA12490@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Fri, 9 Jun 2023 14:38:41 +0200 Message-ID: Subject: Re: [PATCH 0/6] windows: remove most pthread lifetime shim functions To: Tyler Retzlaff , "Zhang, Qi Z" Cc: "Richardson, Bruce" , "dev@dpdk.org" , "thomas@monjalon.net" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 2, 2023 at 6:22=E2=80=AFPM Tyler Retzlaff wrote: > On Thu, Jun 01, 2023 at 12:23:39PM +0000, Zhang, Qi Z wrote: > > The patchset looks good to me. > > > > I have just one question regarding the patch set targets, which include= PMD iavf, ice, and ixgbe. However, I noticed that some other Intel PMDs li= ke ipn3ke still use rte_ctrl_thread_create and have not been replaced. > > The series really isn't about rte_ctrl_thread_create, it just happens > that for code built on Windows that code needs to stop using > rte_ctrl_thread_create because it references the pthread shim that is > being removed. > > At some point in the future (it's lower priority right now) I will > submit a series that converts all rte_ctrl_thread_create -> > rte_control_thread_create since rte_ctrl_thread_create is being > deprecated. > > > > > I assume that this replacement is specifically intended for PMDs that s= upport Windows, as PMDs with the "Windows" feature should be covered. Howev= er, I didn't see the "Windows" feature enabled for iavf PMD, even though it= is included in the patch set. > > > > Could you help me understand the criteria used for determining which PM= Ds should be included in this replacement? > > Yes, you are correct the patch is intended to address PMDs / code built > on Windows specifically. I just re-verified that iavf is being built > for Windows. > > If I remove the iavf patch from the series I get the following warning, > so that is why I adapted the iavf PMD code. > > [249/749] Compiling C object > drivers/libtmp_rte_net_iavf.a.p/net_iavf_iavf_vchnl.c.obj > ../drivers/net/iavf/iavf_vchnl.c:162:2: warning: implicit declaration o= f > function 'pthread_join' is invalid in C99 > [-Wimplicit-function-declaration] > pthread_join(handler->tid, NULL); > > > > > Thanks > > Qi > > > > > > > > The changes are straightforward and lgtm. > > > For the series, > > > Reviewed-by: David Marchand > > I think with the above explained the series should be okay as is, no > changes required if Qi is okay with the above explanation. Which seems to be the case. Thank you. --=20 David Marchand