From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com
 [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id 1F2F74CBD
 for <dev@dpdk.org>; Thu, 28 Feb 2019 09:48:06 +0100 (CET)
Received: by mail-ua1-f66.google.com with SMTP id c5so18124310uaq.7
 for <dev@dpdk.org>; Thu, 28 Feb 2019 00:48:06 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=ZYoAmVR5BrckW7bg46bwpvbcGR0N2+Ko82x/DwzTuqg=;
 b=RUvIrE+92gTslZ9C3Py95avBiSsBtVFxmRwTp9WeCxJ8TekIxQCTFQv62NldjqRBGy
 U6WW2y1iREdagQtF36qvH0qfOd9BR0K6OQqnjIM3eARIIghjGBQ+167V3jWvHDGawIOH
 I/UZA5bonnSuJTaCyEyPgHqzQKIK6k8n/9ahS7457pMbF9az6Hjer6vwPJ6gw0Swp5Fm
 8aQCyba2bEzVY1oS7vAJ95Yu2YxCAzSkOR3SOkou3VdFsnEdK7gDYtvPSwVFJJdsDmvM
 wZem/cTMKrAGKC3QZ9+cX+/1mXpHlIZAEW1QwN2r5W86C3V+2GdLjrgeBBGpcy4Fu823
 3ogw==
X-Gm-Message-State: AHQUAua0tk1IVdYPmMhBU2yCFw2BzE1ij+eWE8ZGpfA/H8X3sS/14+Mw
 dPfO+mL/T5sSmrbMOsrNCc6nqIUhhmMbmujyazxObQ==
X-Google-Smtp-Source: AHgI3IZW3Ldnr89uu3VouuAayKzf1kCZwQ2RP+jOoqU8Xgm6nUIWhVlCxElXJ0qs99/db9hEf+6COJU8L5baaaRwR7w=
X-Received: by 2002:a67:f69a:: with SMTP id n26mr4328782vso.105.1551343684034; 
 Thu, 28 Feb 2019 00:48:04 -0800 (PST)
MIME-Version: 1.0
References: <1551338000-120348-1-git-send-email-rosen.xu@intel.com>
 <1551338000-120348-9-git-send-email-rosen.xu@intel.com>
 <CAJFAV8xEbjhM+9hbDA+pb-8xzf_PMUviHEzVA0T7jkvtxH=FxQ@mail.gmail.com>
 <0E78D399C70DA940A335608C6ED296D73A5B8F96@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A5B8F96@SHSMSX104.ccr.corp.intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 28 Feb 2019 09:47:52 +0100
Message-ID: <CAJFAV8yYqVyvsfnBuvy6vdDO1YNcaw_AV=x_0AZpN-tFNJmo7g@mail.gmail.com>
To: "Xu, Rosen" <rosen.xu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, 
 "Zhang, Tianfei" <tianfei.zhang@intel.com>, "Wei, Dan" <dan.wei@intel.com>,
 "Pei, Andy" <andy.pei@intel.com>, "Yang, Qiming" <qiming.yang@intel.com>, 
 "Wang, Haiyue" <haiyue.wang@intel.com>, "Chen, Santos" <santos.chen@intel.com>,
 "Zhang, Zhang" <zhang.zhang@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE support
	for testpmd
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Feb 2019 08:48:06 -0000

On Thu, Feb 28, 2019 at 9:45 AM Xu, Rosen <rosen.xu@intel.com> wrote:

> Hi,
>
>
>
> *From:* David Marchand [mailto:david.marchand@redhat.com]
> *Sent:* Thursday, February 28, 2019 16:37
> *To:* Xu, Rosen <rosen.xu@intel.com>
> *Cc:* dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang,
> Tianfei <tianfei.zhang@intel.com>; Wei, Dan <dan.wei@intel.com>; Pei,
> Andy <andy.pei@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wang,
> Haiyue <haiyue.wang@intel.com>; Chen, Santos <santos.chen@intel.com>;
> Zhang, Zhang <zhang.zhang@intel.com>
> *Subject:* Re: [dpdk-dev] [PATCH v1 08/11] app/test-pmd: add IPN3KE
> support for testpmd
>
>
>
>
>
> On Thu, Feb 28, 2019 at 8:16 AM Rosen Xu <rosen.xu@intel.com> wrote:
>
> Add IPN3KE support for testpmd
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  app/test-pmd/Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
> index d5258ea..a6b6f6f 100644
> --- a/app/test-pmd/Makefile
> +++ b/app/test-pmd/Makefile
> @@ -62,6 +62,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y)
>  LDLIBS += -lrte_pmd_i40e
>  endif
>
> +ifeq ($(CONFIG_RTE_LIBRTE_IPN3KE_PMD),y)
> +LDLIBS += -lrte_pmd_ipn3ke
> +endif
> +
>  ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD),y)
>  LDLIBS += -lrte_pmd_bnxt
>  endif
>
>
>
> I am a bit lost.
>
> Why is it needed ?
>
> Involve IPN3KE in testpmd, for testpmd is widely used in NIC.
>

The drivers declared in this makefile are there because testpmd directly
calls private apis of those drivers.
Bis repetita, why is linking to ipn3ke needed here ?


-- 
David Marchand