From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Aaron Conole <aconole@redhat.com>, dev <dev@dpdk.org>,
Josh Soref <jsoref@gmail.com>
Subject: Re: [PATCH 1/1] ci: restrict concurrency
Date: Thu, 23 Jun 2022 09:59:43 +0200 [thread overview]
Message-ID: <CAJFAV8yYrLYOc7qE3hbaogApjDmYtRnOeGqSUmxxEE2WyTV52g@mail.gmail.com> (raw)
In-Reply-To: <5790133.UjTJXf6HLC@thomas>
On Thu, Feb 3, 2022 at 10:44 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 03/02/2022 21:21, Aaron Conole:
> > Thomas Monjalon <thomas@monjalon.net> writes:
> >
> > > Aaron, David,
> > > Please could you review this patch?
> > > Thanks
> > >
> > > 13/01/2022 13:41, Josh Soref:
> > >> On Thu, Jan 13, 2022, 6:42 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >>
> > >> > Hi,
> > >> >
> > >> > The explanation should be in the patch, not the cover letter.
> > >> > Actually, you don't need a cover letter for a single patch.
> > >> > Copying it here:
> > >> > "
> > >> > dpdk is fairly expensive to build in GitHub.
> > >> >
> > >> > It's helpful to abandon old builds as soon as there's a new
> > >> > build waiting instead of wasting resources on the previous
> > >> > round.
> > >> > "
> > >> >
> > >> > 12/01/2022 07:50, Josh Soref:
> > >> > > Signed-off-by: Josh Soref <jsoref@gmail.com>
> > >> > > ---
> > >> > > + concurrency:
> > >> > > + group: build-${{ matrix.config.os }}-${{ matrix.config.compiler
> > >> > }}-${{ matrix.config.library }}-${{ matrix.config.cross }}-${{
> > >> > matrix.config.mini }}-${{ github.event.pull_request.number || github.ref }}
> > >> > > + cancel-in-progress: true
> > >> >
> > >> > The goal of the CI is to catch any issue in a submitted patch.
> > >> > Is your change cancelling a test of a patch when another one is submitted?
> > >> >
> > >>
> > >> If it's on the same branch or if it's in the same pull request yes,
> > >> otherwise, no.
You can manually (in the GHA webui) interrupt an older build if you
pushed to a same branch.
> >
> > We currently have a report on every patch, which helps us when a patch
> > series has a breaking failure in the middle and then fixes it in a later
> > patch. With the mechanism you have here, we lose that ability - it is
> > important to have, as a `git bisect` can be broken without this feature.
>
> Good point.
>
> > How much of a problem is this in practice? I want us to be good
> > citizens, but also I don't want to lose the bisect-ability of the
> > series.
>
> Bisectability is important.
>
> So we have to reject this patch, right? Or any other idea?
I prefer the current behavior too.
Marking patch as rejected.
--
David Marchand
prev parent reply other threads:[~2022-06-23 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 6:50 [PATCH 0/1] " Josh Soref
2022-01-12 6:50 ` [PATCH 1/1] " Josh Soref
2022-01-13 11:42 ` Thomas Monjalon
2022-01-13 12:41 ` Josh Soref
2022-02-02 14:17 ` Thomas Monjalon
2022-02-03 20:21 ` Aaron Conole
2022-02-03 21:44 ` Thomas Monjalon
2022-06-23 7:59 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8yYrLYOc7qE3hbaogApjDmYtRnOeGqSUmxxEE2WyTV52g@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=jsoref@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).