From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7606BA0C41; Fri, 29 Oct 2021 20:57:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BBBC41103; Fri, 29 Oct 2021 20:57:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 8B677410E4 for ; Fri, 29 Oct 2021 20:57:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635533852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8SnGX4mLuX6alrSPhQQA6jXjcqeF+f7xhI1ZN3H2n8Q=; b=Zrx8QgJkEGAnkGlyKlOdTH2NrAOA9KVmMLXJyFBbS72nE9Z0pFh0/WS9l8ZnczJmEorfxn mYO2FTud5JSpUMK2EvRM/mz909DnQOvXSE+zsBfokVLNJnPgNhrdKrMENdB4SP9mQFJ0l/ QPHOESmZBUCYeGBnhwN8jYPBtsqqCt4= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-541-KyDtCUFVOW6M89gG9dSfTg-1; Fri, 29 Oct 2021 14:57:28 -0400 X-MC-Unique: KyDtCUFVOW6M89gG9dSfTg-1 Received: by mail-lf1-f72.google.com with SMTP id x7-20020a056512130700b003fd1a7424a8so4382167lfu.5 for ; Fri, 29 Oct 2021 11:57:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8SnGX4mLuX6alrSPhQQA6jXjcqeF+f7xhI1ZN3H2n8Q=; b=bZ30X3m81Utpk/wDKKjPv9KBnWEwbR0N5W0Yg3015hXNzy9zAVjALdMX+71DMTfgW8 zPXY0zQrYS3ASclDgJdTAuDbM2DAojGY7YfvUlkZCVIrbvCLSlDHf4dludXvluT9nNEY SRm8SA2fybhqZ6MRazHoETrDdSx4EnnFsc4e/LHq/c1DBUSHaFaJ4E5yS8daHj3YgZvZ zRQpaSFUW4WTr/d83f7z1apw+M7Ig9JzumBM46R/jS0j+X4pY0FxA/lEgJHrfVnBH5M0 CNQoMQ5E3Na9JV/dFruQfco6GtG5dNphbl7TZY6gvfbNc4OHpG/YOAFE8PwqDTLFXQc1 HsNA== X-Gm-Message-State: AOAM533tAo3jPJYwjRJGaorcw2iuonXXQiOXPh5fj8czJB8jVKvH+AIp 0HIwRTKoHqBrJkodz+c+iMjTxKWHqbWAAMP4KtjywQ19IUphA05ufId2YvIYGcSnWr6SreRBOpP zEpghQ1Mw03SLZG/OXfE= X-Received: by 2002:a05:651c:1107:: with SMTP id d7mr12984332ljo.81.1635533847197; Fri, 29 Oct 2021 11:57:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0JO4G2nw7gggfri5gpENICSx8K33pTPC/KFqxaK2wbb2lx7JcNMXtboLREwwz8ea4rOTGWLPecjegH9VT8uk= X-Received: by 2002:a05:651c:1107:: with SMTP id d7mr12984318ljo.81.1635533847042; Fri, 29 Oct 2021 11:57:27 -0700 (PDT) MIME-Version: 1.0 References: <20211029171622.330330-1-james.r.harris@intel.com> In-Reply-To: <20211029171622.330330-1-james.r.harris@intel.com> From: David Marchand Date: Fri, 29 Oct 2021 20:57:16 +0200 Message-ID: To: Jim Harris Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] test-compress-perf: fix unused-but-set-variable error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 29, 2021 at 7:18 PM Jim Harris wrote: > > clang-13 rightfully complains that the total_deq_ops > variable in cperf_cyclecount_op_setup is set but not > used, since the final accumulated total_deq_ops > results isn't used anywhere. So just remove the > total_deq_ops variable. Unused from the start: Fixes: 2695db95a147 ("test/compress: add cycle-count mode to perf tool") > > Signed-off-by: Jim Harris > --- > app/test-compress-perf/comp_perf_test_cyclecount.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/app/test-compress-perf/comp_perf_test_cyclecount.c b/app/test-compress-perf/comp_perf_test_cyclecount.c > index 55559a7d5a..c875ddbdac 100644 > --- a/app/test-compress-perf/comp_perf_test_cyclecount.c > +++ b/app/test-compress-perf/comp_perf_test_cyclecount.c > @@ -76,7 +76,6 @@ cperf_cyclecount_op_setup(struct rte_comp_op **ops, > > for (iter = 0; iter < num_iter; iter++) { > uint32_t remaining_ops = mem->total_bufs; > - uint32_t total_deq_ops = 0; > uint32_t total_enq_ops = 0; > uint16_t num_enq = 0; > uint16_t num_deq = 0; > @@ -136,7 +135,6 @@ cperf_cyclecount_op_setup(struct rte_comp_op **ops, > /* instead of the real dequeue operation */ > num_deq = num_ops; > > - total_deq_ops += num_deq; > rte_mempool_put_bulk(mem->op_pool, > (void **)ops, num_deq); > } > -- > 2.32.0 > Reviewed-by: David Marchand -- David Marchand