From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86EDEA034C; Mon, 14 Nov 2022 11:00:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5870940150; Mon, 14 Nov 2022 11:00:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 106804014F for ; Mon, 14 Nov 2022 11:00:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668420053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mvS2bnA1le8yDSLgvSM9QeLoqyBTif+sA9eKQMKNjFM=; b=C6MvyQa3IL0WpLdgSP9dFgAPks+heKjLMGSGOizjfzv+8N4y2RxJcnS9tzN3XR7/7iLFqu Z7tZq37t3e10CIm0pE+GstrF0B5e1HMo4cr0xivFbmC+LNUi+Zk7UBjXXJbYGSVsPUGgLB tnLu5n7+iZCwujVe8FNrviSUcU/aaU8= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-183-40yhqyLWNba7W492VcaTzw-1; Mon, 14 Nov 2022 05:00:52 -0500 X-MC-Unique: 40yhqyLWNba7W492VcaTzw-1 Received: by mail-pf1-f197.google.com with SMTP id c207-20020a624ed8000000b0056e3714b62cso5903399pfb.23 for ; Mon, 14 Nov 2022 02:00:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mvS2bnA1le8yDSLgvSM9QeLoqyBTif+sA9eKQMKNjFM=; b=t31ojKSRSeFV4/Ykaxocg2eUdlaiaSukGumSRHQEWhW4rEHWnotxUOM71GZqbcUM3z xpL2nKd/V+YQX0YCf3VD4dQHwSvNfkr1r3B6xuwO5GWwfItJxSN+uEtDUuTyhDNGYza2 kMBldZZZhEiksUu1fTyv1msJyU1VVn49NPN9Z7uTieryaiRgKRJEfqRPF8nPDAZCCbF6 uBISZsliFX6wfU3tTJoGmBSsnPO3Rt7FWtqvHFsEUAGk+Y4Za5wwJ6XdBatzQY5CdmIK iCEuMy8dX1wY1NiiqrYAiYZGv4IXwb2mHWkhlzvqA0BST9ZXcYRoOfSsigP+ONyE7KMR 7bMA== X-Gm-Message-State: ANoB5pn9gvMO/MHo++LMP0dQ9hLqq5E6E2cDeTcQ9O7gXWdIOC3r19kG roodgYGmx4ME3rEw3r3ZGE1esdLXmp0M1JvPAEO7niWtW1cY8Tlt2fBx0k2X52U0I1iF3QWJ2s+ /Z3O1R3G9W5ly0n1zM5g= X-Received: by 2002:a17:90a:53a6:b0:212:bf31:d00 with SMTP id y35-20020a17090a53a600b00212bf310d00mr12909217pjh.33.1668420051178; Mon, 14 Nov 2022 02:00:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf4xMCiUZsWzmWD728FF4lXeGsuBrycb/C5DoAWHPsqymemBmJpknTeUwgdD2WZdtAqr+T/q7Kr1xkPTP4BP6cs= X-Received: by 2002:a17:90a:53a6:b0:212:bf31:d00 with SMTP id y35-20020a17090a53a600b00212bf310d00mr12909198pjh.33.1668420050935; Mon, 14 Nov 2022 02:00:50 -0800 (PST) MIME-Version: 1.0 References: <20221012082928.2171562-1-tadhg.kearney@intel.com> <20221104162353.187145-1-tadhg.kearney@intel.com> In-Reply-To: From: David Marchand Date: Mon, 14 Nov 2022 11:00:39 +0100 Message-ID: Subject: Re: [PATCH] power: fix double free of opened files To: "Pattan, Reshma" , "Kearney, Tadhg" Cc: "dev@dpdk.org" , "Hunt, David" , "Burakov, Anatoly" , "Macnamara, Chris" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 7, 2022 at 10:18 AM Pattan, Reshma wrote: > > Fix double free of f_min and f_max by reverting the flcose() for f_min and > > f_max. As f_min and f_max are stored for further use and closed in uncore > > deinitialization. > > > > Fixes: b127e74 ("power: fix open file descriptors leak") Please, use 12 chars format for commit hash, as documented. git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'" > > > > Signed-off-by: Tadhg Kearney > > --- > > Acked-by: Reshma Pattan Applied, thanks. -- David Marchand