From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 612C2A09FF; Wed, 6 Jan 2021 17:19:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA98E140E05; Wed, 6 Jan 2021 17:19:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 6DFED140E05 for ; Wed, 6 Jan 2021 17:19:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609949944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oOQNbfUXVrowFmO6Jdru473MDx8eIM9Xp6GmmlzkXGs=; b=BiOMheOn0DGnkcitxpAZPNHaMBy7972ERfBd3KoomBSUXcVZ1JAclHb7LCsagr6PwVQDzM Qs250jfHuYUnObfopkoiUZUp0ehyF/mLDdPTFHxI7Hv0HVkLt7U5JFZxcbr/EPUyjmifpK k+dN+RP2BG95DJBr21VWy0r6iWrZsPY= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-gRE3uspJN7G9wkkkz9Y2mQ-1; Wed, 06 Jan 2021 11:19:03 -0500 X-MC-Unique: gRE3uspJN7G9wkkkz9Y2mQ-1 Received: by mail-vs1-f71.google.com with SMTP id a5so721836vsa.23 for ; Wed, 06 Jan 2021 08:19:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oOQNbfUXVrowFmO6Jdru473MDx8eIM9Xp6GmmlzkXGs=; b=BB2RZ6ZpmdC1jmcqjUVuOs9mok5D5yXirkVtQ15DV7xaRDmfjFnCJMo7sKeICm6aod TU+Us2r1k6MFCZ3Ze7nniJ96qsr6d4cNMxnoJpQQIx5qdeR2Y2QbHQtwDGMF+a2+qJJU 5GYTuwHGJYttcwBlZiM5BV0BerZO/blpvLEjDT6UGlK0hBJ8qnF77V9YNJbTjRIzTetL EE+/8dKbdFcF5PQIAFe5HKI8zGONM62v66z9mnUDZxArHUL36VIj2JqfSHj4/UoLByL0 hDKw+uHwRjyZTNshb9r8Vz3uEfENxNT4+v5R9dnBkQWOgvbwRcYQv4lNrCHkjMQ0RuGh AafA== X-Gm-Message-State: AOAM5314OVphSjFV3XpPugfJFAEE6RjZgK7D9K5EBrI1lQ59ZT4iEvdz 2+mawp6BSpg789FxK21XNhdVNUnfAwH7GjsM9KmVtV+NJWvUsAUxACy53BfY/JlJkbRXzhUbxhI 49dRPg0yLvGhO+PVDp3Q= X-Received: by 2002:a67:6781:: with SMTP id b123mr3997881vsc.10.1609949941991; Wed, 06 Jan 2021 08:19:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJww3GFq8z3nYFsktCYLgwyXB3BfYhD2A3UUOKMDemGSQrvgCJl3Vj1Mfx2ZZum1wpD6ZWYweR25VjSf3CLTjGA= X-Received: by 2002:a67:6781:: with SMTP id b123mr3997871vsc.10.1609949941844; Wed, 06 Jan 2021 08:19:01 -0800 (PST) MIME-Version: 1.0 References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-23-maxime.coquelin@redhat.com> In-Reply-To: <20201220211405.313012-23-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 6 Jan 2021 17:18:50 +0100 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 22/40] net/virtio: remove last PCI refs in non-PCI code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin wrote: > > This patch finalizes the bus isolation part of this > refactoring. > > Signed-off-by: Maxime Coquelin > --- [snip] > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > index 6c1df6f8e5..9274c48080 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -449,11 +449,11 @@ virtqueue_full(const struct virtqueue *vq) > } > > static inline int > -virtio_get_queue_type(struct virtio_hw *hw, uint16_t vtpci_queue_idx) > +virtio_get_queue_type(struct virtio_hw *hw, uint16_t vq_idx) > { > - if (vtpci_queue_idx == hw->max_queue_pairs * 2) > + if (vq_idx == hw->max_queue_pairs * 2) > return VTNET_CQ; > - else if (vtpci_queue_idx % 2 == 0) > + else if (vq_idx % 2 == 0) > return VTNET_RQ; > else > return VTNET_TQ; > -- > 2.29.2 > I noticed: drivers/net/virtio/virtqueue.h: uint16_t vq_queue_index; /**< PCI queue index */ Worth cleaning while at it? Reviewed-by: David Marchand Same comment as Chenbo, this is a great cleanup so far. I'll look at the rest of the series probably tomorrow. -- David Marchand