From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E1F945EBA; Mon, 16 Dec 2024 09:15:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8C0C402A3; Mon, 16 Dec 2024 09:15:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5C1D24025A for ; Mon, 16 Dec 2024 09:15:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734336955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q3R5T6z6v3SmIOGMyuUpWwetQ1WsMbQtKabx56q+kxc=; b=HSEYUNiRuRp1xnRW0Xqj1wEircPXxbF3dGziTFsq0e5GS02TomcnpeiF22DM5Et7moge7j HArEhenQpBycokN4fkaX04yo4pCYsjgYHu5s3vFhuEnbnCSPHSlisOag1noNDYoTxsJ8Lj zWQz6VlqZ8PFhB45RunAGrjYZgpHGWg= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-19-1KIX-pTTP-uqd-IeJLL3YQ-1; Mon, 16 Dec 2024 03:15:53 -0500 X-MC-Unique: 1KIX-pTTP-uqd-IeJLL3YQ-1 X-Mimecast-MFC-AGG-ID: 1KIX-pTTP-uqd-IeJLL3YQ Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-302325e576bso657891fa.2 for ; Mon, 16 Dec 2024 00:15:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734336952; x=1734941752; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q3R5T6z6v3SmIOGMyuUpWwetQ1WsMbQtKabx56q+kxc=; b=o+IndlKymQRpDjG2OwTVSHqvMlKSJj5D9ncNQoiNSXIbNeZnZVHyB/tijdugZo8PPg ui05R8F6iXgXjE5bjLu2YkJfp2euh2X1tNiT+Cg0LNwC8jOTMwLHud+VVQBJBWctFE+R b18NpTrlVj7Q6tBqqZ7p22Hl/ChmRsU0D08x372pKbyKNFW9FVwokh8CXjhocDtIVg9/ VZOQJcc7sgJueENknhtdh90w8wo8AYWS/i4t+F6X8GeDPnGMTeVQPC/J8Zjby1tCTo4S Njt9A9jv5nDHP0Ivp+KuIeG9OGc4gdUPMAeh9/Uai1QtenCEzkuHJQ6OoyvMZGpaFdgM C4XQ== X-Gm-Message-State: AOJu0YzH49Ux3p86aMi+6O/NEyfUmri0udewpSaouu5WuWPUGWyMO4dZ E1P3SBzknHlmOnQWkocmu/3IRxUu/jgfBhEl8ahpF+hNH8ybWHtwL9MkGdlJyRoDHxul3FusgRJ 11RacTXZKGIKW04MJtDAyntEEogWHjVCs/narFE1KOeNK+uj8V+i6foYO8Nj3ZFqcTFYk02goQi TZQCPW776CjeZFRvE= X-Gm-Gg: ASbGnctABLuDt7YMtvPsmD8ZtCKgKmyS2D/dCZVb0Sfbp3z58zq+h52dfrrfYQ7nZxO FWlnncmQo/DYp3n2oujJaePcw3UY4ARL10CwP5ilz X-Received: by 2002:a2e:bc02:0:b0:302:1cdd:73c6 with SMTP id 38308e7fff4ca-30254550a4dmr34469141fa.20.1734336951940; Mon, 16 Dec 2024 00:15:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfd+ITj4DVgxr36ZDZVDmQYfLtkQtaDcYXStNStdw1eN85iuwWXqncEllObc26M3/0va+J/lULMtyaCFHAkBI= X-Received: by 2002:a2e:bc02:0:b0:302:1cdd:73c6 with SMTP id 38308e7fff4ca-30254550a4dmr34469051fa.20.1734336951560; Mon, 16 Dec 2024 00:15:51 -0800 (PST) MIME-Version: 1.0 References: <20241127112617.1331125-1-david.marchand@redhat.com> <20241213105010.1527683-1-david.marchand@redhat.com> <20241213105010.1527683-5-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Mon, 16 Dec 2024 09:15:40 +0100 Message-ID: Subject: Re: [PATCH v2 4/6] drivers: fix exported headers To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, Long Li , Wei Hu , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj , Hemant Agrawal , Sachin Saxena , Vladimir Medvedkin , Ian Stokes , Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Jakub Palider , Tomasz Duszynski , Gagandeep Singh , Jingjing Wu , Stephen Hemminger , Akhil Goyal , Haiyue Wang , Jeff Guo , Michael Baum , Jerin Jacob , Shreyansh Jain , Nipun Gupta , Xiaoyun Li X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jscQO5eS9yyjQw8crPBe6qyGXcsXLK-ZzOoOhXA4rDw_1734336952 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Dec 13, 2024 at 2:46=E2=80=AFPM David Marchand wrote: > > > diff --git a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h b/drivers/raw/cnxk_= bphy/rte_pmd_bphy.h > > > index f668e6ea82..c200c935ff 100644 > > > --- a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h > > > +++ b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h > > > @@ -391,6 +391,7 @@ rte_pmd_bphy_intr_init(uint16_t dev_id) > > > { > > > struct cnxk_bphy_irq_msg msg =3D { > > > .type =3D CNXK_BPHY_IRQ_MSG_TYPE_INIT, > > > + .data =3D NULL, > > > }; > > > > > > > Why is this addition necessary? Is it for C++ compile? > > IIRC, this is because DPDK meson passes > -Wno-missing-field-initializers globally, and the Makefile I wrote > does not. > I'll double check. Yep, confirmed. ... In file included from /home/dmarchan/builds/main/build-x86-generic/buildtools/chkincs/rte_pmd_cnx= k_gpio.c:1: /home/dmarchan/builds/main/build-x86-generic/install/usr/local/include/rte_= pmd_cnxk_gpio.h: In function =E2=80=98int rte_pmd_gpio_get_pin_value(uint16_t, int, int*)=E2= =80=99: /home/dmarchan/builds/main/build-x86-generic/install/usr/local/include/rte_= pmd_cnxk_gpio.h:264:9: error: missing initializer for member =E2=80=98cnxk_gpio_msg::data=E2=80=99 [-Werror=3Dmissing-field-initializers] 264 | }; | ^ ... On the other hand, -Wmissing-field-initializers comes from -Wextra and it is explicitly disabled in meson. If we want to stick with -Wmissing-field-initializers "internally", I will drop those changes (and disable missing-field-initializers, trying to keep -Wextra in the "external" check) --=20 David Marchand