From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f65.google.com (mail-ua1-f65.google.com [209.85.222.65]) by dpdk.org (Postfix) with ESMTP id 83272201 for ; Mon, 4 Mar 2019 11:14:04 +0100 (CET) Received: by mail-ua1-f65.google.com with SMTP id q17so3907256uam.0 for ; Mon, 04 Mar 2019 02:14:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1A75PTsBUV7OG+SZyw6bOcaBFsi5+Vxc7UBJhE1QJGo=; b=rXycH3G31VfZsvAy4iBnz74Y67kdim6Cccsx42VFo8osqyZzjouLkDfRtUGmKa+36i vRdDK0Qfm9mH1c2iSSvM+3adiqfwyZMsXjHxkDrge5vZg7MnVt6Sd8pFWQ/Me5QPlUuj CIURWMcaNKxaPF6WPhM/VSoaCICOX/K1AxSO7lsvqV0telWAC3Ei1kAAZ+xNwE65E0/i q7IZCmgQkAzPf0nGofNnu0/t/7hjmq3FQweuAbIW911EBWZcG54eWT19rAPuGoDoV7oG vjfjQUwvCzaQIBn26z4Wjvw8zIpJdw26QuG4kLb8RB66FJ5DO7R+SeXMqhVNDmmX9dY0 Mhog== X-Gm-Message-State: APjAAAXeeyxKsQSWMZa3OUOTDM+nPFQj/Nn7MrcmKEPF/tfHOo27V7NH M2KvxQft+jacWXRiGCRXcLvXKA0FqbqGAWxd5TmVDQ== X-Google-Smtp-Source: APXvYqyEiyDfLbNZjra5C+Fu47ahxbsyalgJpFBJDMdDfOcbeKO/QlS0/74OW4YRdB3jpzzuUjrTCGXXD/qpQoCybuw= X-Received: by 2002:a67:fbc6:: with SMTP id o6mr9485987vsr.39.1551694443828; Mon, 04 Mar 2019 02:14:03 -0800 (PST) MIME-Version: 1.0 References: <20190301071847.13376-1-anand.rawat@intel.com> <20190301134736.GA310912@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190301134736.GA310912@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Mon, 4 Mar 2019 11:13:53 +0100 Message-ID: To: Bruce Richardson Cc: Anand Rawat , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 0/6] HelloWorld example for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2019 10:14:04 -0000 On Fri, Mar 1, 2019 at 2:48 PM Bruce Richardson wrote: > On Thu, Feb 28, 2019 at 11:18:41PM -0800, Anand Rawat wrote: > > Helloworld example for Windows. > > Includes Windows-specific EAL changes and meson > > changes to build the code on Windows. > > > > Anand Rawat (6): > > eal: eal stub to add windows support > > eal: Add header files to support windows > > eal: Add headers for compatibility with windows environment > > eal: add minimum viable code for eal on windows > > examples: Add meson changes for windows > > doc: add documention for windows > > > Thanks for this, it's good to see some progress here with small managable > patches. > > I've just tried this on my laptop using clang + meson + ninja. I see some > warnings at the link phase due to unknown flags, but otherwise things > compile and link ok and I get helloworld app running and printing hello > from all cores. Specifying a coremask doesn't seem to work though - perhaps > something to look at for a V2. > Some easy warnings to fix: [dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh ### eal: eal stub to add windows support WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #402: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:9: +eal_cpu_core_id(unsigned lcore_id) total: 0 errors, 1 warnings, 461 lines checked Warning in /lib/librte_eal/winapp/eal/eal_debug.c: Using rte_panic/rte_exit ### eal: add minimum viable code for eal on windows WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #239: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:10: + unsigned numTotalProcessors; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #240: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:11: + unsigned numProcessorSockets; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #241: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:12: + unsigned numProcessorCores; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #242: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:13: + unsigned reserved; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #280: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:50: + unsigned lcore = 0; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #281: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:51: + for (unsigned socket = 0; socket < WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #283: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:53: + for (unsigned core = 0; core < (win_cpu_map.numProcessorCores / WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #304: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:73: +eal_cpu_detected(unsigned lcore_id) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #313: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:80: +eal_cpu_socket_id(unsigned lcore_id) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #320: FILE: lib/librte_eal/winapp/eal/eal_lcore.c:87: +eal_cpu_core_id(unsigned lcore_id) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #348: FILE: lib/librte_eal/winapp/eal/eal_thread.c:15: +RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = LCORE_ID_ANY; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #356: FILE: lib/librte_eal/winapp/eal/eal_thread.c:23: +rte_eal_remote_launch(lcore_function_t *f, void *arg, unsigned slave_id) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #388: FILE: lib/librte_eal/winapp/eal/eal_thread.c:55: +eal_thread_init_master(unsigned lcore_id) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #406: FILE: lib/librte_eal/winapp/eal/eal_thread.c:73: + unsigned lcore_id; total: 0 errors, 14 warnings, 502 lines checked Warning in /lib/librte_eal/winapp/eal/eal.c: Using rte_panic/rte_exit 4/6 valid patches [dmarchan@dmarchan dpdk]$ ./devtools/check-git-log.sh Wrong headline uppercase: eal: Add header files to support windows eal: Add headers for compatibility with windows environment examples: Add meson changes for windows Wrong tag: Signed-off-by: Kadam, Pallavi Signed-off-by: Kadam, Pallavi Signed-off-by: Kadam, Pallavi Signed-off-by: Kadam, Pallavi Signed-off-by: Kadam, Pallavi Signed-off-by: Kadam, Pallavi -- David Marchand