From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by dpdk.org (Postfix) with ESMTP id A4DA05920 for ; Wed, 15 May 2019 14:45:17 +0200 (CEST) Received: by mail-vs1-f44.google.com with SMTP id y6so1614533vsb.0 for ; Wed, 15 May 2019 05:45:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WsnzbOKtzbL6nbOa+WiF/RzamQ1HSWwL64IG0GF2G8E=; b=Ly9H/aXMCSiNsyjRteIc9OB0Fn46SWI/5iVBtm2B8cIrosL4sxFHtbRHnQdW7gQg0y qH9a35pqjDb/qfNCaYxjVQGLbMQQ0VBPM7kp9wmnSNPIN08/oJ6TNsbfwfWAXPM+XfFW TZSsOeH2ZZQhJ8rItoryFm1nwRT2D2XcgJQ9388hiSXDcKiJvZMGU1RDKVlPR6SToVZF HGz9SvinjxepjFwAcPGM7kn756RgeXfJ6dMHqY1as5tvPKUWBtrYzFqq9wxr1uSMUBwb 59dliW/MgtVimQDHvv1Gok98QnFEf8T/IV0TnynX2qPumWfOak211k84Wo9urWOK6B7m 0WQQ== X-Gm-Message-State: APjAAAVmS00r0YYf0zKcpjKCFtbATpWEk97RHKxKF32IEcsPYvaPck7E R1ctvYpGH5bVAGNRCmI/L8ts1yvN08eUK12CTl7RJQ== X-Google-Smtp-Source: APXvYqzNum3RetdGRCAqTNkC7FNqjqh0anXH6HlyBrtpm5UhJ7OiKA/q32hBuEg8BO21pcoeITdyd1koYY5eWpxfuho= X-Received: by 2002:a67:fa95:: with SMTP id f21mr20181214vsq.180.1557924317049; Wed, 15 May 2019 05:45:17 -0700 (PDT) MIME-Version: 1.0 References: <20190409190630.31975-1-vivkong@ca.ibm.com> In-Reply-To: From: David Marchand Date: Wed, 15 May 2019 14:45:06 +0200 Message-ID: To: vivkong@ca.ibm.com Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 May 2019 12:45:18 -0000 Hello, On Thu, Apr 11, 2019 at 9:45 AM David Marchand wrote: > Hello, > > On Tue, Apr 9, 2019 at 9:06 PM Vivian Kong wrote: > >> To build and run DPDK on Linux on IBM Z (s390x), big endian support >> is added and s390x vector intrinics are used in the implementation >> > > intrinsics* > > of DPDK libraries. >> >> I appreciate your feedback. >> > > Quick check since this is not 19.05 material. > > - New files should be Copyright 2019. > - Avoid copy/paste from Power, noticed a reference to Power in the config > file. > - Configuration files are stacked, only enable/disable the needed parts in > the specific s390 file > - Meson must be added. > - No need to add dead code, remove the commented code like: > //#define dsb(opt) asm volatile("" : : : "memory") > - Comments using // are banned. > - No need to introduce a RTE_ACL_CLASSIFY_S390X to map to the scalar code. > Just avoid the SSE code to be selected in the build framework (iiuc). > - Avoid introducing empty lines > > > Run check scripts from devtools before submitting: > > [dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh > > ### mk: introduce s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 61 lines checked > > ### eal: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 601 lines checked > > ### acl: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 208 lines checked > > ### lpm: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 203 lines checked > > ### examples/l3fwd: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 410 lines checked > > ### net/i40e: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 0 checks, 647 lines checked > > ### test: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 192 lines checked > > ### hash: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 16 lines checked > > ### doc: introduce s390x architecture > > WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 2 warnings, 24 lines checked > > ### ethdev: add cast for bus_device > > WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 2 warnings, 8 lines checked > > ### mbuf: trivial fix > > WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 2 warnings, 8 lines checked > > ### test: miscellaneous test fixes > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 32 lines checked > > 0/12 valid patch > We are now post 19.05. This is the right time to propose new features/architectures. If you want to post a new series, please take into account the previous comments. Thanks. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 02360A00E6 for ; Wed, 15 May 2019 14:45:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA5CE5B1C; Wed, 15 May 2019 14:45:18 +0200 (CEST) Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by dpdk.org (Postfix) with ESMTP id A4DA05920 for ; Wed, 15 May 2019 14:45:17 +0200 (CEST) Received: by mail-vs1-f44.google.com with SMTP id y6so1614533vsb.0 for ; Wed, 15 May 2019 05:45:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WsnzbOKtzbL6nbOa+WiF/RzamQ1HSWwL64IG0GF2G8E=; b=Ly9H/aXMCSiNsyjRteIc9OB0Fn46SWI/5iVBtm2B8cIrosL4sxFHtbRHnQdW7gQg0y qH9a35pqjDb/qfNCaYxjVQGLbMQQ0VBPM7kp9wmnSNPIN08/oJ6TNsbfwfWAXPM+XfFW TZSsOeH2ZZQhJ8rItoryFm1nwRT2D2XcgJQ9388hiSXDcKiJvZMGU1RDKVlPR6SToVZF HGz9SvinjxepjFwAcPGM7kn756RgeXfJ6dMHqY1as5tvPKUWBtrYzFqq9wxr1uSMUBwb 59dliW/MgtVimQDHvv1Gok98QnFEf8T/IV0TnynX2qPumWfOak211k84Wo9urWOK6B7m 0WQQ== X-Gm-Message-State: APjAAAVmS00r0YYf0zKcpjKCFtbATpWEk97RHKxKF32IEcsPYvaPck7E R1ctvYpGH5bVAGNRCmI/L8ts1yvN08eUK12CTl7RJQ== X-Google-Smtp-Source: APXvYqzNum3RetdGRCAqTNkC7FNqjqh0anXH6HlyBrtpm5UhJ7OiKA/q32hBuEg8BO21pcoeITdyd1koYY5eWpxfuho= X-Received: by 2002:a67:fa95:: with SMTP id f21mr20181214vsq.180.1557924317049; Wed, 15 May 2019 05:45:17 -0700 (PDT) MIME-Version: 1.0 References: <20190409190630.31975-1-vivkong@ca.ibm.com> In-Reply-To: From: David Marchand Date: Wed, 15 May 2019 14:45:06 +0200 Message-ID: To: vivkong@ca.ibm.com Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190515124506.fOG0gU0rI3iRDNw8npPiORCL5HHq1-nBkiOuVSh1WOs@z> Hello, On Thu, Apr 11, 2019 at 9:45 AM David Marchand wrote: > Hello, > > On Tue, Apr 9, 2019 at 9:06 PM Vivian Kong wrote: > >> To build and run DPDK on Linux on IBM Z (s390x), big endian support >> is added and s390x vector intrinics are used in the implementation >> > > intrinsics* > > of DPDK libraries. >> >> I appreciate your feedback. >> > > Quick check since this is not 19.05 material. > > - New files should be Copyright 2019. > - Avoid copy/paste from Power, noticed a reference to Power in the config > file. > - Configuration files are stacked, only enable/disable the needed parts in > the specific s390 file > - Meson must be added. > - No need to add dead code, remove the commented code like: > //#define dsb(opt) asm volatile("" : : : "memory") > - Comments using // are banned. > - No need to introduce a RTE_ACL_CLASSIFY_S390X to map to the scalar code. > Just avoid the SSE code to be selected in the build framework (iiuc). > - Avoid introducing empty lines > > > Run check scripts from devtools before submitting: > > [dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh > > ### mk: introduce s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 61 lines checked > > ### eal: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 601 lines checked > > ### acl: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 208 lines checked > > ### lpm: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 203 lines checked > > ### examples/l3fwd: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 410 lines checked > > ### net/i40e: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 0 checks, 647 lines checked > > ### test: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 192 lines checked > > ### hash: add support for s390x architecture > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 16 lines checked > > ### doc: introduce s390x architecture > > WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 2 warnings, 24 lines checked > > ### ethdev: add cast for bus_device > > WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 2 warnings, 8 lines checked > > ### mbuf: trivial fix > > WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 2 warnings, 8 lines checked > > ### test: miscellaneous test fixes > > WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch > author 'Vivian Kong ' > > total: 0 errors, 1 warnings, 32 lines checked > > 0/12 valid patch > We are now post 19.05. This is the right time to propose new features/architectures. If you want to post a new series, please take into account the previous comments. Thanks. -- David Marchand