From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A5A4430BE; Mon, 21 Aug 2023 10:23:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77EBF42BC9; Mon, 21 Aug 2023 10:23:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9A2D740EE3 for ; Mon, 21 Aug 2023 10:23:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692606184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/ohmHdEoDyzR9p0k5YYfyFi8v20qzMg6U3Bc5i8srI=; b=fvBNbrpyrgVUl8qNBWEzgoXZzXiNq7NH94MAEnaET42REGd8DrN+F24P3oBsGzfExiYkRm 7TOd4ldXsG1WqxIvTdLTmtg4uH66y90fhDt741RIUYkBPZZZ9GnADLQ2jaB77Jjv4acCAt c8vg6UubYm6MWFCXglWFPu5veNFd2PQ= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-QUwfLWu9Ov2byF6yGuqvdQ-1; Mon, 21 Aug 2023 04:23:03 -0400 X-MC-Unique: QUwfLWu9Ov2byF6yGuqvdQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-50076a3fd35so1244805e87.1 for ; Mon, 21 Aug 2023 01:23:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692606182; x=1693210982; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e/ohmHdEoDyzR9p0k5YYfyFi8v20qzMg6U3Bc5i8srI=; b=gtlGTzWu8jkL9xF4yzAZwgraxCiE6HtNRxgpD/NVFSidOrbVJHba7KocY+a2o/bqK+ bnm8ftU1N4xFqvSkI4an28M5rcgaFecxkK34nkG85VLmQxe1mX3HVELw4M8zmalCA3SF aObaFDJ1LFRV0K30E4kx/+rADP7sCbVd+y6+2a0YG0cWYqAEsXw2Zf5h/FLKR19hq1LP /WHILxTxMVmgAoIIEEsyNzao/EgBqLGpQmcEcT1ZW0lNLez9+bkfETeE12SBSI2j8Z3x JwOM2Zy4/ZpbrThKfszt4e/Krunp50aRXkY2oKCBFRj9QUWuS8sT8X01sBqRl2uMvjKC D1Mg== X-Gm-Message-State: AOJu0YwYZT/3ezYGgSofICWUGW8CFiB/3OLew2J27aQV+EXttgG9VLX8 382LOAghy+8XIlT9vmmHDmzHvd3lYdQnxqBZ/hsX1afV4sLn4qe25TjNfLyuzNx0wtGIPspPcPH HmWaZ8u3Q8TcA2XeoAdg= X-Received: by 2002:a05:6512:3706:b0:4fb:820a:f87f with SMTP id z6-20020a056512370600b004fb820af87fmr3821969lfr.10.1692606181997; Mon, 21 Aug 2023 01:23:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGaVUmmwDRMmCr0SnwvHn/sb1YwOoRmfzb9mE67nhT7pDMI61MXCp2t5+I0AlJ/8dhuYPejzAvDjjO1TVXX3sw= X-Received: by 2002:a05:6512:3706:b0:4fb:820a:f87f with SMTP id z6-20020a056512370600b004fb820af87fmr3821951lfr.10.1692606181704; Mon, 21 Aug 2023 01:23:01 -0700 (PDT) MIME-Version: 1.0 References: <20230818090351.2402519-1-david.marchand@redhat.com> <59C4371C-6702-4704-ACAA-048794EA3A42@redhat.com> In-Reply-To: <59C4371C-6702-4704-ACAA-048794EA3A42@redhat.com> From: David Marchand Date: Mon, 21 Aug 2023 10:22:49 +0200 Message-ID: Subject: Re: [PATCH] net/iavf: fix checksum offloading To: Eelco Chaudron Cc: dev@dpdk.org, mkp@redhat.com, stable@dpdk.org, Jingjing Wu , Beilei Xing , Declan Doherty , Abhijit Sinha , Radu Nicolau X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 21, 2023 at 10:03=E2=80=AFAM Eelco Chaudron wrote: > On 18 Aug 2023, at 11:03, David Marchand wrote: > > > The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an indicator > > that a checksum offload has been requested by an application. > > Check that RTE_MBUF_F_TX_IP_CKSUM or others flags have been set. > > > > Fixes: 1e728b01120c ("net/iavf: rework Tx path") > > Cc: stable@dpdk.org > > Thanks for fixing this David! I tested and reviewed this change and it wo= rks now. For the record, Eelco encountered an issue with OVS 3.2 which now uses ip checksum offloading. Packets requiring such offloading were dropped by either the net/iavf driver or the i40e VF hw itself. --=20 David Marchand