From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA94743B6C; Thu, 7 Mar 2024 10:22:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4546B42E6A; Thu, 7 Mar 2024 10:22:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7A5A740295 for ; Thu, 7 Mar 2024 10:22:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709803342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tbcp191zCeIOfqrrxrVfLKnouQ0LU814YdJb1JmUKlw=; b=G5yBuZocBjIv6G6fufi2U2Q/x8F8GkrDmYZXaqvkyxBxxHYqPuJ4ut/sLi3CRl2SEdWPOW 8U2zN0Gw/A+U6fse1Yr7xQYjWh4iKkGCKwGLYOFI/Kk+b5pldQi4xHIPfwrbNSsULRpec5 7v8AHA6GBhn1+ENNLk3dA4+YgesAHu0= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-xwkGECQKMhu_h3CWlCnf3g-1; Thu, 07 Mar 2024 04:22:20 -0500 X-MC-Unique: xwkGECQKMhu_h3CWlCnf3g-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d30e16be75so4918581fa.1 for ; Thu, 07 Mar 2024 01:22:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709803339; x=1710408139; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tbcp191zCeIOfqrrxrVfLKnouQ0LU814YdJb1JmUKlw=; b=ZEnZ7G3ZudrFcM7D4iJL9mGBuTkSFenDtUoEI9xLAHx+P8tN2106FL3vRyHOwv8pu4 sFsg0M+JJc0p17pGv/INvaythi6+ZYnNyGg8c3pgUgKck69m+plGrZ41+2BBomPMvMKs gg/f8kFrxEq4eA6k+ARXhTfXdu/JyKZeSE3OZ0Iw4kC0Ur8KH93cZpFCeLDxDelNfOPS v1e8cOZJXK3zFgn/JdNr5SszfEdgwP4PhUmOktkgK92Lu6+MXZEjml9wsFb5rUDZNB8k aiweiZn4J6Nz++mNTik2tI0azr6Szyttous715S4q1vR6/b0jrrh9XdjnwVQAXo5xooc VPfA== X-Forwarded-Encrypted: i=1; AJvYcCX3xVtu0ak/ZRu5R7kYyMzsO2rsT5i48K07ArmKC2nKuCmweSqmYlYLb5JShjfELAkE1RH9AvyY827SrQ8= X-Gm-Message-State: AOJu0YwTeP5TWYXM7rQyiZXt4BRtHr8r+SKOxFXLMXmjj8QobhGOFxNf fx2ujtCYO4ubstUTdV718A0v78wOJRuMKPhoxVfCpv5ujGUm0YztHC5bjZPTsK1I4K2pf/VF6xr jLk94kt38p9P3doSAY6cZ1ehw0TlL7Z9mfpE4UPpjOx3PwXxoAvsA39OQR0KviKOsiwjNQze275 rurRAjmW0G5bFKpIM= X-Received: by 2002:a2e:720f:0:b0:2d3:9314:24d5 with SMTP id n15-20020a2e720f000000b002d3931424d5mr892020ljc.32.1709803339197; Thu, 07 Mar 2024 01:22:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHm+Ls7dlZdCOsw4utdMsaGoO4Gh40BdmFjn8nmFu7/swW9dlZKrtOwGBqVFAO8OaoWs8IItX2ssxJ/YDT2jE= X-Received: by 2002:a2e:720f:0:b0:2d3:9314:24d5 with SMTP id n15-20020a2e720f000000b002d3931424d5mr892008ljc.32.1709803338863; Thu, 07 Mar 2024 01:22:18 -0800 (PST) MIME-Version: 1.0 References: <20231218074905.42749-1-sivaprasad.tummala@amd.com> <98CBD80474FA8B44BF855DF32C47DC35E9F2DD@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F2DD@smartserver.smartshare.dk> From: David Marchand Date: Thu, 7 Mar 2024 10:22:06 +0100 Message-ID: Subject: Re: [PATCH 1/6] examples/l3fwd: fix lcore ID restriction To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Sivaprasad Tummala , david.hunt@intel.com, anatoly.burakov@intel.com, jerinj@marvell.com, radu.nicolau@intel.com, gakhil@marvell.com, cristian.dumitrescu@intel.com, ferruh.yigit@amd.com, konstantin.ananyev@huawei.com, dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 7, 2024 at 10:16=E2=80=AFAM Morten Br=C3=B8rup wrote: > > > From: David Marchand [mailto:david.marchand@redhat.com] > > Sent: Thursday, 7 March 2024 09.34 > > > > On Mon, Dec 18, 2023 at 8:49=E2=80=AFAM Sivaprasad Tummala > > wrote: > > > > > > Currently the config option allows lcore IDs up to 255, > > > irrespective of RTE_MAX_LCORES and needs to be fixed. > > > > "needs to be fixed" ? > > I disagree on the principle. > > The examples were written with limitations, this is not a bug. > > Unfortunately, l3fwd is not only an example; it is also used for benchmar= king. It really belongs in some other directory. > > With that in mind, I would consider it a bug that the benchmarking applic= ation cannot handle the amount of cores available in modern CPUs. This is not a bug. And with careful configuration (using --lcores), you can already start l3fwd with 254 datapath threads, right? --=20 David Marchand