* [PATCH] build: fix disabling developer mode
@ 2025-05-08 4:42 David Marchand
2025-05-12 15:28 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2025-05-08 4:42 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, Stephen Hemminger
A recent change broke disabling developer mode:
$ meson setup plop -Ddeveloper_mode=disabled
...
drivers/meson.build:150:14: ERROR: Unknown variable "fs".
Fixes: 8fa3af6c05f8 ("build: add generic support for base code in drivers")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 8436d1dff8..dfb4cb3aee 100644
--- a/meson.build
+++ b/meson.build
@@ -13,10 +13,11 @@ project('DPDK', 'c',
meson_version: '>= 0.57'
)
+fs = import('fs')
+
# check for developer mode
developer_mode = false
if get_option('developer_mode').auto()
- fs = import('fs')
developer_mode = fs.exists('.git')
else
developer_mode = get_option('developer_mode').enabled()
--
2.49.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] build: fix disabling developer mode
2025-05-08 4:42 [PATCH] build: fix disabling developer mode David Marchand
@ 2025-05-12 15:28 ` Bruce Richardson
2025-05-12 15:45 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2025-05-12 15:28 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Stephen Hemminger
On Thu, May 08, 2025 at 06:42:29AM +0200, David Marchand wrote:
> A recent change broke disabling developer mode:
> $ meson setup plop -Ddeveloper_mode=disabled
> ...
> drivers/meson.build:150:14: ERROR: Unknown variable "fs".
>
> Fixes: 8fa3af6c05f8 ("build: add generic support for base code in drivers")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> meson.build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 8436d1dff8..dfb4cb3aee 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -13,10 +13,11 @@ project('DPDK', 'c',
> meson_version: '>= 0.57'
> )
>
> +fs = import('fs')
> +
> # check for developer mode
> developer_mode = false
> if get_option('developer_mode').auto()
> - fs = import('fs')
> developer_mode = fs.exists('.git')
> else
> developer_mode = get_option('developer_mode').enabled()
> --
Simple fix, LGTM.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] build: fix disabling developer mode
2025-05-12 15:28 ` Bruce Richardson
@ 2025-05-12 15:45 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2025-05-12 15:45 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Stephen Hemminger, Bruce Richardson
On Mon, May 12, 2025 at 5:28 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> On Thu, May 08, 2025 at 06:42:29AM +0200, David Marchand wrote:
> > A recent change broke disabling developer mode:
> > $ meson setup plop -Ddeveloper_mode=disabled
> > ...
> > drivers/meson.build:150:14: ERROR: Unknown variable "fs".
> >
> > Fixes: 8fa3af6c05f8 ("build: add generic support for base code in drivers")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-12 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-08 4:42 [PATCH] build: fix disabling developer mode David Marchand
2025-05-12 15:28 ` Bruce Richardson
2025-05-12 15:45 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).