From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7D03A046B for ; Mon, 19 Aug 2019 10:40:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 557F01B952; Mon, 19 Aug 2019 10:40:43 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 039BC1B94A for ; Mon, 19 Aug 2019 10:40:41 +0200 (CEST) Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1739851EE1 for ; Mon, 19 Aug 2019 08:40:41 +0000 (UTC) Received: by mail-vk1-f199.google.com with SMTP id s17so1466781vkm.10 for ; Mon, 19 Aug 2019 01:40:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=eIWWDqbktdB28bHCL4bF1yVdIo7s6zsgCcEWbm97T7k=; b=If9mF+WU659MbL1i2+KU4WfK0Ns7eI+nZS+ackfNmHtSaTFGKJQNfcyqmtAD3UPXHu kM/MFw9USzhUjjRwbX5t3u0ZoxEr4wEZbbTFysk/vOvYXzSUrY6t0r59YQAn8nVr67qZ n7E0TKd+zmevG/y4juq9sDCFHrhG24OJsEyyu6+B7PtM2hunLVIutE8DDYqn00a3tZcJ cwg9HWbW1fa0/YBPpdcUPhfeYe2U9M15j4C/MpRWvRsept4P2XzpexF0X9DOK724wYll 8SyT0qW0BiixDd27yTAYGhL7U15bl4E/n6RPA0Hy8vnZGO2817eAaHUjAzkjhbWAsP9t yboA== X-Gm-Message-State: APjAAAU9oMZGN1sBuJkAJKS2VVRzchqtMBGsZP4DCJEFUdMU8fSPniKv hCijHkUv5hlQ/0jReuUhcpaukaezVOpOvMJc5jLjw66cB4e4pJO61kx22sI69dZfCk0iMZEEcn4 pbTooYNcwhtUXk6RWQmA= X-Received: by 2002:a67:a44f:: with SMTP id p15mr10916072vsh.105.1566204040368; Mon, 19 Aug 2019 01:40:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqzENbLaN7GrtuJhbRzd0HfSt6JF6kDoBrcaRpu5PY8thNLjLvITADSIKiwGXAxFeRC9rFq7JBCL5947KP4hBlU= X-Received: by 2002:a67:a44f:: with SMTP id p15mr10916061vsh.105.1566204040152; Mon, 19 Aug 2019 01:40:40 -0700 (PDT) MIME-Version: 1.0 References: <1565807801-72546-1-git-send-email-drc@linux.vnet.ibm.com> <1565807801-72546-3-git-send-email-drc@linux.vnet.ibm.com> In-Reply-To: From: David Marchand Date: Mon, 19 Aug 2019 10:40:29 +0200 Message-ID: To: David Christensen , Maxime Coquelin , Tiwei Bie Cc: dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 15, 2019 at 6:16 PM David Christensen wrote: > > >> Use of %llx print formatting causes meson build error on Power systems= with > >> RHEL 7.6 and gcc 4.8.5. Replace with PRIx64 macro. > >> > >> + (uint64_t)reg_struct.range.start, > >> + (uint64_t)reg_struct.range.start + > >> + (uint64_t)reg_struct.range.len - 1); > > I didn't need them when compiling on Power but it's the only way I could > get x86 to build without any warning: > > cc -Ilib/lib@@rte_vhost@sta -Ilib -I../lib -Ilib/librte_vhost > -I../lib/librte_vhost -I. -I../ -Iconfig -I../config > -Ilib/librte_eal/common/include -I../lib/librte_eal/common/include > -I../lib/librte_eal/linux/eal/include -Ilib/librte_eal/common > -I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 > -I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal > -I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs > -Ilib/librte_ethdev -I../lib/librte_ethdev -Ilib/librte_net > -I../lib/librte_net -Ilib/librte_mbuf -I../lib/librte_mbuf > -Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring > -I../lib/librte_ring -Ilib/librte_meter -I../lib/librte_meter > -Ilib/librte_cryptodev -I../lib/librte_cryptodev -Ilib/librte_hash > -I../lib/librte_hash -Ilib/librte_pci -I../lib/librte_pci -pipe > -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -O3 -include rte_config.h > -Wunused-parameter -Wsign-compare -Wcast-qual -D_GNU_SOURCE -fPIC > -march=3Dnative -fno-strict-aliasing -DALLOW_EXPERIMENTAL_API -MD -MQ > 'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o' -MF > 'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o.d' -o > 'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o' -c > ../lib/librte_vhost/vhost_user.c > ../lib/librte_vhost/vhost_user.c: In function =E2=80=98vhost_user_set_mem= _table=E2=80=99: > ../lib/librte_vhost/vhost_user.c:1088:4: warning: format =E2=80=98%lx=E2= =80=99 expects > argument of type =E2=80=98long unsigned int=E2=80=99, but argument 4 has = type =E2=80=98__u64=E2=80=99 > [-Wformat=3D] > RTE_LOG(INFO, VHOST_CONFIG, > ^ > ../lib/librte_vhost/vhost_user.c:1088:4: warning: format =E2=80=98%lx=E2= =80=99 expects > argument of type =E2=80=98long unsigned int=E2=80=99, but argument 5 has = type =E2=80=98__u64=E2=80=99 > [-Wformat=3D] > > This system was also RHEL 7.6 with gcc 4.8.5-36 Ok, I run the same. The catch is that I did not have RTE_LIBRTE_VHOST_POSTCOPY enabled in my working environment (using make) while meson enables it as long as userfaultd.h is present. Maxime, Tiwei, Can't we use uintXX_t instead of (what looks to me) kernel types __uXX ? --=20 David Marchand