From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 762F84308A; Thu, 17 Aug 2023 09:28:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED555410D0; Thu, 17 Aug 2023 09:28:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 93F9F40685 for ; Thu, 17 Aug 2023 09:28:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692257285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FQfAv5xE03OEJNLsk8fVKba2ZEJtJNXul1MpHXDgpa0=; b=EqpXHtdbR5byus0otx0G7LWWhdZT/7niZ9TnlC4PHaxLObuz+dthTFWUnGnA1+bUujfvUw WILxVPl89N73qoZZOzW16VKjUTboamL37ACbph9WFCtzYahfEnn8u7MH8a0WZocHZRLHkZ nFYpxolfczltiD69CFwPBqstavFfLq4= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-UKaP_GamMzmkgqCWkvJdxA-1; Thu, 17 Aug 2023 03:28:04 -0400 X-MC-Unique: UKaP_GamMzmkgqCWkvJdxA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4fe65cd1b3cso7223924e87.2 for ; Thu, 17 Aug 2023 00:28:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692257283; x=1692862083; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FQfAv5xE03OEJNLsk8fVKba2ZEJtJNXul1MpHXDgpa0=; b=Mbb9fhkZfsXi9h2CW91tOwcxsw61/Rgkh3xkBocfpoSzw5d3Bz/05Oj5EE75fFoKoa NV7uOT41UmzdnjD2bVOu6p+hyupomITN1JRfYdkpKFy0ZVcNi4UOXNNTgZzBcadY2GCm weKSrU7Zi6uMwM1KSV+Ox69w2i/358UJXnkIX9KNfAXHIGrIXorIZjN1GYPXAyixrNSQ LNWmB9WDzD2z+7n0BZOqmbTOY1Xopuy6hoZoZ/Nnf/PvRAdHr9UolRkwjE1P/0WL/unT JQ35SYWsvSEwnZp+CEi7OAcEbCysPMOAk5s/ZlVIIaAWySR9GzOjlqEpeOlFFKxUiUkN t82w== X-Gm-Message-State: AOJu0YxS9wiyWt1ITL+SvYL+SXjHPiLMf/izD51bsF/0W2LTfqlqB3R0 pwcDUGuNaCqeID9M7LCQ4Q9K/DBPJp77gnjf6U+oEZwNfIzxcnn11bCHGDeGZVkhMXt5zq29rS2 1e7oRAhs0pVmD4By0mnM= X-Received: by 2002:a05:6512:acc:b0:4fe:8ba9:4c4 with SMTP id n12-20020a0565120acc00b004fe8ba904c4mr3740721lfu.59.1692257282940; Thu, 17 Aug 2023 00:28:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbNxVMmhUdB4q9trqBGK9dJvbV/yPiAwrL5q94Ka7t8SSdAJS+DFgnb0FGlbKgPIfi62GWi+q9FniQoyNjJZM= X-Received: by 2002:a05:6512:acc:b0:4fe:8ba9:4c4 with SMTP id n12-20020a0565120acc00b004fe8ba904c4mr3740707lfu.59.1692257282606; Thu, 17 Aug 2023 00:28:02 -0700 (PDT) MIME-Version: 1.0 References: <20230721115125.55137-1-bruce.richardson@intel.com> <20230815151053.996469-1-bruce.richardson@intel.com> <20230815151053.996469-5-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Thu, 17 Aug 2023 09:27:50 +0200 Message-ID: Subject: Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix To: Patrick Robb Cc: Bruce Richardson , dev@dpdk.org, ci@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , Thomas Monjalon , Aaron Conole X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 16, 2023 at 8:30=E2=80=AFPM Patrick Robb wr= ote: >> Patching sources from the test tool is a poor solution. >> In general, developers won't be aware of source patching and will >> waste time trying to understand why they can't reproduce what the CI >> reports (it happened to me with DTS on the interrupt stuff with vhost, >> at least). >> >> For this specific case of skipping a test, if nobody can fix the >> issue, I prefer if the CI can skip some "known broken in my lab" tests >> via some meson configuration. >> And, such configuration should be easy to catch in the test report. >> > I strongly agree on all points, which is why I said it was probably a goo= d thing anyhow for us to lose this ability. In the case of the disabled fas= t-test for arm, that was a new discovery coming from adding new environment= s, not a regression introduced by a patch, and I don't think it made sense = then to block the introduction of the entire unit test coverage for arm whi= le they looked into this issue. If it's possible to introduce meson configu= re functionality to disable specific tests, that does give us more flexibil= ity. And it's obviously a better process than us doing it at the CI end. > > We don't currently patch source in any other way in our CI testing. It is possible to list tests from meson. Why not simply list the existing tests and filter the non working one? $ meson test -C --suite fast-tests --list $ meson test -C --test-args ... That requires no change in DPDK. --=20 David Marchand