From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 97D704555E;
Mon, 8 Jul 2024 15:28:32 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 86E2340E42;
Mon, 8 Jul 2024 15:28:32 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 0D3C14066A
for <dev@dpdk.org>; Mon, 8 Jul 2024 15:28:30 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1720445310;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=pYKhmgpjMh/TvusiZz+bbenvs5UWxcviYHXOw6V1nWM=;
b=Y+6eATA961uqWdO68R0IfcFR+TzE9PK9O36DUWXz/Qt75fBNdr52q+rZIZIY+pqYdmtJ4q
JFwdszA3q2IiapPlznVxujdncwNYA6z+RdpRGddTf9wSf3Vl4GDkjU9d6cVmJauFNeOSXN
gIQNEFEA4efb5MpHUK/KKwhpPc0TmeU=
Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com
[209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-537-DW_azEhGPcS5R27lRpsx0Q-1; Mon, 08 Jul 2024 09:28:29 -0400
X-MC-Unique: DW_azEhGPcS5R27lRpsx0Q-1
Received: by mail-lf1-f71.google.com with SMTP id
2adb3069b0e04-52e9b773505so3883918e87.1
for <dev@dpdk.org>; Mon, 08 Jul 2024 06:28:28 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1720445307; x=1721050107;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=pYKhmgpjMh/TvusiZz+bbenvs5UWxcviYHXOw6V1nWM=;
b=sdGHmNJr+NyV8J+XAedZVFdKQungBYuOqtHxDBQFEir5kgLSFpKeILwYZ0hYDioh9d
SmeHSTq0+U0Mai70oLJ/qia7oGIv2PyGlZ9zOzspSf+wcJRfvIvTDx1M+YPcpKbK0NzW
7+6iKHzmLVTF/6UsCCYCr1uRvnzhHbfIy62sQA8hIGOSONAmaGWAKmm7ZlYr3tmeJDZe
G+d3cFgJoNi/DBnGQYdZrn9+Uba2Sy+Z5mgJYgbHRmNpB+MWznXeYGpx4WsOEY4CkLzT
e0a0y830WwDujxF/p4YlaWPreLsyG8kGhzC+dXD9+t9CoWOuGsumVDGBZPUr8TJZ4cno
lCyA==
X-Gm-Message-State: AOJu0Yw2i1JkmuXsLrJC+SemmcTp5AhSa0mQYEKtA/hfbm4YEA3e+wRD
z+yWbxNRAFBr8hOeB1uV969pv9/u4wETRYQcwqeW7Tw/WlTM2PbCSyPZGlLdLFxuGVFJJKXbJ3h
HdOtWQWJrgKONXnrnFq42Z6lqPExi08lnAhFnIefvwGX1VImFFZrxXV9e6+N4NuJSP82C1b8FLL
MesUuW/UbLJsd6fio=
X-Received: by 2002:a19:ca55:0:b0:52e:9e70:d06e with SMTP id
2adb3069b0e04-52ea06cc0f9mr8681800e87.53.1720445307623;
Mon, 08 Jul 2024 06:28:27 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IHDmiS9fYYaO9fVLNfnZcW49QHav14uKNLhEjklUFibDc6rDACg7EVoz/AN1qK5Sd5V0U3lHMQcN5UxMAphHdo=
X-Received: by 2002:a19:ca55:0:b0:52e:9e70:d06e with SMTP id
2adb3069b0e04-52ea06cc0f9mr8681782e87.53.1720445307318; Mon, 08 Jul 2024
06:28:27 -0700 (PDT)
MIME-Version: 1.0
References: <20240705074208.1902771-2-vanshika.shukla@nxp.com>
<20240708072945.2376209-1-vanshika.shukla@nxp.com>
<20240708072945.2376209-3-vanshika.shukla@nxp.com>
In-Reply-To: <20240708072945.2376209-3-vanshika.shukla@nxp.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 8 Jul 2024 15:28:14 +0200
Message-ID: <CAJFAV8yeUWfeAzmR6azhYNY5CuTG1Z8JTinwJMgASPnK6tGbTQ@mail.gmail.com>
Subject: Re: [PATCH v3 2/8] bus/dpaa: fix resource leak in variable dev
To: vanshika.shukla@nxp.com
Cc: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>, Harman Kalra <hkalra@marvell.com>,
Hyong Youb Kim <hyonkim@cisco.com>, stable@dpdk.org,
Apeksha Gupta <apeksha.gupta@nxp.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Mon, Jul 8, 2024 at 9:29=E2=80=AFAM <vanshika.shukla@nxp.com> wrote:
>
> From: Apeksha Gupta <apeksha.gupta@nxp.com>
>
> Resource leak:
> variable dev is going out of scope leaks the storage.
>
> Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle")
> Cc: hkalra@marvell.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> Signed-off-by: Vanshika Shukla <vanshika.shukla@nxp.com>
This lgtm.
Was this issue detected by the public CI coverity?
If so, please add a Coverity ID: tag.
--=20
David Marchand