From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6C50433FD; Mon, 4 Dec 2023 13:33:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7833540DDE; Mon, 4 Dec 2023 13:33:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3538840DD8 for ; Mon, 4 Dec 2023 13:33:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701693186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xIiJvkr1Ru7uem0E2fCZFWfAoQFkQcfT6ehWwttAIIQ=; b=RtrZjCrbs3uIk7oSzE/1tuCWwha+T9/iHiuFvDzph+jTXtbAybAndz7H41RXmkJKKNZyg6 ATg+viZ1MzcgGgS+f9CQFGKZ1sUUD5+H5mCfItAGpxhHAZl0Hq/v2THsbBat5n7E3zrVcC 21kU8YKRD8E9E6xgVe1cTZADaJ54u6g= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-210-8McoWjBtMtucHyoI9AD9Kw-1; Mon, 04 Dec 2023 07:33:00 -0500 X-MC-Unique: 8McoWjBtMtucHyoI9AD9Kw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c9c217cfdeso47202001fa.1 for ; Mon, 04 Dec 2023 04:33:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701693179; x=1702297979; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xIiJvkr1Ru7uem0E2fCZFWfAoQFkQcfT6ehWwttAIIQ=; b=XgNTEVq8ipZOuqKjTE3CxGuxXwDCk1DCH1yw/eeLE6a0R49AIdXiNrwgq0mfCvfmJy OzyuWQjTVogColmdllm+vPwiTTwRQeFFKv03KxM9SMa33du9XP97yUFf8E9y8WUjFdO1 4z4eZFbFKi9w+/e7Rr/IoRPuUuAkv5hpsKanexNQOlc/z815myRRn57qZ/VyDDnHWYY9 WpmAJ16vHdvMVI0hpKz4vPJBt7GCz3i7luqfFpN3Bz+fMPOqm27fD0H2NZf19ndnFNoq lJOTnI+dKmGMpdyISTs9tJJb288GdVVTGF5Js/JT9BB2YrPhmf14NsZXeLD2PaGZimv8 qsrQ== X-Gm-Message-State: AOJu0YxtDH8v00B6NPzTcVsqEHOgfdMpjBm9473k+9jtFKvO3x0vbF+W g+qiTJWnHUVr8L1TUnZwBlbomG+YsEHgYtkVYoi7VJVVfcINEtIPYrnNZ4PrBlpsprxsGJlg3sX Z8V7E60d5ktlEdlQVrhywNm1cT/k= X-Received: by 2002:a19:700f:0:b0:50b:f4ff:4c06 with SMTP id h15-20020a19700f000000b0050bf4ff4c06mr749560lfc.110.1701693179055; Mon, 04 Dec 2023 04:32:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/dPHie+flalwF5YPa1B1XDo1Smu1rgl55toveKVc04sXYTBV/tj7DuNeq63HVyP10MmmjLhw2laCT6D81cUM= X-Received: by 2002:a19:700f:0:b0:50b:f4ff:4c06 with SMTP id h15-20020a19700f000000b0050bf4ff4c06mr749555lfc.110.1701693178658; Mon, 04 Dec 2023 04:32:58 -0800 (PST) MIME-Version: 1.0 References: <20230329234049.11071-1-stephen@networkplumber.org> <20230821160921.383832-1-stephen@networkplumber.org> In-Reply-To: <20230821160921.383832-1-stephen@networkplumber.org> From: David Marchand Date: Mon, 4 Dec 2023 13:32:47 +0100 Message-ID: Subject: Re: [PATCH v13 00/21] Convert static log types in libraries to dynamic types To: Stephen Hemminger Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 21, 2023 at 6:09=E2=80=AFPM Stephen Hemminger wrote: > > This patchset removes most of the uses of static LOGTYPE's in DPDK > libraries. It starts with the easy one and goes on to the more complex on= es. > > There are several options on how to treat the old static types: > leave them there, mark as deprecated, or remove them. > This version removes them since there is no guarantee in current > DPDK policies that says they can't be removed. > > Note: there is one patch in this series that will get > flagged incorrectly as an ABI change. > > v13 - rebase because log now moved. > > v12 - rebase and add table and pipeline libraries > > v11 - fix include check on arm cross build > > v10 - add necessary rte_compat.h in thash_gfni stub for arm > > v9 - fix handling of crc32 alg in lib/hash. > make it an internal global variable. > fix gfni stubs for case where they are not used. > > Stephen Hemminger (21): > gso: don't log message on non TCP/UDP > eal: drop no longer used GSO logtype > log: drop unused RTE_LOGTYPE_TIMER > efd: convert RTE_LOGTYPE_EFD to dynamic type > mbuf: convert RTE_LOGTYPE_MBUF to dynamic type > acl: convert RTE_LOGTYPE_ACL to dynamic type > examples/power: replace use of RTE_LOGTYPE_POWER > examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER > power: convert RTE_LOGTYPE_POWER to dynamic type > ring: convert RTE_LOGTYPE_RING to dynamic type > mempool: convert RTE_LOGTYPE_MEMPOOL to dynamic type > lpm: convert RTE_LOGTYPE_LPM to dynamic types > sched: convert RTE_LOGTYPE_SCHED to dynamic type > examples/ipsec-secgw: replace RTE_LOGTYPE_PORT > port: convert RTE_LOGTYPE_PORT to dynamic type > hash: move rte_thash_gfni stubs out of header file > hash: move rte_hash_set_alg out header > hash: convert RTE_LOGTYPE_HASH to dynamic type > table: convert RTE_LOGTYPE_TABLE to dynamic type > app/test: remove use of RTE_LOGTYPE_PIPELINE > pipeline: convert RTE_LOGTYPE_PIPELINE to dynamic type > This series needs some rebase. Thanks. --=20 David Marchand