From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 481D3A034F; Fri, 7 May 2021 11:06:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16B724013F; Fri, 7 May 2021 11:06:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 310AC40040 for ; Fri, 7 May 2021 11:06:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620378412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wJke+Oab7qiP6EdM9lroA3x0IPjMQxsNxgOM2qb8aq8=; b=HPiW6/GhG2TyTSL44u7gybEb7pzzm2FilIDHCiJHhGKN/iqVEferTt6NnzTK6MEkV1WNyn Cq/cUTuRukv0QeS9kc+CP2Z7pZC/MprzHPB50Q8f8v1eTlr/m4Wowuo2pfEmSMTTyVEJM0 5mnnYrUb8Gpy8oHcigCGeAiHhpnd1Vs= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-lkTjScJ7PAiZkQWTWC7W9Q-1; Fri, 07 May 2021 05:06:50 -0400 X-MC-Unique: lkTjScJ7PAiZkQWTWC7W9Q-1 Received: by mail-vk1-f198.google.com with SMTP id u186-20020a1fddc30000b02901eb1ea824ddso1017473vkg.12 for ; Fri, 07 May 2021 02:06:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wJke+Oab7qiP6EdM9lroA3x0IPjMQxsNxgOM2qb8aq8=; b=naZcLrQoto2soNbK5BS07TsBfF3IQ3mefOzG7D/1d5Wa1JeNxP+4zLlmTiVpn+TusD SyW3iv5UFis5TM6Wd+g7KEPOanOSsuD9ZzLKHglYHNQ4dhnJcqLXEBwSfTqAt0kfC8Sc t04kpY9WB+a0BgP82HiWcSTk3tyhozbH7kwfvvBJS6z+oqA9NJ0lk+6VWj5azyehD83e tR2icfKZIhQf2HZWbm40KvlCPTbwvaRb74bAISOJiyS45kVjZZCc3fxBl4HzuUHF7UJ2 osKfpAuGE9jCp8bcXX2RMYbX/D0lGVpA80Sl2fW5zkPesgjnD/v0Pou5rQ3TaAO8DNmX k1zg== X-Gm-Message-State: AOAM530Gsl7XmdCOTdm+BmDc7Zxk0vcew9RUBywDGAANczi9Q6J3XaVR 7rQtr/0D3SY1x4InKI2i9abo9zUAoERoU62f4bzRNY2YI6P7OPtdILxQtntjV9Whh+bmIXE8NF+ +PfPrEh/8Z/lduC87jpo= X-Received: by 2002:ab0:6d9a:: with SMTP id m26mr7516052uah.53.1620378409504; Fri, 07 May 2021 02:06:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwH12yW9NRJ5oa6WSOFjQ1EseLUN9q1Uh60Xsd+OfQhHpk+SPiD39NlpLkN9+mKKUZkNx5LsDASYdyY2fh7mCo= X-Received: by 2002:ab0:6d9a:: with SMTP id m26mr7516033uah.53.1620378409347; Fri, 07 May 2021 02:06:49 -0700 (PDT) MIME-Version: 1.0 References: <20210506151426.28202-1-david.marchand@redhat.com> <20210506151426.28202-3-david.marchand@redhat.com> <20210507012356.216f1f49@sovereign> In-Reply-To: <20210507012356.216f1f49@sovereign> From: David Marchand Date: Fri, 7 May 2021 11:06:38 +0200 Message-ID: To: Dmitry Kozlyuk , Ben Pfaff Cc: dev , Ian Stokes , Kevin Traynor , Olivier Matz , Ranjit Menon , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 7, 2021 at 12:24 AM Dmitry Kozlyuk wrote: > > 2021-05-06 17:14 (UTC+0200), David Marchand: > > Spotted by sparse in OVS build: > > ../../lib/netdev-dpdk.c: note: in included file (through > > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_ip.h, > > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h, ...): > > ../../include/sparse/arpa/inet.h:22:2: error: "Must include > > before for FreeBSD support" > > > > This is a check enforced by OVS itself. > > See [1] for some context. > > > > 1: https://github.com/openvswitch/ovs/commit/b2befd5bb2db > > > > Fixes: 89813a522e68 ("net: provide IP-related API on any OS") > > > > Signed-off-by: David Marchand > > --- > > lib/net/rte_ip.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h > > index 8c189009b0..4b728969c1 100644 > > --- a/lib/net/rte_ip.h > > +++ b/lib/net/rte_ip.h > > @@ -22,8 +22,8 @@ > > #else > > #include > > #include > > -#include > > #include > > +#include > > #include > > #endif > > > > Acked-by: Dmitry Kozlyuk > > It would be interesting to know exact issue this solves for OVS. > Referenced commit only says FreeBSD "insists" on this include order, > but DPDK and standalone files with these includes build either way. Indeed, I tried building with FreeBSD 13.0 and I can see no pb. This might be something that has been fixed in FreeBSD. Ben, would you have details on this header inclusion order? -- David Marchand