From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 797D2A0096
	for <public@inbox.dpdk.org>; Wed,  5 Jun 2019 09:31:43 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 93C881B965;
	Wed,  5 Jun 2019 09:31:42 +0200 (CEST)
Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com
 [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 7CA8E1B965
 for <dev@dpdk.org>; Wed,  5 Jun 2019 09:31:41 +0200 (CEST)
Received: by mail-vs1-f68.google.com with SMTP id l20so15158994vsp.3
 for <dev@dpdk.org>; Wed, 05 Jun 2019 00:31:41 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=cA5WSB4jp0UoKG8MFeQI+K1YEtyM6qxT9exh0ZA1FuA=;
 b=C1LSWGpt3jSVKDZKBWu/BE8iaa5y+0gHnPXJZs6f8RxK+aq6vb/w//U/DwslGx800j
 LDJjIpDHWtdBPpD/hPHjwFNm2YGI9xg1tYy4OaWpPqNYuyRWp8B8ZHIYtehAXA37WfnN
 UDzkKlIw1aAtArPri0Hzdj7ayu/1A1cogolSkSQOmUL6AkWN+aaxzyrsuiBpudewGCVr
 i3wvrL/NoECLU38FYnNXozwNpk03l0h/bMxENoyNe/TsUM5884eOFSgeSkIZMh+xMIRY
 FC57NR9fSqOEthF3bRau0jVm9QvOJzDmwLjEn6JQrGb4kg4p+bstY90b6Cn9g2E01OCH
 EoFA==
X-Gm-Message-State: APjAAAWjuud7x03N2DedlNvIx0uVHxfc99Nl7OsMi6CAOc/PL0kj6waK
 HKLIPDg8U7VSXzZ2vzMHAJAKTJjfiVeHb7t2ib6ajA==
X-Google-Smtp-Source: APXvYqyYpOIr8v9WAnzhOBNx8dcDqMp8EcpTxGW36srpkACdVfP9ha+H/FC/KbULJiaK1HOb9k4ykrGoQuCYiraZoWU=
X-Received: by 2002:a67:f998:: with SMTP id b24mr9028870vsq.180.1559719900926; 
 Wed, 05 Jun 2019 00:31:40 -0700 (PDT)
MIME-Version: 1.0
References: <20190604163147.105791-1-xiaolong.ye@intel.com>
 <20190605071829.113385-1-xiaolong.ye@intel.com>
In-Reply-To: <20190605071829.113385-1-xiaolong.ye@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 5 Jun 2019 09:31:29 +0200
Message-ID: <CAJFAV8ygs9vsFz2KxHUMkMYkL29ZP=r29wpYDuY93_hYmJvmJw@mail.gmail.com>
To: Xiaolong Ye <xiaolong.ye@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
 Bruce Richardson <bruce.richardson@intel.com>, 
 dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2] eal: correct error log for alarm
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 5, 2019 at 9:28 AM Xiaolong Ye <xiaolong.ye@intel.com> wrote:

> Fixes: af75078fece3 ("first public release")
> Fixes: 764bf26873b9 ("add FreeBSD support")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>
> v2:
>
> add freebsd fix suggested by David
>
>  lib/librte_eal/freebsd/eal/eal.c | 2 +-
>  lib/librte_eal/linux/eal/eal.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/freebsd/eal/eal.c
> b/lib/librte_eal/freebsd/eal/eal.c
> index c6ac9028f..a3b664125 100644
> --- a/lib/librte_eal/freebsd/eal/eal.c
> +++ b/lib/librte_eal/freebsd/eal/eal.c
> @@ -663,7 +663,7 @@ rte_eal_init(int argc, char **argv)
>         }
>
>         if (rte_eal_alarm_init() < 0) {
> -               rte_eal_init_alert("Cannot init interrupt-handling
> thread");
> +               rte_eal_init_alert("Cannot init alarm");
>                 /* rte_eal_alarm_init sets rte_errno on failure. */
>                 return -1;
>         }
> diff --git a/lib/librte_eal/linux/eal/eal.c
> b/lib/librte_eal/linux/eal/eal.c
> index 161399619..10e2887ca 100644
> --- a/lib/librte_eal/linux/eal/eal.c
> +++ b/lib/librte_eal/linux/eal/eal.c
> @@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
>         }
>
>         if (rte_eal_alarm_init() < 0) {
> -               rte_eal_init_alert("Cannot init interrupt-handling
> thread");
> +               rte_eal_init_alert("Cannot init alarm");
>                 /* rte_eal_alarm_init sets rte_errno on failure. */
>                 return -1;
>         }
> --
> 2.17.1
>
>
Reviewed-by: David Marchand <david.marchand@redhat.com>

-- 
David Marchand