From: David Marchand <david.marchand@redhat.com>
To: Nipun Gupta <nipun.gupta@nxp.com>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] config: disable iova phys for dpaa and 1588 for dpaa2
Date: Sun, 27 Oct 2019 12:03:08 +0100 [thread overview]
Message-ID: <CAJFAV8ygsacNpvgV+zdM_S75jZTuDNboA84+w8RZgngz174fSQ@mail.gmail.com> (raw)
In-Reply-To: <20191004111106.30267-1-nipun.gupta@nxp.com>
On Fri, Oct 4, 2019 at 1:26 PM Nipun Gupta <nipun.gupta@nxp.com> wrote:
>
> IOVA_PHYS flag is not required in the DPAA config, thus disable it.
> Also, disable the 1588 timer support by default on DPAA2 platform
> due to the performance impact
With this patch, we don't have a single target using the 1588 timer support.
This means that it will get broken in the future.
Is this used?
>
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
With this patch, the meson configuration is unaligned with the make
configuration.
If I look before the patch:
origin/master:config/meson.build:dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA',
true)
origin/master:config/arm/meson.build:
['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]]
origin/master:config/common_base:CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y
origin/master:config/defconfig_arm64-dpaa2-linuxapp-gcc:CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=n
And in the history, I understand:
- option (with dpaa2 in the name) introduced and enabled for all
- later, disabled for dpaa2
Does it mean the option can be removed?
--
David Marchand
next prev parent reply other threads:[~2019-10-27 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 11:11 Nipun Gupta
2019-10-10 12:26 ` Hemant Agrawal
2019-10-27 11:03 ` David Marchand [this message]
2019-10-30 9:36 ` Nipun Gupta
2019-10-30 10:14 ` David Marchand
2019-10-31 6:56 ` Nipun Gupta
2019-10-31 12:48 ` [dpdk-dev] [PATCH v2] config: disable 1588 timer support on DPAA2 Nipun Gupta
2019-10-31 16:18 ` David Marchand
2019-11-01 2:52 ` Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8ygsacNpvgV+zdM_S75jZTuDNboA84+w8RZgngz174fSQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).