From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28605A009E for ; Sun, 27 Oct 2019 12:03:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3C4D1BF2E; Sun, 27 Oct 2019 12:03:23 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 34DAF1BE0C for ; Sun, 27 Oct 2019 12:03:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572174202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=27pkNxjSidXzrEtlfYODY0ZGNd0VgNKPUlp1ZQ3c7a0=; b=GtE1jDEHcj6TWjSwWkQSXyotTljcMsQkj93Fcp40hgse05OghZII7fjjK69mUqkR2XqM3R /tL9rxZjusXt7+ivMRq2I0HKcJUnLoZ11D66PFHSjmNTCS9wybkiAj0wnimpxy0im/mHa9 tDWpIrmsmYX3wDd1KI1dSbXe62CjdKQ= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-rnSNZMaPPUefzU3cNxAdtQ-1; Sun, 27 Oct 2019 07:03:20 -0400 Received: by mail-vk1-f200.google.com with SMTP id a188so2944898vkc.7 for ; Sun, 27 Oct 2019 04:03:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KUwyRZgE+1RNbDgv2TlokKJMchFWliHrA5iISTYnK2w=; b=fJDE+EJhgbjwIOhXWTKyf9Utbmwfn8oAvke+4tRkEmioxy773iLO0iGqMz/qyNZToK cpjtTZC3vw8lL36EI+SHThoNDoLRxT9PKod7xHwRkxqtdP5O4ExHxUwyXEbpZUjoQZYr 3ofV83xnETLS/tA/NoEjFUe1Chg+ex2Jq3q72J40fQmxTRBGC+Ov3r7Q4RWH/W0Cknfq P7c1uSZZ8UDL+G6MarfN5I99RP8CrAKiwxiAhZZ/s6Kn5Muj4TAk+q4TgkBWM54Jj7VF HN1mqk1gWq+e2Mry0H+g1HfRTocpfAvHa/RQy8cTxRYIcmPbB8lff1JbJ4S402By9eQu y/yw== X-Gm-Message-State: APjAAAV58zb6iVw7DDKaccY84dMOHbfnpnOsUl9CQLDGltml2BS7ZFBb u8kD4gkEvvAus6loZvsHAv5lqTr9ZqD1XySUtcHp6QmLpx7629OPXdiKeip5gFoLQNTMtyLP69o LRRgIXWQSDFUy8NIPJz8= X-Received: by 2002:ab0:189a:: with SMTP id t26mr5960522uag.87.1572174199675; Sun, 27 Oct 2019 04:03:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqzpXLo7pbkx7M1cSEUKobpK1qyTCt+UrfV/dylInbF1sCjbmrmj/w+AQ2t89hqwNFD0umx/V1hGMKgsUS/IcQk= X-Received: by 2002:ab0:189a:: with SMTP id t26mr5960510uag.87.1572174199143; Sun, 27 Oct 2019 04:03:19 -0700 (PDT) MIME-Version: 1.0 References: <20191004111106.30267-1-nipun.gupta@nxp.com> In-Reply-To: <20191004111106.30267-1-nipun.gupta@nxp.com> From: David Marchand Date: Sun, 27 Oct 2019 12:03:08 +0100 Message-ID: To: Nipun Gupta Cc: dev , "Yigit, Ferruh" , Hemant Agrawal , Sachin Saxena , Thomas Monjalon X-MC-Unique: rnSNZMaPPUefzU3cNxAdtQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] config: disable iova phys for dpaa and 1588 for dpaa2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 4, 2019 at 1:26 PM Nipun Gupta wrote: > > IOVA_PHYS flag is not required in the DPAA config, thus disable it. > Also, disable the 1588 timer support by default on DPAA2 platform > due to the performance impact With this patch, we don't have a single target using the 1588 timer support= . This means that it will get broken in the future. Is this used? > > Signed-off-by: Nipun Gupta With this patch, the meson configuration is unaligned with the make configuration. If I look before the patch: origin/master:config/meson.build:dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_I= OVA', true) origin/master:config/arm/meson.build: ['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]] origin/master:config/common_base:CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=3Dy origin/master:config/defconfig_arm64-dpaa2-linuxapp-gcc:CONFIG_RTE_LIBRTE_D= PAA2_USE_PHYS_IOVA=3Dn And in the history, I understand: - option (with dpaa2 in the name) introduced and enabled for all - later, disabled for dpaa2 Does it mean the option can be removed? --=20 David Marchand