From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0F7AA04BA; Wed, 7 Oct 2020 09:45:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E0992C16; Wed, 7 Oct 2020 09:45:10 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id E351B1E35 for ; Wed, 7 Oct 2020 09:45:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602056706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M/wpnmFSJzjAohpdo0n4591c2lMbH+XSDKQqq7YsPak=; b=MSbqsYhaT0abYIlo+TZsCpOe9jxJ6xO+Kw5SROLdXkHcftd5ipEdrbHH7K2TG/6jV9AW1e hW2YbqZ7CHQ4BUNUpHAhcvMQMxIm9amZdAICsjukc/V25CpVHYy+dn+duYKU89LJaCwUab R+ldojSuECv8qKTZpL0A/a9xt+RGOT0= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-345-ps0Wu9iyPq67NizoVwlGGQ-1; Wed, 07 Oct 2020 03:45:04 -0400 X-MC-Unique: ps0Wu9iyPq67NizoVwlGGQ-1 Received: by mail-ua1-f72.google.com with SMTP id r22so488835uao.20 for ; Wed, 07 Oct 2020 00:45:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M/wpnmFSJzjAohpdo0n4591c2lMbH+XSDKQqq7YsPak=; b=Q4bZMLVYRCXcYYhRao5pd6Ier4FMf3V5Yr75ga1MktDMGM/P6ZS6IGyx22fwOeUIbR JVd4i6iLGVWyQBsm+NdPLE1lgKlyMqT73XwlnIuM+Fzlj90Ng2sc8+aXTQknBbqSxSf/ mTrjWrpoaSLTOGmBULZwdNWAkg7pH8xWPzF4/Mp0Z4JfQyoz54k8zYpmFV+flNmFVqkU ILbbAuiAA1OegTmQCWQGAnvFiKzq2nxHhvEak/sI42/R3vPNK4HndDoZfziV0eVunATl H4QKngy6LMzIFuyk/wifXjxU9HxBgbs+iqpU/tNSvQ6l10fv8v6TcoZJD7JpgxrGhl3t OFPQ== X-Gm-Message-State: AOAM533qTDu5DueRJ90+9geuMovkulagu1uNHeAEJIk6Ch1lKLSEj2L5 y5OJ8aqFn7QcFXv5ZqG0QNJ7CCGMu6VwioqhxAZA7kX9nmp5j8E9tYC229w+KGjK+Hnqrn/Hcwf TEu8CIwAGoeWU1B6oCJ8= X-Received: by 2002:a1f:9651:: with SMTP id y78mr946936vkd.22.1602056703395; Wed, 07 Oct 2020 00:45:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlXJtn7NGXIxDLlca7Vv7RnP5qZ40j9lOaFb+KhLnw9x8MbBRX8NhL2FfU8w+LWWzd+EbnP67e1tDhca9iqCY= X-Received: by 2002:a1f:9651:: with SMTP id y78mr946928vkd.22.1602056703055; Wed, 07 Oct 2020 00:45:03 -0700 (PDT) MIME-Version: 1.0 References: <20201006202250.3623749-1-thomas@monjalon.net> In-Reply-To: <20201006202250.3623749-1-thomas@monjalon.net> From: David Marchand Date: Wed, 7 Oct 2020 09:44:52 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Jerin Jacob Kollanukkaran , Bruce Richardson , "Ruifeng Wang (Arm Technology China)" , Jan Viktorin , David Christensen , "Ananyev, Konstantin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] maintainers: improve coverage of arch-specific files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 6, 2020 at 10:23 PM Thomas Monjalon wrote: > > The sub-directories of config/ are maintained by > different architecture maintainers. > > Some wildcards are used to describe the lib and drivers files > which are specific to some architectures. I noticed "some" misses, see below. > > The EAL Arm files have split responsibilities depending on 32/64 suffix, > and the common files are shared between Armv7 and Armv8 sections. > > Signed-off-by: Thomas Monjalon > --- > MAINTAINERS | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 75a17d51c0..349fc9c38a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -256,32 +256,31 @@ F: app/test/test_rand_perf.c > ARM v7 > M: Jan Viktorin > M: Ruifeng Wang > +F: config/arm/ > F: lib/librte_eal/arm/ > +X: lib/librte_eal/arm/include/*_64.h > > ARM v8 > M: Jerin Jacob > M: Ruifeng Wang > -F: lib/librte_eal/arm/include/*_64.h > -F: lib/librte_net/net_crc_neon.h > -F: lib/librte_acl/acl_run_neon.* > -F: lib/librte_bpf/bpf_jit_arm64.c > -F: lib/librte_lpm/rte_lpm_neon.h > -F: lib/librte_hash/rte*_arm64.h > -F: lib/librte_efd/rte*_arm64.h > -F: lib/librte_table/rte*_arm64.h > -F: drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c > -F: drivers/net/i40e/i40e_rxtx_vec_neon.c > -F: drivers/net/virtio/virtio_rxtx_simple_neon.c > +F: config/arm/ > +F: lib/librte_eal/arm/ > +X: lib/librte_eal/arm/include/*_32.h > +F: lib/*/*_neon.* > +F: lib/*/*_arm64.* > +F: drivers/*/*/*_neon.* app and examples directory are not caught in this: ./lib/librte_net/net_crc_neon.h ./lib/librte_acl/acl_run_neon.h ./lib/librte_acl/acl_run_neon.c ./lib/librte_lpm/rte_lpm_neon.h ./lib/librte_node/ip4_lookup_neon.h ./examples/l3fwd/l3fwd_lpm_neon.h ./examples/l3fwd/l3fwd_em_hlm_neon.h ./examples/l3fwd/l3fwd_neon.h ./app/test-pmd/macswap_neon.h ./drivers/net/hns3/hns3_rxtx_vec_neon.h ./drivers/net/bnxt/bnxt_rxtx_vec_neon.c ./drivers/net/mlx5/mlx5_rxtx_vec_neon.h ./drivers/net/virtio/virtio_rxtx_simple_neon.c ./drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c ./drivers/net/i40e/i40e_rxtx_vec_neon.c Can we use a wildcard at dpdk root? */*/*_neon.* The drivers/*/*/*_neon.* entry would still be needed though. > > IBM POWER (alpha) > M: David Christensen > +F: config/ppc/ > F: lib/librte_eal/ppc/ > -F: drivers/net/i40e/i40e_rxtx_vec_altivec.c > +F: drivers/*/*/*_altivec.* > F: examples/l3fwd/*altivec.h Idem neon, lib files missing. ./lib/librte_eal/ppc/include/rte_altivec.h ./lib/librte_acl/acl_run_altivec.c ./lib/librte_acl/acl_run_altivec.h ./lib/librte_lpm/rte_lpm_altivec.h ./examples/l3fwd/l3fwd_altivec.h ./examples/l3fwd/l3fwd_lpm_altivec.h ./drivers/net/mlx5/mlx5_rxtx_vec_altivec.h ./drivers/net/virtio/virtio_rxtx_simple_altivec.c ./drivers/net/i40e/i40e_rxtx_vec_altivec.c > > Intel x86 > M: Bruce Richardson > M: Konstantin Ananyev > +F: config/x86/ > F: lib/librte_eal/x86/ Nothing for avx/sse ? > > Linux EAL (with overlaps) > -- > 2.28.0 > -- David Marchand