From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DCFDA0C47; Wed, 3 Nov 2021 21:03:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D092841121; Wed, 3 Nov 2021 21:03:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 393F640689 for ; Wed, 3 Nov 2021 21:03:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635969813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QfRUUHorjsVodkdovteb10/s3mLkTyKmMg2zFZdZtoM=; b=MF0/diHWYGtJhzTET+2J33e9tBpDHeMF+LX2rzrqleAVcwo/Q1tMgK+mbBfI4gu/BQL4Tn 16XLkM93NVwWfq8rVD9xu61EHW0Tkh7/VgibVx/euXqo73TyjuVsxkhBuVSgWiY6RDW5hV pJ/3ba7Tgs31Zfw3tbyfxRBKn8ElW2M= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-5JudmFJJO-Kk3tX1EQ1fmA-1; Wed, 03 Nov 2021 16:03:32 -0400 X-MC-Unique: 5JudmFJJO-Kk3tX1EQ1fmA-1 Received: by mail-lj1-f197.google.com with SMTP id h14-20020a2ea48e000000b0021789353d84so1507599lji.15 for ; Wed, 03 Nov 2021 13:03:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QfRUUHorjsVodkdovteb10/s3mLkTyKmMg2zFZdZtoM=; b=R15uG9gdupKNHsRdcN5Shg7MLdfOl26Kh5ZfaQHSKXvxdebpJk6EU1rAKvSwZLkW9m lh6A/u/yUHDdNVqs5AbgHKh7ZWyaU5c0nNPN1aYKsbllmDJFpMiFOf+r/zf6aoHrJGhR SMuTbmUCZzCz4TtmbEvQOXyvkndWj/bLfgVdHLCUrlWYtKZjdaUVhPYR1rd7x1hfObw7 eH4PO17PrAwcQ5n9E+DxocewyhB0mQbwMRVmYvpbBs0oir+GKb/rctwiAnTJWqE516eg IBl0nDqtHYGhIKAcFkTIGBI00JFYpKPB0/4nk5bKJBRUQVEoGx9Mm6gc9B8+zEfk9LVq eHwQ== X-Gm-Message-State: AOAM530JY7mCTWdVKLAue+RFm9idYvt/Q5DafvVdD7HiIW++JTKfHtqK I7iN491ZGqqchR54CnG80b4ajW5aL61MPnAJS2buf9Wd9OhV0lC0mjsiIV8z3LqiWGJNYybCpg2 kyuc+EmtHIdUzcAI3o0I= X-Received: by 2002:a05:6512:3d2:: with SMTP id w18mr5432805lfp.265.1635969811020; Wed, 03 Nov 2021 13:03:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaPmHoBTfwZxzDhb7He15aNvRX/VSYoK1fPDAozFm0UFuOKzMGADFGAf9KtKvMogwHHnxGlifcO6Pbr8orG0c= X-Received: by 2002:a05:6512:3d2:: with SMTP id w18mr5432777lfp.265.1635969810681; Wed, 03 Nov 2021 13:03:30 -0700 (PDT) MIME-Version: 1.0 References: <20211029095310.30785-1-olivier.matz@6wind.com> In-Reply-To: <20211029095310.30785-1-olivier.matz@6wind.com> From: David Marchand Date: Wed, 3 Nov 2021 21:03:19 +0100 Message-ID: To: Olivier Matz , Anatoly Burakov Cc: dev , Maxime Coquelin , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal/memory: fix unused SIGBUS handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 29, 2021 at 11:53 AM Olivier Matz wrote: > > Since its introduction in 2018, the SIGBUS handler was never registered, > and all related functions were unused. > > A SIGBUS can be received by the application when accessing to hugepages > even if mmap() was successful, This happens especially when running > inside containers when there is not enough hugepages. In this case, we > need to recover. A similar scheme can be found in eal_memory.c. > > Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime") > Cc: stable@dpdk.org > > Signed-off-by: Olivier Matz This patch lgtm. The key point here is that in the "container context" (well, cgroups) mmap succeeds regardless of availability of hugepages. I would put an emphasis about this in the title. What do you think of: mem: fix dynamic hugepage mapping in container -- David Marchand