From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0731A0C45; Tue, 26 Oct 2021 16:46:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8216640E0F; Tue, 26 Oct 2021 16:46:39 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 793ED407FF for ; Tue, 26 Oct 2021 16:46:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635259598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=46OOFxsxIwAFGCdFTTiFBi33oRIORDXvthQqUDWEKIQ=; b=J/5h1MGDAovhgtFkLCfJAougIS1LYtbXOm6Wk+B3iltNDLOYpE+8S0Ga4zPju1qiZ7XERe cvEqL9FgCnhx7/fZPB+c57GNs8VhKXm3WMWFvMP+FRfvz7N7uHRzzs6wgISl2ZviEkpxhS u/VAnMUu05oME6I3Vqw2IEODG1thfqU= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-mVGsI76rO5uye0oygxWhDA-1; Tue, 26 Oct 2021 10:46:35 -0400 X-MC-Unique: mVGsI76rO5uye0oygxWhDA-1 Received: by mail-lf1-f69.google.com with SMTP id g6-20020a0565123b8600b003ffa7685526so2570431lfv.21 for ; Tue, 26 Oct 2021 07:46:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=46OOFxsxIwAFGCdFTTiFBi33oRIORDXvthQqUDWEKIQ=; b=X26ErNMZSWH58yVteN2TCfiH2W+105FzPukNsHXuChNUeQWBS/8hd3lP6WLO88U/Uh u1nQqQwGRMEYkmxWRwpEcSldlwpI5UgIXlVBkIVQ9qotC8P4Xl4l61vcEjt7Xhrku3BT YwcmNJTWuX83mj18zRYnxHaqXVJqYOOJuIlXDbaQBKQ5iScI80UA7860JD6T9V7XC5zy znzjwYLkYGNQFTYzKvfQxZa1G9iqm7zThwsJr+aAHMEX7U07Ia4yoFxbzDYlnC3FNjBp kn+rrl6l5ZLBfeEk0bT+ga9/k8pJVuP/s0OkHoSRI09r6GdH5AdePbB/08D/H1GDsSeH DgaQ== X-Gm-Message-State: AOAM531Jx1gop8x7LM4XKOv7i9Jhf1yzkCpoO9e9S2boWa5UknDRi4YS DN1I7u6yXfG3o9UgmPecnKKqyb65iv+9EIH9QDyHt9vAZ2+3yDIgmR+a2FTMy1LrCLN8339PkI1 x3z/hfvKKrDus2edyUI8= X-Received: by 2002:a05:6512:31c9:: with SMTP id j9mr3510102lfe.217.1635259592771; Tue, 26 Oct 2021 07:46:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzPF5DFZXQN9VO7Rh+fvpp0T4ScFzP/+VQGvcs9UcDpYfRZ0u5BhSj40zsJJNVQArsw1X/rWrRSNMQMQ2L3Jc= X-Received: by 2002:a05:6512:31c9:: with SMTP id j9mr3510076lfe.217.1635259592480; Tue, 26 Oct 2021 07:46:32 -0700 (PDT) MIME-Version: 1.0 References: <20211005003604.31684-1-ivan.malov@oktetlabs.ru> <20211014032146.23234-1-ivan.malov@oktetlabs.ru> In-Reply-To: <20211014032146.23234-1-ivan.malov@oktetlabs.ru> From: David Marchand Date: Tue, 26 Oct 2021 16:46:21 +0200 Message-ID: To: Ivan Malov Cc: dev , Ferruh Yigit , Andrew Rybchenko , Ori Kam , Xiaoyun Li , Thomas Monjalon , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] ethdev: add API to query proxy port to manage transfer flows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 14, 2021 at 5:22 AM Ivan Malov wrote: > > Not all DPDK ports in a given switching domain may have the > privilege to manage "transfer" flows. Add an API to find a > port with sufficient privileges by any port in the domain. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > Acked-by: Ori Kam > --- > Patch series [1] has reworked support for "transfer" flows. > This allows to elaborate on the idea which first appeared > in RFC [2]. Hence the patch in question. > > net/sfc driver is going to support the new API. The > corresponding patch is already in progress and will > be provided in the course of this release cycle. > > [1] https://patches.dpdk.org/project/dpdk/list/?series=19608 > [2] https://patches.dpdk.org/project/dpdk/list/?series=18737 > [snip] > @@ -568,6 +568,25 @@ eth_rx_metadata_negotiate_mp(uint16_t port_id) > } > } > > +static void > +flow_pick_transfer_proxy_mp(uint16_t port_id) > +{ > + struct rte_port *port = &ports[port_id]; > + int ret; > + > + port->flow_transfer_proxy = port_id; > + > + if (!is_proc_primary()) > + return; > + > + ret = rte_flow_pick_transfer_proxy(port_id, &port->flow_transfer_proxy, > + NULL); > + if (ret != 0) { > + fprintf(stderr, "Error picking flow transfer proxy for port %u: %s - ignore\n", > + port_id, rte_strerror(-ret)); > + } > +} I did not follow this subject, but I find it odd to get a warning regardless of what is done in testpmd. Like simply running a forwarding test with null pmd, I get: $ ./devtools/test-null.sh EAL: Detected CPU lcores: 8 EAL: Detected NUMA nodes: 1 EAL: Detected static linkage of DPDK EAL: Multi-process socket /run/user/114840/dpdk/rte/mp_socket EAL: Selected IOVA mode 'VA' Interactive-mode selected Auto-start selected vvvv Error picking flow transfer proxy for port 0: Function not implemented - ignore Error picking flow transfer proxy for port 1: Function not implemented - ignore ^^^^ testpmd: create a new mbuf pool : n=2048, size=2176, socket=0 testpmd: preferred mempool ops selected: ring_mp_mc Configuring Port 0 (socket 0) Port 0: 12:C9:63:52:5A:8B Configuring Port 1 (socket 0) Port 1: 92:69:E3:1E:31:82 Checking link statuses... -- David Marchand