From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 786A8A00BE;
Thu, 17 Feb 2022 13:53:41 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id ECD3C41153;
Thu, 17 Feb 2022 13:53:40 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id F213541150
for <dev@dpdk.org>; Thu, 17 Feb 2022 13:53:39 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1645102419;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=PM0WKlE0hKEIWaY1F/cagLbSMVwGTUNhdKCja1H05Lg=;
b=JYrydVN/QACnkfaHMcTQkRp/5TVB+ALBXXRzmZ2txK7TKABLWFIQ2LIKp3tI7D7oDMhAMp
MaQdkfyAgqBPDZqdZBEnT+LimxjorcDhLIV4HHGQ2Lklmj42QYSMkF8STqT/VcEnTlNjer
P8ohQTkCpIbBLsWj8wYnCF4kEtwSgZE=
Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com
[209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-127-ZhHHRIxqOvSc_2wqzS8EWg-1; Thu, 17 Feb 2022 07:53:36 -0500
X-MC-Unique: ZhHHRIxqOvSc_2wqzS8EWg-1
Received: by mail-lf1-f69.google.com with SMTP id
j11-20020a19f50b000000b00443304eab91so1688167lfb.13
for <dev@dpdk.org>; Thu, 17 Feb 2022 04:53:36 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=PM0WKlE0hKEIWaY1F/cagLbSMVwGTUNhdKCja1H05Lg=;
b=lWi9HPef8G7MLJyYewGN0d3l1564cgqNfNO9WvAf6CysFKs77Cd92H+gjL/dJ9kZDE
N2Hg1iSCG2RjFXiODYstJynneZoHtFYSaJc62pGNgWjAa7EC/sB4zznk1xfvixEweUDM
AqOazhWUEdT9UyUERZy4e0+1JxvfxxtgpBkvd1KbrBlG9NObytdYhQ374yINiV7+0jK0
Yu8niUU0YVS9dbPiw4My4tuVVOIpQZOLsU0K883BxUFyxNqdMRSuWcq+2GyOOCw8Pmhn
rvIvFW3ZiF6vdQiZ6uXP6NXz0YSo57y2BYS4+EPCJQpye2zlKZr+u3Y3F4iYFF5ncDUb
Dd5A==
X-Gm-Message-State: AOAM530SLZZBr9cbUrT9mGNWy0z7MqV4qYrFoJJrDfGKYfirxPubW8MK
zyDP897jATl2E1qqcJwh8NB+A+X3nM68MURbQK7ibb9BKCPdfkhmzR83BW7NmqFpE77oq3Trb5r
6TBtLpDc5Qp6iQi/NflY=
X-Received: by 2002:a2e:87c2:0:b0:245:a4ff:a319 with SMTP id
v2-20020a2e87c2000000b00245a4ffa319mr2069285ljj.297.1645102414836;
Thu, 17 Feb 2022 04:53:34 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxosJcejfJ9Q1+3i2VxQAM/vhDFNSsP73h+KEMHNkc9T296kfxgqDXW4OXBp9KUhUKG0QL7XVyw0ruz6IeZNrE=
X-Received: by 2002:a2e:87c2:0:b0:245:a4ff:a319 with SMTP id
v2-20020a2e87c2000000b00245a4ffa319mr2069276ljj.297.1645102414637; Thu, 17
Feb 2022 04:53:34 -0800 (PST)
MIME-Version: 1.0
References: <20220208134800.52142-1-ciara.loftus@intel.com>
<20220209094808.41464-1-ciara.loftus@intel.com>
<CAJFAV8xrJf_2DkTxt9b5wAGBdQk_T=S8h5_+6jDbXepW1XqFfw@mail.gmail.com>
<f1a10a54-8c94-53f9-1ef2-81baa5aa2968@intel.com>
In-Reply-To: <f1a10a54-8c94-53f9-1ef2-81baa5aa2968@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 17 Feb 2022 13:53:23 +0100
Message-ID: <CAJFAV8yhq5y_aEBBXHB0ZF7OYKmCsYNOuPrBOuqUTLT_-bVLLw@mail.gmail.com>
Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Ciara Loftus <ciara.loftus@intel.com>, dev <dev@dpdk.org>,
Stephen Hemminger <stephen@networkplumber.org>, "Burakov,
Anatoly" <anatoly.burakov@intel.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Thu, Feb 17, 2022 at 1:48 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 2/17/2022 12:44 PM, David Marchand wrote:
> > On Wed, Feb 9, 2022 at 10:48 AM Ciara Loftus <ciara.loftus@intel.com> wrote:
> >> @@ -1836,6 +2008,17 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)
> >> return -1;
> >> }
> >>
> >> + /* Register IPC callback which shares xsk fds from primary to secondary */
> >> + if (!afxdp_dev_count) {
> >> + ret = rte_mp_action_register(ETH_AF_XDP_MP_KEY, afxdp_mp_send_fds);
> >> + if (ret < 0) {
> >
> > This breaks --in-memory mode.
> > It should be instead ret < 0 && rte_errno != ENOTSUP
> >
> > Can you double check?
> > Thanks.
> >
>
> There is already a patch for it [1], if it is reviewed/tested,
> I can merge quickly.
I had tested my suggestion.
The patch [1] does the same and lgtm, I'll let Ciara ack it.
>
> [1]
> https://patches.dpdk.org/project/dpdk/patch/2c422567d3640972@cs.arizona.edu/
--
David Marchand