From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 244C2A046B
	for <public@inbox.dpdk.org>; Thu, 25 Jul 2019 14:06:12 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 786C01C316;
	Thu, 25 Jul 2019 14:06:11 +0200 (CEST)
Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com
 [209.85.217.65]) by dpdk.org (Postfix) with ESMTP id 5E3CA1C0AD
 for <dev@dpdk.org>; Thu, 25 Jul 2019 14:06:10 +0200 (CEST)
Received: by mail-vs1-f65.google.com with SMTP id v129so33520644vsb.11
 for <dev@dpdk.org>; Thu, 25 Jul 2019 05:06:10 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=29dtEVPk/Nh8gRD43nj9SvH2+uRDLv3YomV8B96Vfbg=;
 b=eSlGP5PjJqAtCR45nCDZ2vgsMw0DYMEMcXvGchDZ5eV7sLBcy2Hu8She7ynho/PL27
 smWJtiEIIXNfOri74+TsKwRJvuIPkgOLtnJFoslgVxNtMZWu77cFdexvTJ/l3TxEG8QP
 H33W6VdM01hrPB+7B6QMCDVbA57vtLTYTXm7le6DEq1PivBtxcv1oQy+TW7f9LuGhDw8
 YOhUyFHuB3Y6Cixw5PQg8f6crjbbxSBRL6Z0NXlMnb7n/MT0gHdpS1RiQIhutqYYrC7q
 sZE6FDCwqaTzbo9nccLHmoFhn5qDu7Y8QFGNB/s4UBur1XNq0tKhSoFK+kiv20nAkrWd
 IOOA==
X-Gm-Message-State: APjAAAXhTmwwYbMX2raUe8IWE5ihrmCxZ21/6bzoMAFX2WQSYhbNj8he
 Q8u11icA6rvDgRaYheRJGscKFhRjE5Wr2q0ed7UK78N+
X-Google-Smtp-Source: APXvYqwS7bXbL0xYnyrgJyrNobaEcXhzYQXwnTHZ+36rCYGsOrmYCTb0n58QfnynNd6TgE1q8qvEN+FnWUxWeL68BPk=
X-Received: by 2002:a67:e9ca:: with SMTP id q10mr24082055vso.105.1564056369250; 
 Thu, 25 Jul 2019 05:06:09 -0700 (PDT)
MIME-Version: 1.0
References: <1563969270-29669-1-git-send-email-david.marchand@redhat.com>
 <1564056260-18125-1-git-send-email-david.marchand@redhat.com>
 <1564056260-18125-4-git-send-email-david.marchand@redhat.com>
In-Reply-To: <1564056260-18125-4-git-send-email-david.marchand@redhat.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 25 Jul 2019 14:05:58 +0200
Message-ID: <CAJFAV8yiSCZa0OJKaSzUT6bjjyyR0rMcAAK1MGPoJWpwKeyQUg@mail.gmail.com>
To: dev <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 3/3] net/pcap: fix
 concurrent multiseg packet transmits
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jul 25, 2019 at 2:05 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> Two cores can send multi segment packets on two different pcap ports.
> Because of this, we can't have one single buffer to linearize packets.
>
> Use rte_pktmbuf_read() to copy the packet into a buffer on the stack
> and remove eth_pcap_gather_data() when necessary (if the mbuf is
> contiguous, rte_pktmbuf_read() just points at the buffer address).
>
> With this change, we won't support mono segment mbuf larger than 16k.

Argh, should have removed this wrong comment...


-- 
David Marchand