From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 594BC1B5C1 for ; Thu, 10 Jan 2019 11:11:27 +0100 (CET) Received: by mail-vs1-f66.google.com with SMTP id v205so6661221vsc.3 for ; Thu, 10 Jan 2019 02:11:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nc8yb9cVRNBVNp8Eq9RGFPUJ0onBqGkiaMG7OyPc924=; b=SGX5405IxwvXIjHbDBjsc1qiJgRCKDpkZpPSUSzGJSlVQo2Gp69NVi+X7kxoo3KZv5 PjX1V8ln209XDe3mtBKoWlzjtaRIfjEBdazyMbPJMNeuwRc2iB1WNJoXVUnCaPrDocV1 2iSGJFQX6fd9+9zRvOZhlqo/Te8vGQ2HtLE+B+F/1fxZg7rexjmUQRec4S1CCuxsXuiH QpUY6ZuCGk2odXnzZLR/h1EVSf7/13u48elnH4yBogodx0Y5PM7eArgF17JYgZ+1k9VE FQOoeVgLrhvatJdeMs/UO56Zucdcw+jnoHxspB1zs1PuvR4FCmU39vfIbiCmr8fR41Ij tQew== X-Gm-Message-State: AJcUukdvdwSJ+JDm9ohoch7aUCqmRATM5YyN5He3zJKypOypFd2r+R/9 ykEnqGX+mm0vjxh6e/huaoYrBFY6Rw6LZB+Tf/0O+A== X-Google-Smtp-Source: ALg8bN7wUpx10w6wrYXU/s/hsCMrrDyprH6MzKkjWQmFPBPR8gs3OwnTCecES42p+TJRDSHYgsTSQBMXDNNEPB6TQ4o= X-Received: by 2002:a67:c48a:: with SMTP id d10mr4088680vsk.105.1547115086637; Thu, 10 Jan 2019 02:11:26 -0800 (PST) MIME-Version: 1.0 References: <1546518487-9942-1-git-send-email-hari.kumarx.vemula@intel.com> <1546856745-25186-1-git-send-email-hari.kumarx.vemula@intel.com> In-Reply-To: <1546856745-25186-1-git-send-email-hari.kumarx.vemula@intel.com> From: David Marchand Date: Thu, 10 Jan 2019 11:11:14 +0100 Message-ID: To: Hari Kumar Vemula Cc: dev@dpdk.org, reshma.pattan@intel.com, "Yigit, Ferruh" , jananeex.m.parthasarathy@intel.com, dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] eal: fix core number validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 10:11:27 -0000 Hello Hari, On Mon, Jan 7, 2019 at 11:26 AM Hari Kumar Vemula < hari.kumarx.vemula@intel.com> wrote: > When incorrect core value or range provided, > as part of -l command line option, a crash occurs. > > Added valid range checks to fix the crash. > > Added ut check for negative core values. > Added unit test case for invalid core number range. > > Fixes: d888cb8b9613 ("eal: add core list input format") > Cc: stable@dpdk.org > > -- > v3: Added unit test cases for invalid core number range > v2: Replace strtoul with strtol > Modified log message > -- > > Signed-off-by: Hari Kumar Vemula > --- > lib/librte_eal/common/eal_common_options.c | 9 +++++++-- > test/test/test_eal_flags.c | 14 +++++++++++++- > 2 files changed, 20 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_options.c > b/lib/librte_eal/common/eal_common_options.c > index 6e3a83b98..9431c024e 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -592,7 +592,9 @@ eal_parse_corelist(const char *corelist) > if (*corelist == '\0') > return -1; > errno = 0; > - idx = strtoul(corelist, &end, 10); > + idx = strtol(corelist, &end, 10); > + if (idx < 0 || idx >= (int)cfg->lcore_count) > + return -1; > if (errno || end == NULL) > return -1; > while (isblank(*end)) > Please fix indentation. > @@ -1103,6 +1105,7 @@ eal_parse_common_option(int opt, const char *optarg, > { > static int b_used; > static int w_used; > + struct rte_config *cfg = rte_eal_get_configuration(); > > switch (opt) { > /* blacklist */ > @@ -1145,7 +1148,9 @@ eal_parse_common_option(int opt, const char *optarg, > /* corelist */ > case 'l': > if (eal_parse_corelist(optarg) < 0) { > - RTE_LOG(ERR, EAL, "invalid core list\n"); > + RTE_LOG(ERR, EAL, > + "Invalid core number, core range should be > (0, %u)\n", > + cfg->lcore_count-1); > return -1; > } > > eal_parse_corelist can error for both invalid core number but also for incorrectly formatted input. How about "invalid core list, please check core numbers are in [0, %u] range" ? diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c > index 2acab9d69..28e68a6c9 100644 > --- a/test/test/test_eal_flags.c > +++ b/test/test/test_eal_flags.c > @@ -513,6 +513,16 @@ test_missing_c_flag(void) > const char *argv25[] = { prgname, prefix, mp_flag, > "-n", "3", "--lcores", > "0-1,2@(5-7),(3-5)@(0,2),(0,6),7"}; > + /* core number is negative value */ > + const char * const argv26[] = { prgname, prefix, mp_flag, > + "-n", "3", "--lcores", "-5" }; > + const char * const argv27[] = { prgname, prefix, mp_flag, > + "-n", "3", "--lcores", "-5-7" }; > + /* core number is maximum value */ > + const char * const argv28[] = { prgname, prefix, mp_flag, > + "-n", "3", "--lcores", "999999999" }; > + const char * const argv29[] = { prgname, prefix, mp_flag, > + "-n", "3", "--lcores", "1-9999999" }; > Well, the maximum value is not really "999999999". Please check against RTE_MAX_LCORE. -- David Marchand