From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E4C341B8D; Tue, 31 Jan 2023 11:14:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F144C40EF0; Tue, 31 Jan 2023 11:14:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 532534067B for ; Tue, 31 Jan 2023 11:14:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675160068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bddh1OVjD4lHX1Jke9eWwEhXBR73TC94Mb/i3z7GhPo=; b=LGjI1WS7i6+Uo2EnPqPjaApeaVtKVr0NBeYnA7mgpoiTeFZAd0hI8jgU2bdoRrTuLp0t5B d9VMeGxBR1pE4t8nWaL2z2CjpBERheeLa9ElbeTyQ4mdtuVYgaUF34NrxLqBcIZ+FoVKbk 24CvxQVLoh1ZahBwoN0KWxJ5J6wF6A8= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-531-h2Ez_fxeNxSIy1u3q2WWEw-1; Tue, 31 Jan 2023 05:14:27 -0500 X-MC-Unique: h2Ez_fxeNxSIy1u3q2WWEw-1 Received: by mail-pl1-f200.google.com with SMTP id u15-20020a170902a60f00b00194d7d89168so8093812plq.10 for ; Tue, 31 Jan 2023 02:14:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bddh1OVjD4lHX1Jke9eWwEhXBR73TC94Mb/i3z7GhPo=; b=bB2tq7noGNa53oExAfqSdMq0QehZe0VDlwEULGPzCg7MA27AOYnfhnnAl873HVv8/J w2SS4HYVsEmp5gJTRG7IRA9gZVijaMcdTp3hzWmDHHYCcqgwN1FpgTQMpt4qzZuvf7uT KbDsIVwfYoplGxrTGsA8l591GIeQcdwgQgobOTINkN3SvIG6QpVLC4cqmRtOLUG4Hosy 53/gO/IvGzl1gynyXThsicYp3eqASrUJbTrUV9IfAgf+3QVJXzWkLsdhiU+z2FTZYhrm UTtczE8YTh+wXf1VtCi8mxcnZ+5dxhepC/oWptMydoUS6VGyCzXWZa/vhRoegSDF7at8 +5MA== X-Gm-Message-State: AO0yUKVTWXFAPSG/1mVnBUyfYGaNIRNpovCHRchyF2gSc5MzWFXYOuIE QJT1YldFS+YNBIjD3AOko32GuQ/iiNgjLeHsqMrFIlNq/reSeTUVA6cHk/Xi0VOk1j4UdOaMC9J TnHVNtn76QbBTmZ3FeHo= X-Received: by 2002:a17:90a:fd15:b0:22b:fe2b:8053 with SMTP id cv21-20020a17090afd1500b0022bfe2b8053mr4054457pjb.28.1675160065992; Tue, 31 Jan 2023 02:14:25 -0800 (PST) X-Google-Smtp-Source: AK7set+/L9BBdn+cpuhxTgNmQO5Y2lQRfJfycl7QV87h6dtGqRBBEz8TTybml46J95jvmztXIRoQyD7dAWNC4mZv59o= X-Received: by 2002:a17:90a:fd15:b0:22b:fe2b:8053 with SMTP id cv21-20020a17090afd1500b0022bfe2b8053mr4054454pjb.28.1675160065743; Tue, 31 Jan 2023 02:14:25 -0800 (PST) MIME-Version: 1.0 References: <20230103104900.616477-1-david.marchand@redhat.com> In-Reply-To: <20230103104900.616477-1-david.marchand@redhat.com> From: David Marchand Date: Tue, 31 Jan 2023 11:14:14 +0100 Message-ID: Subject: Re: [PATCH] gpudev: fix deadlocks when registering callback To: dev@dpdk.org Cc: stable@dpdk.org, Elena Agostini , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 3, 2023 at 11:49 AM David Marchand wrote: > > gpu_callback_lock was not released in some branches of the register > helper. > While at it, set rte_errno in one branch. > > Fixes: 18cb07563165 ("gpudev: add event notification") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Acked-by: Elena Agostini Applied, thanks. -- David Marchand