From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F15CA0350; Mon, 28 Feb 2022 11:17:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ECE424068C; Mon, 28 Feb 2022 11:17:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0850940140 for ; Mon, 28 Feb 2022 11:17:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646043445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F+0xQg5y57CevEi/75koKKHwv84TIT8iH9SSNQJMiYQ=; b=XKJ+28L+BNKI+I4mlw6A/1DaWPMLxDf8CMD2p3yxuLYscbSZIwSVZrjsDTN08GFhojYG+d YSRwGXJDklh7MwjO1/D8HUkvT1VSb+grlfakFBvVaU37qeblMxA7uSXDOVzYZsNabgIi37 n3IU77Tk8N1BHGcwcmt9k3VewoYK9Jc= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-8EtfbEVnOzyMQIwmjEvxHQ-1; Mon, 28 Feb 2022 05:17:20 -0500 X-MC-Unique: 8EtfbEVnOzyMQIwmjEvxHQ-1 Received: by mail-lj1-f197.google.com with SMTP id 185-20020a2e05c2000000b002463aff775aso5507926ljf.17 for ; Mon, 28 Feb 2022 02:17:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F+0xQg5y57CevEi/75koKKHwv84TIT8iH9SSNQJMiYQ=; b=hi88rMwk0OpPbIoTGRhtkvSF66g4/+DkxFsAw+6bC5wq/goZS0yPRqcZAmKlkjzfCB 065wP5h3oOszigntGkZP2RYzGc0BwvRQyE7sSkrqhWy/uTchyo+Yb3QNRlisKNbg/xpI /AM81ECOfpRUFvVqdgiQAGLt2kiJd/TVye5Lve7jfm4e2IG/cNocV4fsgI0Rh2ifS0V3 xQTgtbKQb2zWRck7GUXSbjwdtwpMGUM5l5oOnOZUjHN9AYe0YT2AgDmBb0GMWC1VUNv7 NPZk9K16TtZUhN3qUiNNzMyqPltyif1DgjNaXNEEdWAMB+EKL76ZJC0khmPXScG/45Dg tBmA== X-Gm-Message-State: AOAM530FWPX//okYvmal8zhMz7FUYuEj+yVWY/NkVEJ8psjd6O4yNAHA wbOLjCJVnV519JXfAlAmlrRg1RgG3gve+RJx/fiNbs3WvHeMM3s1AHd5ya93ucEpzvuA4Jkz75d mXsawC72uLhEoj4YyeN0= X-Received: by 2002:a2e:a171:0:b0:244:c2fc:d1d with SMTP id u17-20020a2ea171000000b00244c2fc0d1dmr13413258ljl.159.1646043438738; Mon, 28 Feb 2022 02:17:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJwl2F7tbCEls6ujMmgdhm7VS+5utANs/1yjifDbot3PydsPHRYVAwkMhe29RmIsivNlAs1XQHIUOP3FBcrF+bA= X-Received: by 2002:a2e:a171:0:b0:244:c2fc:d1d with SMTP id u17-20020a2ea171000000b00244c2fc0d1dmr13413247ljl.159.1646043438467; Mon, 28 Feb 2022 02:17:18 -0800 (PST) MIME-Version: 1.0 References: <20220226183651.2165304-1-thomas@monjalon.net> In-Reply-To: From: David Marchand Date: Mon, 28 Feb 2022 11:17:07 +0100 Message-ID: Subject: Re: [PATCH] ci: remove redundant drivers enabling To: Bruce Richardson Cc: Thomas Monjalon , dev , Aaron Conole , Michael Santana Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 1 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 28, 2022 at 10:46 AM Bruce Richardson wrote: > > On Sat, Feb 26, 2022 at 07:36:51PM +0100, Thomas Monjalon wrote: > > No need to explicitly enable drivers bus/vdev and mempool/ring. > > > > bus/vdev is always enabled since > > commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds") > > > > mempool/ring is always enabled since > > commit 81c2337e044d ("build: make ring mempool driver mandatory") > > > > Signed-off-by: Thomas Monjalon > > One comment inline below. > > Acked-by: Bruce Richardson > > --- > > .ci/linux-build.sh | 2 +- > > devtools/test-meson-builds.sh | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > > index 67d68535e0..77c0d1976b 100755 > > --- a/.ci/linux-build.sh > > +++ b/.ci/linux-build.sh > > @@ -89,7 +89,7 @@ OPTS="$OPTS --default-library=$DEF_LIB" > > OPTS="$OPTS --buildtype=debugoptimized" > > OPTS="$OPTS -Dcheck_includes=true" > > if [ "$MINI" = "true" ]; then > > - OPTS="$OPTS -Denable_drivers=bus/vdev,mempool/ring,net/null" > > + OPTS="$OPTS -Denable_drivers=net/null" > > OPTS="$OPTS -Ddisable_libs=*" > > fi > > meson build --werror $OPTS > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > > index c07fd16fdc..a653b253cb 100755 > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > @@ -221,7 +221,7 @@ for c in gcc clang ; do > > done > > > > build build-mini cc skipABI $use_shared -Ddisable_libs=* \ > > - -Denable_drivers=bus/vdev,mempool/ring,net/null > > + -Denable_drivers=net/null > > Do we even need this enabled for a mini-build. Would disable_drivers=*/* > not work better to truly have a minimal build? In GHA, for native builds, test-null.sh is called, and it uses net/null ports. https://git.dpdk.org/dpdk/tree/.ci/linux-build.sh#n101 -- David Marchand