From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DA9F43C31; Thu, 29 Feb 2024 09:06:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 549FC402B4; Thu, 29 Feb 2024 09:06:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CEAC7402AC for ; Thu, 29 Feb 2024 09:06:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709193991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GbsPph073n0W6Dk6zfYUvW1heJhBc9/HTR/4hjYTNkg=; b=JTfxOLg8awjm5MyU1j1XojjebuR46rnP1lAcyczsvM8OGmObDI2fpKprYWENqbmgDvafaC Q49FN5FQO6bJme3kzpmhtW4/PlZ3BMRj9r3aN9thsW3zs6YHsbsHEmv0uFekG/N6yze/+M pQZTj/Zn5Kv5sdJQW3y1reVAcn9/Rg8= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-hNo9PWVhPfG-8M5oJx8VBw-1; Thu, 29 Feb 2024 03:06:30 -0500 X-MC-Unique: hNo9PWVhPfG-8M5oJx8VBw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5131ed4a32cso349854e87.2 for ; Thu, 29 Feb 2024 00:06:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709193988; x=1709798788; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GbsPph073n0W6Dk6zfYUvW1heJhBc9/HTR/4hjYTNkg=; b=HSqTRu35cB1KVoa9TQXsXuEjzgmzByP/3GA7KnTrAkzqa7EuJ8LtsAcmG6+q/D/isG OGQIUKLQGmu/D6g7NXw91vTcXTwekknyAn1JThRHZpikkeHXKIlmy3cGJNYK6BOCppr6 riAYvOp7caqyt6FkrDNaD4Gi2rl7l58fjBWKKTep4pZ1moepiD7CFp606Si5ERtgKY9i qmYe19vEFWrf3my58Bzbjf2BRNTVcvDvIvTl81SkO1N41TWXI1+bxoGRPir7nzIpApzu LGETi/iJfiAF1gz7eYyV/69HRMqGCvTaO0IJUiW4sfLx5JFkGLgEfDzjN/L3xK75BM00 pYsg== X-Gm-Message-State: AOJu0YzbQU88wpGkZNV5zHLQHD7D/+89jyTIfbWAc0RPWKuWT+zOnf7f EEWwRZjN/DyHVPBGXSolwjfvKpMf1IJbQhUMbFLSJUGSRhozhE1Ffxt99Idnvedmc0y+7G1WH0B +LTM3+S8K4tQTbxEuQdD5A1tcT2za1FeQyPuxQYRh5DHR1dA6V41Urih565MprBHV1vT3Dzn1cM X8mh0anY6OIBADDNM= X-Received: by 2002:ac2:4e07:0:b0:513:28bc:cd0f with SMTP id e7-20020ac24e07000000b0051328bccd0fmr452229lfr.27.1709193988617; Thu, 29 Feb 2024 00:06:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHsDwtnhqlWDXd2sVxH/JnR04+2G+dFAGKZnDCgMiLp0W/FPnWshsXpAk5+zlL45UwyU7f+eZfZKM6PLgLrRqg= X-Received: by 2002:ac2:4e07:0:b0:513:28bc:cd0f with SMTP id e7-20020ac24e07000000b0051328bccd0fmr452204lfr.27.1709193988299; Thu, 29 Feb 2024 00:06:28 -0800 (PST) MIME-Version: 1.0 References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> <1708978786-6740-1-git-send-email-roretzla@linux.microsoft.com> <20240228175928.GA12255@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20240228175928.GA12255@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Thu, 29 Feb 2024 09:06:15 +0100 Message-ID: Subject: Re: [PATCH v3 00/16] stop using variadic argument pack extension To: Tyler Retzlaff Cc: dev@dpdk.org, Anatoly Burakov , Ashish Gupta , Chenbo Xia , Cristian Dumitrescu , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Konstantin Ananyev , Maxime Coquelin , Reshma Pattan , Sachin Saxena , Sivaprasad Tummala , Srikanth Yalavarthi , Stephen Hemminger , Sunil Kumar Kori , bruce.richardson@intel.com, mb@smartsharesystems.com, thomas@monjalon.net X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 28, 2024 at 6:59=E2=80=AFPM Tyler Retzlaff wrote: > > I find this new helper less tricky to use and easier to read than the > > RTE_FMT_* stuff that gets copy/pasted everywhere. > > The changes are quite mechanical, so even though we are past -rc1, +1 > > for me on the series. > > > > Can we finish the job and convert remaining macros that prefix messages= in lib/? > > I didn't realize I missed any. do you have a list or a regex that points > me at them. I was just searching for use of args... > > Happy to make the conversion of the others in the next rev. Basically, this new macro/approach makes direct use of RTE_FMT_HEAD unneede= d. So I grepped like this: $ git grep RTE_FMT_HEAD -- lib/ :^lib/log/ :^lib/eal/include/rte_common.h b55361f252:lib/cryptodev/rte_cryptodev.h: RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__ ,), \ b55361f252:lib/cryptodev/rte_cryptodev.h: RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__ ,), \ b55361f252:lib/cryptodev/rte_cryptodev.h: RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__ ,), \ b55361f252:lib/eal/windows/include/rte_windows.h: RTE_FMT_HEAD(__VA_ARGS__ ,), GetLastError(), \ b55361f252:lib/eventdev/eventdev_pmd.h: RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__ ,), \ b55361f252:lib/eventdev/eventdev_pmd.h: RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__ ,), \ b55361f252:lib/eventdev/rte_event_timer_adapter.c: RTE_FMT("EVTIMER: %s() line %u: " RTE_FMT_HEAD(__VA_ARGS__ ,), \ b55361f252:lib/graph/graph_private.h: RTE_FMT("%s():%u " RTE_FMT_HEAD(__VA_ARGS__ ,), \ b55361f252:lib/member/member.h: RTE_FMT("%s(): " RTE_FMT_HEAD(__VA_ARGS__ ,), \ b55361f252:lib/node/node_private.h: RTE_FMT("%s: %s():%u " RTE_FMT_HEAD(__VA_ARGS__ ,), \ --=20 David Marchand