From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 697E5A009E for ; Sun, 27 Oct 2019 11:37:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08AEF1BEB1; Sun, 27 Oct 2019 11:37:01 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 44E561BEAE for ; Sun, 27 Oct 2019 11:36:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572172618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kItNpsf1S8CGs//gp1+mkuf+FcTfo+gDXeDxzsRBJ/I=; b=MSckqtoOnREYT6GdNIuYygRh9Kb815OC5I8zuq7OZedYq0yjR+HEfyDUvL767Th0avWs0v cNofzaXlcrE4li7q35y92kmRbTaB6CIwRUGpIGqF80zQ+WsKbawM2iDCkTMkNNcQb2N0OT 4I6/oGZWgRrqkyu8A7ia1TksKAQQnRI= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-168-SEFGuNMDM2ySfMFH2j8WqA-1; Sun, 27 Oct 2019 06:36:57 -0400 Received: by mail-vk1-f199.google.com with SMTP id a188so2922298vkc.7 for ; Sun, 27 Oct 2019 03:36:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jebGgqvqiTC/6vgQGGSluwndJ6a7huf8ZQscFeHFkeU=; b=r01xqJhf8Rpi8RQcZIYCsF61irgjsv7QSyvMUx2cjjHjeL4H5rkrRILuGIHKXr5zcE KI5HlQlzV/uFJ8YkP9j69S8Se6jumLpkRyBmG+9MspuDHgH6+hSuUkBoR5rzhFrn2M6N yAlIMlwSnHG9K80lbl+nHhyXCI+o+3dGEzHzD3Kh2Y9nzFilXIFHG8hdmvkc9PNCgYxI cRAWHv6t8VdByYiqdvVJYQd29MWXk3u20Yq6RLYq5K+R9V8u4N/W45IXau4F7h9K11XN 37bt31XCj/Vul6SJtBeOurJYini57q0GNLI0/YuIR12unbQpeRxaEE3MBfylG6n8pK21 s22g== X-Gm-Message-State: APjAAAVg45qH3H7quzrE+nla9gPv4lc7smW2E15NiNJFLGyCmC6Ausqi Awe6xTu7KcHuVO8f/rx0d1GoHaN0mTWirN/clrzdZIEPkf40aLk2OYaVQx5F1A923pXzLkZa56L mxCFOjHj9GIvIIyR3j9c= X-Received: by 2002:a67:fa99:: with SMTP id f25mr6363376vsq.141.1572172616950; Sun, 27 Oct 2019 03:36:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqx8inqGYRuPKs3Wcw3YY8P52l4JpB0ukXY5uT5J87tUfxLUeoqY+Hql9N0D70PpQWrjcCJa9Xa4d4KJd+pCW2U= X-Received: by 2002:a67:fa99:: with SMTP id f25mr6363366vsq.141.1572172616696; Sun, 27 Oct 2019 03:36:56 -0700 (PDT) MIME-Version: 1.0 References: <20190926151159.19256-1-ciara.power@intel.com> <20190926144420.GA1833@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190926144420.GA1833@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Sun, 27 Oct 2019 11:36:45 +0100 Message-ID: To: Bruce Richardson Cc: Ciara Power , dev , romanx.korynkevych@intel.com, Vipin Varghese , dpdk stable X-MC-Unique: SEFGuNMDM2ySfMFH2j8WqA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/proc-info: fix string copying to use strlcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 26, 2019 at 4:44 PM Bruce Richardson wrote: > > On Thu, Sep 26, 2019 at 04:11:59PM +0100, Ciara Power wrote: > > Replaced strncpy and strcpy with strlcpy. > > Also replaced snprintf with strlcpy where applicable. > > Using strlcpy is safe practice when copying strings, > > as it will include a null terminator. > > > > > > Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") > > Fixes: 8a37f37fc243 ("app/procinfo: add --show-port") > > Cc: stable@dpdk.org > > Reported-by: Reshma Pattan > > Signed-off-by: Ciara Power > > --- > Acked-by: Bruce Richardson Applied, thanks. --=20 David Marchand