From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55700A050B; Thu, 7 Apr 2022 14:45:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5B934068B; Thu, 7 Apr 2022 14:45:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E592C40689 for ; Thu, 7 Apr 2022 14:45:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649335522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q9DPICfAFDvZ/sT3lix3/SO3+fVWeHMTsM7V5H/TjNw=; b=EqQwvzJXqtQw9qhN2vIjwOJUnacRG12aiLP3Q4kALZFnGQHZbVqgni0uB7jE9LVqFzK+jv wJUtNbVa4szsswg6A4mnRqyvw5p4AZ8GPW0GgL2m9hsoLE/utox8lnpyrKY6goYKl4BX// 3vdRBPHXtoq53627EMm9++NhgO3HmsI= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-284-HYrzYE1aPIuQPkN7_y9eUA-1; Thu, 07 Apr 2022 08:45:20 -0400 X-MC-Unique: HYrzYE1aPIuQPkN7_y9eUA-1 Received: by mail-lf1-f72.google.com with SMTP id d12-20020a05651233cc00b0044ad60fe93dso1796250lfg.11 for ; Thu, 07 Apr 2022 05:45:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=q9DPICfAFDvZ/sT3lix3/SO3+fVWeHMTsM7V5H/TjNw=; b=YFdmH2l9BQRviiYID0CUAk4t8HPOJF5uaIEsyWCA55Nnp976D4KmI4bHbFMWzW2vd5 QhtrTHF2NqC1C9PrmJXixSd4ukndeNWTu7RMbfHrwM70CwnPbRxYt4VQPTT3ZhdybPs8 UJT3DSWiP0Tb+azeBWHGznIJwNPifCPiBC4op0mO6mY8oJpHZ9GiWJz29wlUZSe0WzJf +EgYKzFlO5DVPUqnoxQxTkiH6jfKe8qYxD4kvZglpxTbNIdv4Yvg7FPR96AFGIAPnSIM hvMepwTI8uBqLE/cp5fE+IVOCCro57kFFgQ2Vqbdn3TdQFBfVlwI6FgtNg7S0OUAtlDC iAEA== X-Gm-Message-State: AOAM530CTim8qKpSDnQo+JdysXg7UTbcuEv0Vn7XJoxrkTvlL7WJA12c tFXNITklPIMlnBxb2iGw/AzKpNK5AFYix8OBlV9ct3/50A1YnY3pT1OTjB3yMXFgLfRtigNn44t D1MBMpTQXx5h2WQTKsbw= X-Received: by 2002:a05:6512:1326:b0:45a:3a4:f25a with SMTP id x38-20020a056512132600b0045a03a4f25amr9079743lfu.575.1649335519371; Thu, 07 Apr 2022 05:45:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnQgVDOs5M5RxPorXTFdG92xRtfl2SgHyKMtbMfYqyFTJD4JwwTfEfwUCfHjCg7/9zGVguxG+jeKh2n6PN/YY= X-Received: by 2002:a05:6512:1326:b0:45a:3a4:f25a with SMTP id x38-20020a056512132600b0045a03a4f25amr9079726lfu.575.1649335519013; Thu, 07 Apr 2022 05:45:19 -0700 (PDT) MIME-Version: 1.0 References: <20220129011039.264377-1-stephen@networkplumber.org> <20220212184433.66791-1-stephen@networkplumber.org> In-Reply-To: <20220212184433.66791-1-stephen@networkplumber.org> From: David Marchand Date: Thu, 7 Apr 2022 14:45:07 +0200 Message-ID: Subject: Re: [PATCH v2 0/2] rte_dump_stack: improvements To: Stephen Hemminger Cc: dev , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Bruce Richardson , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Feb 12, 2022 at 7:44 PM Stephen Hemminger wrote: > > This is update to earlier RFC. Add some more comments and changes > to have common code for Linux and FreeBSD > > Stephen Hemminger (2): > eal_debug: do not use malloc in rte_dump_stack > eal: common rte_dump_stack for both Linux and FreeBSD > > lib/eal/freebsd/eal_debug.c | 43 ------------------------ > lib/eal/freebsd/meson.build | 1 - > lib/eal/linux/eal_debug.c | 43 ------------------------ > lib/eal/linux/meson.build | 1 - > lib/eal/unix/eal_debug.c | 65 +++++++++++++++++++++++++++++++++++++ > lib/eal/unix/meson.build | 5 +-- > 6 files changed, 68 insertions(+), 90 deletions(-) > delete mode 100644 lib/eal/freebsd/eal_debug.c > delete mode 100644 lib/eal/linux/eal_debug.c > create mode 100644 lib/eal/unix/eal_debug.c Strange to change only the Linux implementation as a first patch, then merge implementations in a second time effectively changing FreeBSD implementation in what is presented in commitlog as a factorisation cleanup. Please invert the patches. Besides, the series does not compile on current main. It's probably a result of the header inclusion cleanup we had in v22.03, but I prefer you check. Thanks. -- David Marchand