DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
	 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	 Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	 "Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd
Date: Thu, 19 Nov 2020 16:01:33 +0100	[thread overview]
Message-ID: <CAJFAV8yk6L_sggS1uLb8Gnnt+eQZvMeKJyhOgTOMWE5K6ZWz=g@mail.gmail.com> (raw)
In-Reply-To: <20201119140014.10608-1-talshn@nvidia.com>

On Thu, Nov 19, 2020 at 3:00 PM Tal Shnaiderman <talshn@nvidia.com> wrote:
>
> Linux epoll mechanism is not implemented in Windows.
>
> Add stub similarly to freeBSD.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
>  lib/librte_eal/windows/eal_interrupts.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c
> index 6c64a48f34..6f7a1c7acc 100644
> --- a/lib/librte_eal/windows/eal_interrupts.c
> +++ b/lib/librte_eal/windows/eal_interrupts.c
> @@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), void *arg)
>
>         return 0;
>  }
> +
> +void
> +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle)
> +{
> +       RTE_SET_USED(intr_handle);
> +}

This will not be of much use if you don't export it in
rte_eal_exports.def, right?

-- 
David Marchand


  reply	other threads:[~2020-11-19 15:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 14:00 Tal Shnaiderman
2020-11-19 15:01 ` David Marchand [this message]
2020-11-19 15:08   ` Tal Shnaiderman
2020-11-19 15:18 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman
2020-12-01 16:42   ` Dmitry Kozlyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8yk6L_sggS1uLb8Gnnt+eQZvMeKJyhOgTOMWE5K6ZWz=g@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).