From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 62ABE2B9E for ; Fri, 25 Jan 2019 10:53:35 +0100 (CET) Received: by mail-vs1-f68.google.com with SMTP id e7so5332729vsc.2 for ; Fri, 25 Jan 2019 01:53:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z96cmLyf2JSONP1DF7ElNE28usFIiKL4HMOyOuvOums=; b=jltTkVz56e9vTJ74hH/7iLkkZSJSAo5x7fXvbIxv8g57ba9FRo8AYVvThktYYHFEYh Rf/6qsXptem91tX9Qq1pEPnK1lxsc4OXAWelhgv9U2a8JQq4pa2z6ig+QexXv6nlZj/x loHEAR/vXm5foddqVHuxYtSU+DsIYtHLOMtalDEfnOKUXVxHZJkxmVdFR80IpHjUxsoQ xDPPfzmbBKAnl9sf6JnmWFgfbDM6pB31J2B2PE5Wcj7fCVwSUUvIzJXv880bR0EYAXF8 6zshE0KVCgK3tyeIYYlZtkjmPHrRnkJKDwHuNNMsJBXqBTqYgOx8vNbKhNhisw8yXbX9 Mnow== X-Gm-Message-State: AJcUukeSuUMFxfjqUaZWFmW/BpBkoY8T6d9B6c3+bWmwEIDu0CpG3cNN eMxT6NyPQuHPQn3tLiNP/4+aeW5GLW23QxROo3M3UQ== X-Google-Smtp-Source: ALg8bN5x3vMYsqXZl6qXGk2XGYWYWCHjaRllPXafCUKSzIThFydE0wo30VogLZyFj2ZpxpP2itUvdTILTbijh5EOpyI= X-Received: by 2002:a67:c48a:: with SMTP id d10mr4376899vsk.105.1548410014722; Fri, 25 Jan 2019 01:53:34 -0800 (PST) MIME-Version: 1.0 References: <20190125075558.27139-1-i.maximets@samsung.com> In-Reply-To: From: David Marchand Date: Fri, 25 Jan 2019 10:53:23 +0100 Message-ID: To: Ilya Maximets Cc: dev@dpdk.org, Anatoly Burakov , Thomas Monjalon , ShuaiX Zhu , Xueqin Lin , WenjieX A Li , FengqinX Wang , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] test: test zero socket-mem as valid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 09:53:35 -0000 On Fri, Jan 25, 2019 at 9:06 AM Ilya Maximets wrote: > On 25.01.2019 10:55, Ilya Maximets wrote: > > Dynamic memory mode allowes zero socket-mem because all the > > required memory could be allocated on demand. > > > > Fixes: 339c2244b4f1 ("eal: fix parsing zero socket memory and limits") > > Cc: stable@dpdk.org > > > > Reported-by: Shuai Zhu > > > Signed-off-by: Ilya Maximets > > --- > > test/test/test_eal_flags.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c > > index e3a60c7ae..81e345b87 100644 > > --- a/test/test/test_eal_flags.c > > +++ b/test/test/test_eal_flags.c > > @@ -1158,7 +1158,7 @@ test_memory_flags(void) > > const char *argv1[] = {prgname, "-c", "10", "-n", "2", > > "--file-prefix=" memtest, "-m", DEFAULT_MEM_SIZE}; > > > > - /* invalid (zero) --socket-mem flag */ > > + /* valid (zero) --socket-mem flag */ > > const char *argv2[] = {prgname, "-c", "10", "-n", "2", > > "--file-prefix=" memtest, "--socket-mem=0,0,0,0"}; > > > > @@ -1256,8 +1256,8 @@ test_memory_flags(void) > > printf("Error - process failed with valid -m flag!\n"); > > return -1; > > } > > - if (launch_proc(argv2) == 0) { > > - printf("Error - process run ok with invalid (zero) > --socket-mem!\n"); > > + if (launch_proc(argv2) != 0) { > > + printf("Error - process failed with valid (zero) > --socket-mem!\n"); > > return -1; > > } > > > > > Reviewed-by: David Marchand -- David Marchand