From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ABD2A052B; Wed, 29 Jul 2020 15:48:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EAE624C93; Wed, 29 Jul 2020 15:48:45 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 6E932A69 for ; Wed, 29 Jul 2020 15:48:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596030522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HCfO71ScLB563IoHuuD1i6DEc0t9BL54hSAA9kiH9mc=; b=UDub2bdf/tXKP1VyiM+lxppH/heoU/emnRqewSJ/sLgqHgCPZurZMOnyN4PJNU5hFjXXjS WXQEp5DyAnqPWqCPG/FquWcT0fHyCSWL0vxFqlJcZqoeLos6LM1s4S+MKl0Xfs7yt7qzD3 3trv/gveHdLVQRkAzdqCsNfHrItyVV8= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-6alw5SJWOPuUWVmSzZhjLw-1; Wed, 29 Jul 2020 09:48:40 -0400 X-MC-Unique: 6alw5SJWOPuUWVmSzZhjLw-1 Received: by mail-vk1-f199.google.com with SMTP id d132so7569088vke.16 for ; Wed, 29 Jul 2020 06:48:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HCfO71ScLB563IoHuuD1i6DEc0t9BL54hSAA9kiH9mc=; b=TmD+Kx835zq0ZJClG+INrN5XKv6oSJZ8BAOUMrKb1Y0STbiQWM3XwzYNmHa5imKum3 HguKm2wc6jS73/guHqFm/Khup8rp3iyURS58DP29xOLOJlf6gcAbqHFCFrCLgrB8Qb0T 76PtkSztfInCfTMaD53gcwgdxgKJOBDvE1Ctme+ONXubjie+SLRdPVAdjuDYjGL+vW1z pPg7OJUDSBTIpse6nqmOcmmADdqPZLRcr75j4LmFopVcOFH1ZckYbj96PJ4cXWfzfPAO 9EIr3immVkXtGlB9fqmcV5V+8gzRFNL1VdgHXVfz2qPKH5WkOe8xJV9NXsKEr7r/oGQk 4+XA== X-Gm-Message-State: AOAM5305VQHFV16qXlmrJYd368yduS4DqabaVQKaU0gqQSWhCk9WEiK6 pL80/tmQVEWcEk074f2W9Shz2o8X/yEQovUHJ8LCzwf0vIA05tHq335hTe3ZGQmc9y1Gmt9pHkJ hks9T7/DRzpwEtnuCatM= X-Received: by 2002:ac5:ccaf:: with SMTP id p15mr23618414vkm.12.1596030519490; Wed, 29 Jul 2020 06:48:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8PVYMiVt2Qln9EvZf2acttAsjQGYZOIylLOeFhTImQpRs8k7HrtRB4Hd9Ty2L0yPC55NRXKOaJeuC5y5GKfQ= X-Received: by 2002:ac5:ccaf:: with SMTP id p15mr23618396vkm.12.1596030519232; Wed, 29 Jul 2020 06:48:39 -0700 (PDT) MIME-Version: 1.0 References: <20200729063105.11299-1-feifei.wang2@arm.com> <20200729063105.11299-3-feifei.wang2@arm.com> In-Reply-To: <20200729063105.11299-3-feifei.wang2@arm.com> From: David Marchand Date: Wed, 29 Jul 2020 15:48:28 +0200 Message-ID: To: Feifei Wang Cc: Honnappa Nagarahalli , Konstantin Ananyev , Gavin Hu , Olivier Matz , dev , nd , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Feifei, On Wed, Jul 29, 2020 at 8:32 AM Feifei Wang wrote: > > When enqueue one element (object of type void*) to ring in the > performance test, a pointer (the object to be enqueued) should be > passed to rte_ring_[sp|mp]enqueue APIs, not the pointer to a table > of void *pointers (objects). Good catch. Are we missing a check in the UT so that dequeued object is what had been enqueued? > > Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests") > Cc: honnappa.nagarahalli@arm.com > Cc: stable@dpdk.org > > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > app/test/test_ring.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test/test_ring.h b/app/test/test_ring.h > index aa6ae67ca..d4b15af7c 100644 > --- a/app/test/test_ring.h > +++ b/app/test/test_ring.h > @@ -50,11 +50,11 @@ test_ring_enqueue(struct rte_ring *r, void **obj, int esize, unsigned int n, > if ((esize) == -1) > switch (api_type) { > case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_SINGLE): > - return rte_ring_enqueue(r, obj); > + return rte_ring_enqueue(r, *obj); > case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_SINGLE): > - return rte_ring_sp_enqueue(r, obj); > + return rte_ring_sp_enqueue(r, *obj); > case (TEST_RING_THREAD_MPMC | TEST_RING_ELEM_SINGLE): > - return rte_ring_mp_enqueue(r, obj); > + return rte_ring_mp_enqueue(r, *obj); > case (TEST_RING_THREAD_DEF | TEST_RING_ELEM_BULK): > return rte_ring_enqueue_bulk(r, obj, n, NULL); > case (TEST_RING_THREAD_SPSC | TEST_RING_ELEM_BULK): > -- > 2.17.1 > -- David Marchand