From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23BC5A051C; Fri, 17 Jan 2020 22:26:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C8782BB9; Fri, 17 Jan 2020 22:26:40 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id B84952B98 for ; Fri, 17 Jan 2020 22:26:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579296398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3u1RHimQxhlu43s9Ez8vkT/sbgvLP86goF0BxI9V6nU=; b=WTi/6IjzqyPvNbhBKjcN/Bk5zCUNWJ7GOWeFdjIiVvotI8tqQECj1+bHpoCXJXQyB3Y2Y5 fQkT68yBgohPoFU9fO5rMU9EbQM1QCj1CuIAT1pHZNj7bbwL9zXGMFq63sNpjox6io/IhJ 3gRLg9vCW2bb2i9KvgPV32VaxEhsyXg= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-169-qmNzr-5PMeWZeaAeTvRE5g-1; Fri, 17 Jan 2020 16:26:36 -0500 Received: by mail-vk1-f199.google.com with SMTP id c1so10350305vko.4 for ; Fri, 17 Jan 2020 13:26:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jmZTmRk52hsWiF5iFtZ7o/RSpNuHdSqiETzeRADx9y0=; b=kfteDmmrlcUdsElXlWbuTbXPr3tWcwkdSB9rj3p4JrTvnPtsq8p8qIsXhDxKW2dCGo Y9YPNrllTjWRUyMPYyy7Fkj7FWzkXpr+V0Iw9I0QWkUtrnUlOE0ZXv+mTM7leXrwA5H0 u8rfFPx7IFALgGJOLsBlDbU/r2OWBJ6zB4DhNC5Hb8nYYbD+iuihNofX2+9oWclH7F90 AUrt7LPkWfUjUQq5ih47nBHWtUUby8kqz0jb4F3CbM5rybWYI1ALN06xgJ6LyEoyb4i0 e7V6nQoy6VflddA7QfcXw8nb/O61wzTjbP+3BBAobudtIjSI20VZmRCHCQitHEHlk98p 0/tg== X-Gm-Message-State: APjAAAUouedVHoVTo+wd20+FIIxV5SC/mZCKoUA8m7oSjGKQhgWjmuwm 5jgakqCtO/0lVaVSbrJ9Nz0vDOANglnyM8yir55abkn7uJfViq9JqMTvT39uynEfb7oFhgUGaRa 8y6J+ZpoTUg27vL68H2k= X-Received: by 2002:ab0:618a:: with SMTP id h10mr22815729uan.53.1579296395924; Fri, 17 Jan 2020 13:26:35 -0800 (PST) X-Google-Smtp-Source: APXvYqyrnfFh9PbUnHPqFpya+nYv+9fqj0GvraVzddiWi+l1/1A6XVTwXDgLzOyuuSA5HuDICygWBkWeapxOxy6ngLI= X-Received: by 2002:ab0:618a:: with SMTP id h10mr22815710uan.53.1579296395631; Fri, 17 Jan 2020 13:26:35 -0800 (PST) MIME-Version: 1.0 References: <20191220152058.10739-1-david.marchand@redhat.com> <3426618.TKLx3GfHUD@xps> <20200116184928.GA8633@hmswarspite.think-freely.org> <2375800.otXNkdZ6W1@xps> <20200117190145.GA8752@hmswarspite.think-freely.org> In-Reply-To: <20200117190145.GA8752@hmswarspite.think-freely.org> From: David Marchand Date: Fri, 17 Jan 2020 22:26:24 +0100 Message-ID: To: Neil Horman , Thomas Monjalon Cc: "Richardson, Bruce" , "dev@dpdk.org" , "Laatz, Kevin" , "aconole@redhat.com" , Michael Santana , "Mcnamara, John" , "Kovacevic, Marko" , "Kinsella, Ray" , Olivier Matz , Honnappa Nagarahalli X-MC-Unique: qmNzr-5PMeWZeaAeTvRE5g-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 17, 2020 at 8:02 PM Neil Horman wrote: > Hmmm....I wonder if its worth orchestrating the build system to use a git > submodule storing whatever our CI system can produce and using it as a ca= che, > and falling back to a local build if the appropriate arch isn't found? T= hat > might offer some incentive to alternate arch maintainers to contribute ha= rdware > or compute time to populating it in pursuit of better build times? Thomas, Neil, I would prefer we consider this in a second step. Just want to give a little update on this patch. Building dpdk with debuginfo seems necessary, if we want to catch internal structures changes. I suppose Bruce patch can be merged already: https://patchwork.dpdk.org/patch/63400/ libabigail in Ubuntu 16.04 (Xenial) is a bit old (version 1.0-rc3) and exhibits a false positive on the linkage name of the default symbol if we do function versioning: we caught this with Olivier when he asked for help on his patch for mempool. This issue disappears with version 1.2 that is in Ubuntu 18.04 (Bionic). After running the check in my environment (fc30 with libabigail 1.5), I caught issues with abidiff when comparing a .so and an abi dump. I reported this upstream, and Dodji fixed this right away. https://sourceware.org/bugzilla/show_bug.cgi?id=3D25409 The fix should be part of version 1.7. This could be ignored if we only do the checks with binaries generated with= gcc. I just got a false positive on an ABI change for the "custom element size" ring series, but on a type that is not user visible (thanks Honnappa). So this needs more work: I hope the --headers-dirX options will help but it means we must store the public headers with the ABI dumps. I can prepare a v2 and have the CI only warns about changes without reporting a failure. --=20 David Marchand