From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFCD5424BD; Mon, 30 Jan 2023 09:58:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A714540EDE; Mon, 30 Jan 2023 09:58:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AF16640C35 for ; Mon, 30 Jan 2023 09:58:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675069123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xzfjsIeO+ne6PCc8bY3xHRA0RZ5NER7h7e3RRQzllbA=; b=S/BXQdjqwC0WNfXTJ2MUm7ROBrBaDBM0UipsDTrvgPFFjeJFUNzYShOz3933iz+WGuB7bl K/OXplcvc08yKbJaY35UYEg3pCwKM6c7PtAg9x0I5/NzQ8BRMmuFc+akJ/0Z0wM60v0lIS afYO/QAA2eNj8qr6BNoKFxzEp0S9eB4= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-369-PzSMAom5P8WQe-iDhz0eaQ-1; Mon, 30 Jan 2023 03:58:41 -0500 X-MC-Unique: PzSMAom5P8WQe-iDhz0eaQ-1 Received: by mail-pj1-f71.google.com with SMTP id n93-20020a17090a2ce600b0022beeabcf6cso7629266pjd.0 for ; Mon, 30 Jan 2023 00:58:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xzfjsIeO+ne6PCc8bY3xHRA0RZ5NER7h7e3RRQzllbA=; b=3eTFby4XEZFFdv0H1saGdUN4sgaDZd/A0Wpei5JflHX9ZONuCl2AMCYhZWxDAXPdOg Nd1T/Ult/E/Xg5qik/LPEL3SuTYlujoi/A2e24z8po1letiIyP2bUqsep9exmYgFCIgM 2MExk1u91my4eWgsGgwFthbxWSPNj1RQdU9iDdhmnz15QRygqHtGYhReIOaX0bFM7ZlZ jlUiKhePLBatKsw6NE5E9IlIdxnGCCtfE+vE74Oo7XYCw8zLhYSRD2pJy/kYJCC78dy+ 8y3gp310dVzH0xWneaQSj4byWqzRab21DWBhEufMqaoOIIYw1A0hgAiq1HsBXAO2FLGk M96w== X-Gm-Message-State: AO0yUKVQWLthiAqaJHrbXPrjwoV2BlKIWm9Dc96xOXoX+wg1AxbpWEYt vPUFtiQmDquXUZVFLvq56+S+UiSGJYgooUOXXlXeyK4qPrxDYTyiN4rXQf50Vkmv1j8mtjBZxYK M+Glb+MRtHbdtc8oNDKA= X-Received: by 2002:aa7:9606:0:b0:593:b0fa:ad95 with SMTP id q6-20020aa79606000000b00593b0faad95mr678332pfg.48.1675069120909; Mon, 30 Jan 2023 00:58:40 -0800 (PST) X-Google-Smtp-Source: AK7set8P8ILkW3FT1L9y+ZiTsKexOQRifNRGFXvAlSLhFqlTrxRfJFJ8w8JvWHIEEpCC9//tXEIfXgytrdhbfSSd9lE= X-Received: by 2002:aa7:9606:0:b0:593:b0fa:ad95 with SMTP id q6-20020aa79606000000b00593b0faad95mr678326pfg.48.1675069120640; Mon, 30 Jan 2023 00:58:40 -0800 (PST) MIME-Version: 1.0 References: <20230109022027.190627-1-ke1x.zhang@intel.com> <20230130080916.77274-1-ke1x.zhang@intel.com> In-Reply-To: <20230130080916.77274-1-ke1x.zhang@intel.com> From: David Marchand Date: Mon, 30 Jan 2023 09:58:29 +0100 Message-ID: Subject: Re: [PATCH v2] net/i40e: support enabling/disabling source pruning To: Ke Zhang , mb@smartsharesystems.com, thomas@monjalon.net, ferruh.yigit@amd.com Cc: dev@dpdk.org, olivier.matz@6wind.com, Yuying.Zhang@intel.com, beilei.xing@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jan 30, 2023 at 9:23 AM Ke Zhang wrote: > > VRRP advertisement packets are dropped on i40e PF devices because > when a MAC address is added to a device, packets originating from > that MAC address are dropped. > > This patch adds a PMD specific API to enable/disable source > pruning to fix above issue. > > Bugzilla ID: 648 > > Signed-off-by: Ke Zhang > --- > app/test-pmd/cmdline.c | 84 +++++++++++++++++++++++++++++++++ > drivers/net/i40e/i40e_ethdev.c | 43 +++++++++++++++++ > drivers/net/i40e/i40e_ethdev.h | 1 + > drivers/net/i40e/rte_pmd_i40e.c | 20 ++++++++ > drivers/net/i40e/rte_pmd_i40e.h | 16 +++++++ > 5 files changed, 164 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index cb8c174020..76a574affd 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -776,6 +776,9 @@ static void cmd_help_long_parsed(void *parsed_result, > > "port cleanup (port_id) txq (queue_id) (free_cnt)\n" > " Cleanup txq mbufs for a specific Tx queue\n\n" > + > + "port config (port_id|all) src_prune (on|off)\n" > + " Set source prune on port_id, or all.\n\n" > ); > } > - This seems i40e specific, please move to drivers/net/i40e/i40e_testpmd.c. - Besides, I would prefer that something in the command name clearly states this is driver (here, i40e) specific. Like "port config XX i40e_src_prune" or maybe the other way around, start with a "driver i40e" prefix. Maybe others have an opinion. -- David Marchand