From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 339FFA0C48; Thu, 8 Jul 2021 22:16:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA2764014F; Thu, 8 Jul 2021 22:16:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id E39AC4014E for ; Thu, 8 Jul 2021 22:15:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625775358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q7qmuMvCdtQAsYMKBxUpkJfrN6wLUQ2c4pslZx3Hqp4=; b=fz/aahRmekGnDlkTbFkN38B0Z2sfFyUekRwCx8Ck7w1GsBOqOwavsak1t+Oht+QvA1S5ov pignMoU+Ps+YLRg21IC3qMJTneQQzQUbKPS5qrTB69pTT6yoFnHadWP6z0L1y+VILokv2t mXQ6cePw4OkOhGLN36uPmsE4qfJtQhs= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-asG8eD8_Nya-RMSwDZ0QoA-1; Thu, 08 Jul 2021 16:15:55 -0400 X-MC-Unique: asG8eD8_Nya-RMSwDZ0QoA-1 Received: by mail-vs1-f72.google.com with SMTP id g3-20020a67fac30000b0290279c2771f64so2085189vsq.8 for ; Thu, 08 Jul 2021 13:15:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q7qmuMvCdtQAsYMKBxUpkJfrN6wLUQ2c4pslZx3Hqp4=; b=i5BSkyhBFea/Oz+93iBlycmbuZtKJz9+EUDv8JFbQZJnd/69HRX4CPUBJ2i9yE7vWQ 5gj9R602pVLZHsMwNSOm9K1tH+txmgDuqATlFrJSfrFMWfsZNsVa3eewIF42Nv0DB4x9 ndcj8ji/qr0Zr3oSvYDATcUF9MHPETQIKBSCVBVMWUP9DB4SNAw8oqWJXxb3EVsNwGPh U7baFocRQB9Yxvbu+BSzgd7pfy6OHh70e05/aTiS5HnBLf8OZfHLEN/cNBy3VYrK6+3R KykFeR1Z1ywu2qCrJnPH3RV2bu9y9ASZV82L6ue4kn1GyTnfreb90JSuYtajPYanZdqT 3ISg== X-Gm-Message-State: AOAM532enNYWVulmFuxsZY/2OGM3/MHOwG/9hlhNDsMlQav29vOPtmKa BXGJQfh8zWKEUD5/hxiWdp+BBh9nz9vx93HwNBqM8itetFWICxMquQb/sxFbyid34fqX75A6Tkc pmiAYGAZkIRQPUvnQes4= X-Received: by 2002:a67:f3d1:: with SMTP id j17mr23641719vsn.18.1625775355208; Thu, 08 Jul 2021 13:15:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxf2Wdo390ZjLz1WKHhaiPTSreF+KLyeTRaWrt/mDdPKZUD6/Zh2+ZhJCbUB/+lJiFGh9jC0wLjdOmFKvsClzQ= X-Received: by 2002:a67:f3d1:: with SMTP id j17mr23641691vsn.18.1625775354972; Thu, 08 Jul 2021 13:15:54 -0700 (PDT) MIME-Version: 1.0 References: <1624600591-29841-1-git-send-email-anoobj@marvell.com> <1624600591-29841-2-git-send-email-anoobj@marvell.com> In-Reply-To: From: David Marchand Date: Thu, 8 Jul 2021 22:15:43 +0200 Message-ID: To: Anoob Joseph , Ankur Dwivedi , Jerin Jacob Cc: Akhil Goyal , NBU-Contact-Thomas Monjalon , Tejasree Kondoj , "dev@dpdk.org" , Archana Muniganti , Ali Alnubani Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 01/20] crypto/cnxk: add driver skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 8, 2021 at 7:08 PM Ali Alnubani wrote: > > -----Original Message----- > > From: dev On Behalf Of Anoob Joseph > > Sent: Friday, June 25, 2021 8:56 AM > > To: Akhil Goyal ; NBU-Contact-Thomas Monjalon > > > > Cc: Ankur Dwivedi ; Jerin Jacob > > ; Tejasree Kondoj ; > > dev@dpdk.org; Anoob Joseph ; Archana Muniganti > > > > Subject: [dpdk-dev] [PATCH v2 01/20] crypto/cnxk: add driver skeleton > > > > This patch is causing the following exception with debug mode in main (02edbfab1e): > """ > meson --werror --buildtype=debug build && ninja -C build > ... > ValueError: Buffer size too small (4 instead of at least 12 bytes) > ... > """ - Reproduced the issue in Ubuntu 18.04 GHA vms: FAILED: drivers/rte_crypto_cnxk.pmd.c /usr/bin/python3 ../buildtools/gen-pmdinfo-cfile.py /home/runner/work/dpdk/dpdk/build/buildtools ar /home/runner/work/dpdk/dpdk/build/drivers/libtmp_rte_crypto_cnxk.a drivers/rte_crypto_cnxk.pmd.c /usr/bin/python3 ../buildtools/pmdinfogen.py elf Traceback (most recent call last): File "../buildtools/pmdinfogen.py", line 274, in main() File "../buildtools/pmdinfogen.py", line 269, in main drivers = load_drivers(image) File "../buildtools/pmdinfogen.py", line 203, in load_drivers drivers.append(Driver.load(image, symbol)) File "../buildtools/pmdinfogen.py", line 157, in load driver.pci_ids = cls._load_pci_ids(image, pci_table_name_symbol) File "../buildtools/pmdinfogen.py", line 177, in _load_pci_ids pci_id = rte_pci_id.from_buffer_copy(data) ValueError: Buffer size too small (4 instead of at least 12 bytes) Traceback (most recent call last): File "../buildtools/gen-pmdinfo-cfile.py", line 20, in subprocess.run(pmdinfogen + paths + [output], check=True) File "/usr/lib/python3.6/subprocess.py", line 438, in run output=stdout, stderr=stderr) subprocess.CalledProcessError: Command '['/usr/bin/python3', '../buildtools/pmdinfogen.py', 'elf', '/home/runner/work/dpdk/dpdk/build/buildtools/tmp1ajyjflf/crypto_cnxk_cn9k_cryptodev.c.o', '/home/runner/work/dpdk/dpdk/build/buildtools/tmp1ajyjflf/crypto_cnxk_cn9k_cryptodev_ops.c.o', '/home/runner/work/dpdk/dpdk/build/buildtools/tmp1ajyjflf/crypto_cnxk_cn10k_cryptodev.c.o', '/home/runner/work/dpdk/dpdk/build/buildtools/tmp1ajyjflf/crypto_cnxk_cn10k_cryptodev_ops.c.o', '/home/runner/work/dpdk/dpdk/build/buildtools/tmp1ajyjflf/crypto_cnxk_cn10k_ipsec.c.o', '/home/runner/work/dpdk/dpdk/build/buildtools/tmp1ajyjflf/crypto_cnxk_cnxk_cryptodev.c.o', '/home/runner/work/dpdk/dpdk/build/buildtools/tmp1ajyjflf/crypto_cnxk_cnxk_cryptodev_capabilities.c.o', '/home/runner/work/dpdk/dpdk/build/buildtools/tmp1ajyjflf/crypto_cnxk_cnxk_cryptodev_ops.c.o', '/home/runner/work/dpdk/dpdk/build/buildtools/tmp1ajyjflf/crypto_cnxk_cnxk_cryptodev_sec.c.o', 'drivers/rte_crypto_cnxk.pmd.c']' returned non-zero exit status 1. I don't get the relation with the debug mode, but there must be something different with the pci table symbols for this driver. My bet is on drivers/crypto/cnxk/cn9k_cryptodev.c: static struct rte_pci_id pci_id_cpt_table[] = { { }, /* sentinel */ { .device_id = 0 }, }; Adding some pci id, like the cn9k vf cpt pci id, will likely fix the issue. And as a bonus, this will make this driver actually do something. - There is also another issue with clang + debug. This seems rather old, nobody complained. Fixed with: Author: David Marchand Date: Thu Jul 8 22:10:11 2021 +0200 net/octeontx/base: fix debug build with clang Remove conflicting declaration of this symbol. Fixes: d0d654986018 ("net/octeontx: support event Rx adapter") Cc: stable@dpdk.org Signed-off-by: David Marchand diff --git a/drivers/net/octeontx/base/octeontx_pkivf.h b/drivers/net/octeontx/base/octeontx_pkivf.h index d41eaa57ed..8c86841ea6 100644 --- a/drivers/net/octeontx/base/octeontx_pkivf.h +++ b/drivers/net/octeontx/base/octeontx_pkivf.h @@ -362,7 +362,6 @@ int octeontx_pki_port_open(int port); int octeontx_pki_port_hash_config(int port, pki_hash_cfg_t *hash_cfg); int octeontx_pki_port_pktbuf_config(int port, pki_pktbuf_cfg_t *buf_cfg); int octeontx_pki_port_create_qos(int port, pki_qos_cfg_t *qos_cfg); -int octeontx_pki_port_close(int port); int octeontx_pki_port_errchk_config(int port, pki_errchk_cfg_t *cfg); int octeontx_pki_port_vlan_fltr_config(int port, pki_port_vlan_filter_config_t *fltr_cfg); -- David Marchand