From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F7B3A050D; Wed, 30 Mar 2022 16:03:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CD1640685; Wed, 30 Mar 2022 16:03:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E6E334013F for ; Wed, 30 Mar 2022 16:03:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648649033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EIIWTPAPM8iYrVi8McBQgW1ln7bxKOavhyBdxMiDahw=; b=jH0Z9HSwsPd1vLZMiJ4CkDZifQdTv+X/tU0q6TGupvu30eBJUwjHRWhlMX6k/kwJRWHmo0 NjQhH+nN0Q93hIW8Xblu/SCqWq7JvBnNkWvWGFKn8VT527+taTPaR173suG/VESPBCqyME LgXPgV5uX7zpK+SRNFy75QyIVtzx8+I= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-575-vbqQ_2WWMf-ZJtzRao2hOQ-1; Wed, 30 Mar 2022 10:03:50 -0400 X-MC-Unique: vbqQ_2WWMf-ZJtzRao2hOQ-1 Received: by mail-lj1-f197.google.com with SMTP id f12-20020a2e918c000000b002496651f1d6so8795676ljg.0 for ; Wed, 30 Mar 2022 07:03:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EIIWTPAPM8iYrVi8McBQgW1ln7bxKOavhyBdxMiDahw=; b=FR1ZjVGDHQ5dy/paFUaQMQZdQkpHjTpbad+6uD7UH+Nu0dsTOQVUKn+m3yeJSsJCJb j9KU0GXvzTutiKhyM3oJT8MrYbZPYFMOAm8fPdYFXrtnqsmWZh12j14xAeTtJgSwqiyi OGddRXAK+ek3hii5WIshm1VhEW2+NVZ4OGc5EmyWX1u2+IDWiQZLd//upmHNu/8lyc1m RkD4Iw5x3dxmqV7gb1l6feTyl0PML7eh/yZBH9cLFqeIBzoDCpMmoeQic/D0crdumfeT w+luwuwhzrM0AzZLXfOKMql6Y0LuAk0BzfVcsrDYzplIS4nmsfZzX/s0nebMAbpoka7l pVQQ== X-Gm-Message-State: AOAM532uFXWelk+bJnRuGZCbv1ODohf7GF38pQlGhUp4EjmwM5w58BMt 5EDXGX7J6oavConujay79A36mc7sqQCGgpxNrolikwq6C0KAvj+/xVoullbJZ6UPeCc29Tc/1MM 5T2GYLylRVFaFhHB7XFk= X-Received: by 2002:a05:6512:398a:b0:44a:56b9:c03e with SMTP id j10-20020a056512398a00b0044a56b9c03emr7079555lfu.553.1648649028530; Wed, 30 Mar 2022 07:03:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwobH+9xUBW0R8GNHRaZIn2mYWyA2K+56/ADakbBr3vxNwqMA1rzMbHsMn/vawoUkbpMD83vNHK1EYSKRsR4hs= X-Received: by 2002:a05:6512:398a:b0:44a:56b9:c03e with SMTP id j10-20020a056512398a00b0044a56b9c03emr7079540lfu.553.1648649028334; Wed, 30 Mar 2022 07:03:48 -0700 (PDT) MIME-Version: 1.0 References: <20220328121758.26632-1-david.marchand@redhat.com> <20220330134956.18927-1-david.marchand@redhat.com> In-Reply-To: <20220330134956.18927-1-david.marchand@redhat.com> From: David Marchand Date: Wed, 30 Mar 2022 16:03:37 +0200 Message-ID: Subject: Re: [RFC PATCH v2 0/9] vhost lock annotations To: dev , Ali Alnubani Cc: Maxime Coquelin , "Xia, Chenbo" , Jiayu Hu , "Wang, YuanX" , Xuan Ding Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 30, 2022 at 3:50 PM David Marchand wrote: > > vhost internals involves multiple locks to protect data access by > multiple threads. > > This series is a try at using clang thread safety checks [1] to catch > issues during compilation: EAL spinlock and rwlock are annotated and > vhost code is instrumented so that clang can statically check > correctness. > > This is still a work in progress (some documentation and a release note > update are missing). > > Those annotations are quite heavy to maintain because the full path of > code must be annotated, but I think it is worth using. > > > 1: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html It looks like mimecast shot the first patch (which I sent in place of Maxime, because this series should go through the main repo). Looking at the mail source, I see: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition;Similar Internal Domain=false;Similar Monitored External Domain=false;Custom External Domain=false;Mimecast External Domain=false;Newly Observed Domain=false;Internal User Name=false;Custom Display Name List=false;Reply-to Address Mismatch=false;Targeted Threat Dictionary=false;Mimecast Threat Dictionary=false;Custom Threat Dictionary=false I don't know how to understand this... But as a result, the series is missing this patch in patchwork. Patch 1 is still available from RFC v1: https://patchwork.dpdk.org/project/dpdk/patch/20220328121758.26632-2-david.marchand@redhat.com/ or via next-virtio. -- David Marchand