From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89C7B43B28; Fri, 16 Feb 2024 09:02:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D569D42EAC; Fri, 16 Feb 2024 09:02:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 77BE440266 for ; Fri, 16 Feb 2024 09:02:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708070565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gxrQu/a4YMVGeJAds/Sh12ENUmYzjdk7p1//aEbW6f8=; b=GS45TqNcM8ononQH5XndzS6swCEQn3D/vuUxMDhGmeo9bdELWsQ9/GAvnkW25s2IuQ2XkN mx9ls/x/l9g8rViKXWCXM03PXT0l2JKCl/bbk7pSdL6LaOjkyQi2CNAQxNisOoKSTpQcC0 tA47OScY4IDlGhxfaSID/XbPpCkVZ3w= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-2ovbI_5qPZ288F2-E6Q1ag-1; Fri, 16 Feb 2024 03:02:43 -0500 X-MC-Unique: 2ovbI_5qPZ288F2-E6Q1ag-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d0a329e86cso15406301fa.3 for ; Fri, 16 Feb 2024 00:02:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708070562; x=1708675362; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gxrQu/a4YMVGeJAds/Sh12ENUmYzjdk7p1//aEbW6f8=; b=QPcFPuA4duQx0S5juAQZCCw/0iMzRpuPRfgFdYX7bYLsd2b29hfcR23kYlRMK3QK/9 OBx/Zq2NuI/icr4g8Pd36WH0Z/jCnZBOZfkK0aFs64nc+8yOnosMBIKgBFQnDYWV18By ULd8vdBZlGhBhjD1blAULXikislV1niQTtFxvx+i7Kg7OqZcBw4voC/d9ESV20Gmyi+r rUVfZCFp9cnVrKEg/8+cF5C2cV2+CYsIpe9J/b6PUHExVS43DtPNIVddNX3W7DdK8U2l M/DhPKCbGlXBWQxw1d0OAYbIvjytHmQ6l147vFLy0lmQIFgMNtvgXLH//aBEn/ND9gQP lahQ== X-Forwarded-Encrypted: i=1; AJvYcCXOQwfqzDh15HCAB946Q1IfRRPJN8Gc3P+Sayp/AVOyuHDtMWpt580k1jHVXZh6XUpZPet93lIshUKtFKc= X-Gm-Message-State: AOJu0YzmrNjVby1gNcXqMdTTL/KEB4Zf8+wBObBgH4XCvq/y6dZPAmO0 YLT89EuFkDNvbxO9jpZAe7CH+2Zo4cgoFQy/kryCN8zY+orebedEI6PoTy4+v9JUnOGJcakcF3I 3hKoCYKsZXD/B46AwZgG4t5qXhtSAtgtTUgArwug8ImaCgFRBiTfQf0zL8AU74JO6NbjvYicrA9 fxbn9u78lC4rA7PIw= X-Received: by 2002:a2e:8ecb:0:b0:2d0:a8c8:ea42 with SMTP id e11-20020a2e8ecb000000b002d0a8c8ea42mr3155829ljl.13.1708070562020; Fri, 16 Feb 2024 00:02:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IEJ0QQB2kXq3OzVKcdCLA6V2upNeR+q/tIKNrIlbp62XxhTKaG3hp8LHmmRxJkjNLPl7C1KpAzRmiPOdi8vOOQ= X-Received: by 2002:a2e:8ecb:0:b0:2d0:a8c8:ea42 with SMTP id e11-20020a2e8ecb000000b002d0a8c8ea42mr3155785ljl.13.1708070561259; Fri, 16 Feb 2024 00:02:41 -0800 (PST) MIME-Version: 1.0 References: <20231111172153.57461-1-stephen@networkplumber.org> <20231113170605.408281-1-stephen@networkplumber.org> <20231113170605.408281-4-stephen@networkplumber.org> <20240216003345.GA24519@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20240216003345.GA24519@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: David Marchand Date: Fri, 16 Feb 2024 09:02:29 +0100 Message-ID: Subject: Re: [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert To: Tyler Retzlaff Cc: Stephen Hemminger , dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 16, 2024 at 1:33=E2=80=AFAM Tyler Retzlaff wrote: > > ping > > i'd like to see this change go in asap since it is pre-requisite to > turning on -Wvla which explicitly caught use of non-constant expressions > in the RTE_BUILD_BUG_ON() hiding bugs. That was the last thing I applied yesterday. It ran through compile checks during the night. I am reviewing a few details this morning before pushing. --=20 David Marchand