From: David Marchand <david.marchand@redhat.com>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: dev <dev@dpdk.org>, Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [dpdk-dev] [PATCH] ci: enable ppc64le cross compilation in GHA
Date: Mon, 8 Nov 2021 13:06:35 +0100 [thread overview]
Message-ID: <CAJFAV8ymOzzX6RooQo9RRUONeoeuPWavNvTRPjXozG1UgO1ybg@mail.gmail.com> (raw)
In-Reply-To: <20211105204020.1098032-1-drc@linux.vnet.ibm.com>
On Fri, Nov 5, 2021 at 9:40 PM David Christensen <drc@linux.vnet.ibm.com> wrote:
>
> Enable Github Actions to cross-compile code for POWER systems.
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
> .ci/linux-build.sh | 6 +++++-
> .github/workflows/build.yml | 15 ++++++++++++++-
> config/ppc/ppc64le-power8-linux-gcc-GHA | 11 +++++++++++
> 3 files changed, 30 insertions(+), 2 deletions(-)
> create mode 100644 config/ppc/ppc64le-power8-linux-gcc-GHA
>
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> index e1f5255327..52766b3811 100755
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> @@ -64,6 +64,10 @@ if [ "$AARCH64" = "true" ]; then
> fi
> fi
>
> +if [ "$PPC64LE" = "true" ]; then
> + OPTS="$OPTS --cross-file config/ppc/ppc64le-power8-linux-gcc-GHA"
> +fi
> +
> if [ "$BUILD_DOCS" = "true" ]; then
> OPTS="$OPTS -Denable_docs=true"
> fi
> @@ -86,7 +90,7 @@ OPTS="$OPTS -Dcheck_includes=true"
> meson build --werror $OPTS
> ninja -C build
>
> -if [ "$AARCH64" != "true" ]; then
> +if [ "$AARCH64" != "true" ] && [ "$PPC64LE" != "true" ]; then
> failed=
> configure_coredump
> devtools/test-null.sh || failed="true"
> diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
> index 9cc96121b6..4151cafee7 100644
> --- a/.github/workflows/build.yml
> +++ b/.github/workflows/build.yml
> @@ -21,6 +21,7 @@ jobs:
> CC: ccache ${{ matrix.config.compiler }}
> DEF_LIB: ${{ matrix.config.library }}
> LIBABIGAIL_VERSION: libabigail-1.8
> + PPC64LE: ${{ matrix.config.cross == 'ppc64le' }}
> REF_GIT_TAG: none
> RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }}
>
> @@ -56,6 +57,14 @@ jobs:
> compiler: gcc
> library: shared
> cross: aarch64
> + - os: ubuntu-18.04
> + compiler: gcc
> + library: static
> + cross: ppc64le
> + - os: ubuntu-18.04
> + compiler: gcc
> + library: shared
> + cross: ppc64le
>
> steps:
> - name: Checkout sources
> @@ -107,8 +116,12 @@ jobs:
> if: env.AARCH64 == 'true'
> run: sudo apt install -y gcc-aarch64-linux-gnu libc6-dev-arm64-cross
> pkg-config-aarch64-linux-gnu
> + - name: Install ppc64le cross compiling packages
> + if: env.PPC64LE == 'true'
> + run: sudo apt install -y gcc-powerpc64le-linux-gnu libc6-dev-ppc64el-cross
> + pkg-config-powerpc-linux-gnu
> - name: Install test tools packages
> - if: env.AARCH64 != 'true' || env.RUN_TESTS == 'true'
> + if: env.AARCH64 != 'true' || env.PPC64LE != 'true' || env.RUN_TESTS == 'true'
> run: sudo apt install -y gdb
> - name: Install doc generation packages
> if: env.BUILD_DOCS == 'true'
> diff --git a/config/ppc/ppc64le-power8-linux-gcc-GHA b/config/ppc/ppc64le-power8-linux-gcc-GHA
> new file mode 100644
> index 0000000000..803c612cbc
> --- /dev/null
> +++ b/config/ppc/ppc64le-power8-linux-gcc-GHA
> @@ -0,0 +1,11 @@
> +[binaries]
> +c = 'powerpc64le-linux-gnu-gcc'
> +cpp = 'powerpc64le-linux-gnu-cpp'
> +ar = 'powerpc64le-linux-gnu-ar'
> +strip = 'powerpc64le-linux-gnu-strip'
> +
> +[host_machine]
> +system = 'linux'
> +cpu_family = 'ppc64'
> +cpu = 'power8'
> +endian = 'little'
> --
> 2.27.0
>
There is nothing specific to GHA in this cross compilation config file.
I would call it config/ppc/ppc64le-power8-linux-gcc-ubuntu1804 (in the
same way we have one a config for arm).
The rest lgtm.
--
David Marchand
next prev parent reply other threads:[~2021-11-08 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 20:40 David Christensen
2021-11-08 12:06 ` David Marchand [this message]
2021-11-08 17:53 ` [dpdk-dev] [PATCH v2] " David Christensen
2021-11-10 11:00 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8ymOzzX6RooQo9RRUONeoeuPWavNvTRPjXozG1UgO1ybg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=maicolgabriel@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).