From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AE30A0C4D; Mon, 8 Nov 2021 13:06:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1160640E03; Mon, 8 Nov 2021 13:06:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 00A2440151 for ; Mon, 8 Nov 2021 13:06:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636373209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l+ti0VIv3LX9HnwpqKZaDROUS6YAsFgVnz1gGpIZ5TY=; b=FNNmR18w0rZOUvaLcuwhmRCLQZ3rEnf1qPGKH1xEMwvOvWVn2OGNLPqCW76J+RVLR3MEQ1 xAcOIRjmGs+OcQ3izvzDuobdFtJPkaUSR9POk3WJzSjFSz/WDtaB5Yr0lcnSDycypGoZAi a7m5gohv/F83TArOee5d5ujXqZfW5VU= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-hxN6dUCEMaegC8JWB6uZgA-1; Mon, 08 Nov 2021 07:06:48 -0500 X-MC-Unique: hxN6dUCEMaegC8JWB6uZgA-1 Received: by mail-lf1-f69.google.com with SMTP id i34-20020a0565123e2200b0040019ae61d5so6295170lfv.20 for ; Mon, 08 Nov 2021 04:06:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l+ti0VIv3LX9HnwpqKZaDROUS6YAsFgVnz1gGpIZ5TY=; b=v0ssXVMRWkH7MudBZiMstsNLPjWf0zDLyWJBVXKiCARBeAjkuvO/9dQHyuegJdcCAy FeMIo4qvoC0ZLD3iT21Geymd+08OXTL990BdkRiHpoTt/WZ5q5kLbqv9/XSRAx75vKYz h8D6zsmwXQirH/ieSPn46UnEkzE7eJY4GEoCdu2jwe54mEzkFZ+QzEQfmmIuj0hXtUvU LQAJ70WeeFsltGoVKywXW4T3FcV3MeYPQrdqTL1rppu/cVDWyGbcL1xwKVrrmjCk+VkP kLpR5b5JanrERdpKpYt333j94tcs6OC1f0tpt7hY8y5aNoWYrl8OCeyadDtyBiAvGhNR Pj1Q== X-Gm-Message-State: AOAM533TpGuvL600N4GAOXsggYzmxTWIEGfZiVrppe2tc/RueNbOiKPE TV3+eDmJrBa7FcbxcorixLjPp+W+6rSCFDb1bsd4HvpMCwm/5WXQmjJFJRE1NsmiyLXrqsws5Gg wN+jq3QeG0c+XivHEEVk= X-Received: by 2002:a05:6512:3f28:: with SMTP id y40mr73038009lfa.499.1636373206901; Mon, 08 Nov 2021 04:06:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJyp/2pMMSREbpb05Pl37XbGOUbKAUl1qwNxURHmqpYiro4ZjYKRznaxrJwadLyvjhHHHXL0hiB8jsRH02xaEvk= X-Received: by 2002:a05:6512:3f28:: with SMTP id y40mr73037981lfa.499.1636373206656; Mon, 08 Nov 2021 04:06:46 -0800 (PST) MIME-Version: 1.0 References: <20211105204020.1098032-1-drc@linux.vnet.ibm.com> In-Reply-To: <20211105204020.1098032-1-drc@linux.vnet.ibm.com> From: David Marchand Date: Mon, 8 Nov 2021 13:06:35 +0100 Message-ID: To: David Christensen Cc: dev , Aaron Conole , Michael Santana Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ci: enable ppc64le cross compilation in GHA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 5, 2021 at 9:40 PM David Christensen wrote: > > Enable Github Actions to cross-compile code for POWER systems. > > Signed-off-by: David Christensen > --- > .ci/linux-build.sh | 6 +++++- > .github/workflows/build.yml | 15 ++++++++++++++- > config/ppc/ppc64le-power8-linux-gcc-GHA | 11 +++++++++++ > 3 files changed, 30 insertions(+), 2 deletions(-) > create mode 100644 config/ppc/ppc64le-power8-linux-gcc-GHA > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > index e1f5255327..52766b3811 100755 > --- a/.ci/linux-build.sh > +++ b/.ci/linux-build.sh > @@ -64,6 +64,10 @@ if [ "$AARCH64" = "true" ]; then > fi > fi > > +if [ "$PPC64LE" = "true" ]; then > + OPTS="$OPTS --cross-file config/ppc/ppc64le-power8-linux-gcc-GHA" > +fi > + > if [ "$BUILD_DOCS" = "true" ]; then > OPTS="$OPTS -Denable_docs=true" > fi > @@ -86,7 +90,7 @@ OPTS="$OPTS -Dcheck_includes=true" > meson build --werror $OPTS > ninja -C build > > -if [ "$AARCH64" != "true" ]; then > +if [ "$AARCH64" != "true" ] && [ "$PPC64LE" != "true" ]; then > failed= > configure_coredump > devtools/test-null.sh || failed="true" > diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml > index 9cc96121b6..4151cafee7 100644 > --- a/.github/workflows/build.yml > +++ b/.github/workflows/build.yml > @@ -21,6 +21,7 @@ jobs: > CC: ccache ${{ matrix.config.compiler }} > DEF_LIB: ${{ matrix.config.library }} > LIBABIGAIL_VERSION: libabigail-1.8 > + PPC64LE: ${{ matrix.config.cross == 'ppc64le' }} > REF_GIT_TAG: none > RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }} > > @@ -56,6 +57,14 @@ jobs: > compiler: gcc > library: shared > cross: aarch64 > + - os: ubuntu-18.04 > + compiler: gcc > + library: static > + cross: ppc64le > + - os: ubuntu-18.04 > + compiler: gcc > + library: shared > + cross: ppc64le > > steps: > - name: Checkout sources > @@ -107,8 +116,12 @@ jobs: > if: env.AARCH64 == 'true' > run: sudo apt install -y gcc-aarch64-linux-gnu libc6-dev-arm64-cross > pkg-config-aarch64-linux-gnu > + - name: Install ppc64le cross compiling packages > + if: env.PPC64LE == 'true' > + run: sudo apt install -y gcc-powerpc64le-linux-gnu libc6-dev-ppc64el-cross > + pkg-config-powerpc-linux-gnu > - name: Install test tools packages > - if: env.AARCH64 != 'true' || env.RUN_TESTS == 'true' > + if: env.AARCH64 != 'true' || env.PPC64LE != 'true' || env.RUN_TESTS == 'true' > run: sudo apt install -y gdb > - name: Install doc generation packages > if: env.BUILD_DOCS == 'true' > diff --git a/config/ppc/ppc64le-power8-linux-gcc-GHA b/config/ppc/ppc64le-power8-linux-gcc-GHA > new file mode 100644 > index 0000000000..803c612cbc > --- /dev/null > +++ b/config/ppc/ppc64le-power8-linux-gcc-GHA > @@ -0,0 +1,11 @@ > +[binaries] > +c = 'powerpc64le-linux-gnu-gcc' > +cpp = 'powerpc64le-linux-gnu-cpp' > +ar = 'powerpc64le-linux-gnu-ar' > +strip = 'powerpc64le-linux-gnu-strip' > + > +[host_machine] > +system = 'linux' > +cpu_family = 'ppc64' > +cpu = 'power8' > +endian = 'little' > -- > 2.27.0 > There is nothing specific to GHA in this cross compilation config file. I would call it config/ppc/ppc64le-power8-linux-gcc-ubuntu1804 (in the same way we have one a config for arm). The rest lgtm. -- David Marchand