From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C88C42420; Thu, 19 Jan 2023 21:56:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3BD240223; Thu, 19 Jan 2023 21:56:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 79DDE400D5 for ; Thu, 19 Jan 2023 21:56:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674161765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e771uJ4UiD/Hj9zyHvrfcV4TM3I/vRuLBFxRsXwCqCk=; b=Sf59LfakDRgUM0WzrY7R7OBZlggpCd65sQ8zk/ae3/h6cWl5ZCnxee8AGt2coRVIH+ev57 kMOMiVtMjb1baqubueJNoQOhEY9EMl1qTBe1D2mxdFIzpZaGxp1TcEBg/j/4BMpLGXacPH TTZgiJ6cWJvR+bh8C8n2O64ED7eNkuQ= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-634-w3GSkurkObGHhSgZwdpCow-1; Thu, 19 Jan 2023 15:56:02 -0500 X-MC-Unique: w3GSkurkObGHhSgZwdpCow-1 Received: by mail-pf1-f197.google.com with SMTP id 80-20020a621453000000b0058952aa1c39so1416457pfu.9 for ; Thu, 19 Jan 2023 12:56:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e771uJ4UiD/Hj9zyHvrfcV4TM3I/vRuLBFxRsXwCqCk=; b=cQ7JLzA4FAn5KjWy1tzEZDhNh0r5Llbz1RTRKBGjBDvEHBZKuELAAmWwjTojjIERXa hNzloUSBXVK8KpIUa0db7EzZ2mMQbYUBTJ23Ki7ym9piYLmpPv5eeU6pj72fJEkAh4Fe XmRkXmI/1qKHksD9uHoUblYBfWOf9TeWUobXeUqR4HsFPvJGLX5m0VMEkmRRj9+e9B5+ L2+lqD5N/siDWRYwKBMvOK+wErQ8oHK/yXAl9SKcy0JiWiafkQXOEbKrZPz9CGKkiTFM abSlml7MxUXaxq7NZ/AbFqF1i+oItVi4VXUvpHtnqWp/UxbJwW+gUepow7BIGQWa4Rim spaQ== X-Gm-Message-State: AFqh2krNOukZtZ5ltguzVddI1TOaPw+TjSFSLaCMCQPujgO24WLkkdhW +yMn8STpWClXrEMlC7nashKDSu369T04rdYkw7u8Vp8r5gj41LJmXdbHD1IghtNO0mr7pc4WNv2 LfxGQ/v1mH1w1LbQibF0= X-Received: by 2002:a63:6dce:0:b0:4c7:a1ff:fcc1 with SMTP id i197-20020a636dce000000b004c7a1fffcc1mr1001300pgc.293.1674161761671; Thu, 19 Jan 2023 12:56:01 -0800 (PST) X-Google-Smtp-Source: AMrXdXuuUkvQKcmF04swmqpfNQtva9Fgw8QBy01YUdBwOzi0O7jsbjYIT5v1l8VCwJNYQ6eV8E0P9HwcRSAusAjzIVA= X-Received: by 2002:a63:6dce:0:b0:4c7:a1ff:fcc1 with SMTP id i197-20020a636dce000000b004c7a1fffcc1mr1001292pgc.293.1674161761409; Thu, 19 Jan 2023 12:56:01 -0800 (PST) MIME-Version: 1.0 References: <20220328121758.26632-1-david.marchand@redhat.com> <20230119184620.3195267-1-david.marchand@redhat.com> <20230119184620.3195267-2-david.marchand@redhat.com> <20230119114202.27f7da80@hermes.local> In-Reply-To: <20230119114202.27f7da80@hermes.local> From: David Marchand Date: Thu, 19 Jan 2023 21:55:50 +0100 Message-ID: Subject: Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock To: Stephen Hemminger Cc: dev@dpdk.org, maxime.coquelin@redhat.com, chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com, xuan.ding@intel.com, Anatoly Burakov , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , David Christensen , Bruce Richardson , Konstantin Ananyev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 19, 2023 at 8:42 PM Stephen Hemminger wrote: > > On Thu, 19 Jan 2023 19:46:12 +0100 > David Marchand wrote: > > > +#ifndef __DOXYGEN__ > > + __rte_exclusive_lock_function(&seqlock->lock) > > +#endif > > { > > Would be cleaner any required ifdefs was in rte_lock_annotations > rather than sprinkling the code > IIRC doxygen was getting confused about parens around seqlock->lock for this place only. Other places seem fine, so it seemed more like a doxygen bug and I waived the only location where it was needed. I kind of forgot to investigate again. Here is the trace: $ ninja-build -C build-gcc doc ninja: Entering directory `build-gcc' [1/2] Generating doc/api/doxygen with a custom command FAILED: doc/api/html /usr/bin/python3 ../doc/api/generate_doxygen.py doc/api/html /usr/bin/doxygen doc/api/doxy-api.conf /home/dmarchan/git/pub/dpdk.org/main/lib/eal/include/rte_seqlock.h:218: error: Found ')' without opening '(' for trailing return type ' -> lock)...' (warning treated as error, aborting now) Traceback (most recent call last): File "/home/dmarchan/git/pub/dpdk.org/main/build-gcc/../doc/api/generate_doxygen.py", line 13, in subprocess.run(doxygen_command, check=True, stdout=out) File "/usr/lib64/python3.11/subprocess.py", line 571, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['/usr/bin/doxygen', 'doc/api/doxy-api.conf']' returned non-zero exit status 1. ninja: build stopped: subcommand failed. $ doxygen --version 1.9.5 -- David Marchand