From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24309A09E4; Fri, 29 Jan 2021 18:42:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2CA740683; Fri, 29 Jan 2021 18:42:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 3F6744067D for ; Fri, 29 Jan 2021 18:42:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611942151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mx72AEKItQBDuKVnbnEmXZXGOPB5T0i1NV+GKnFJ+Mg=; b=fdR2bpXRKFdgprE8fS3QAcqjd8paBk26X6He23EtjGypK9yC1xsc5UaZAkOouYPcIn2iL4 kzUdXSphLqT3ZfoVpQcupIMGC4djQPr2bTHStZ/Taa+k7lYIUjUgNCtNbgsB+tSN2KaXpq iFwVPwzu1kTQtSK2FgR8X3VkvQt+BR0= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-GID7iMKbMAiFWSw-vEoh_A-1; Fri, 29 Jan 2021 12:42:29 -0500 X-MC-Unique: GID7iMKbMAiFWSw-vEoh_A-1 Received: by mail-vk1-f200.google.com with SMTP id d202so2646775vkd.4 for ; Fri, 29 Jan 2021 09:42:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mx72AEKItQBDuKVnbnEmXZXGOPB5T0i1NV+GKnFJ+Mg=; b=NLO+cAyq0r5BCO7+Ty4q+4mLYKZe4a3/rE0o75OxReCz1ttBGH4SZVglz4QpE3QjiE QOIhPUFQWdkcUF8oH4s74SUApBHmyF+8Qm9MUYYrdpg2gOTjT+ZYepS5Ox+RnTphF7GA ql1PzMnJC/q6UPA07ZlKlbKTPa83RQhHz3w0vwmiugbA71vW+f6PLetyV12H8XHX8Lk4 FTPmGH4/J5B/O0i9ynC0jFgp/4O/WfRA1e1RCswWe27hQL1fbBjxI+kWmY/rtneCjx+1 MrgNjfhmJphTpbugEz6a5f53uBdJTZ0jejMEkbT42In0PKCqBzoxOEkPRXLxSgoS+SrU LXkw== X-Gm-Message-State: AOAM530O53xmWToiB2UXhrnAxMZxB9JKCBnPgTxUkSsK7vdwmaucd5Ch pPThuNVoz5CXxPiaQPqHg6x0mUvYCFdUAgLW65myQdiLFmrfagTgsFwkM5+2/a6fOeIEsnD5EXt HT86QzRofTo0Sol53ofY= X-Received: by 2002:a1f:dac7:: with SMTP id r190mr4066658vkg.22.1611942148569; Fri, 29 Jan 2021 09:42:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJwolejdVm0n7JzB1vp7rCjq/4BdlRppscjLNg9KfoYChwc7QDZrKb8TwYqE066xMfvfz1Xu5fwylJOo2hb7EiE= X-Received: by 2002:a1f:dac7:: with SMTP id r190mr4066644vkg.22.1611942148282; Fri, 29 Jan 2021 09:42:28 -0800 (PST) MIME-Version: 1.0 References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210127173330.1671341-1-bruce.richardson@intel.com> <20210127173330.1671341-9-bruce.richardson@intel.com> <3749594.2Ve71FdZX2@thomas> <20210128114144.GF899@bricha3-MOBL.ger.corp.intel.com> <20210128183415.GM899@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20210128183415.GM899@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Fri, 29 Jan 2021 18:42:17 +0100 Message-ID: To: Bruce Richardson Cc: Thomas Monjalon , dev , Aaron Conole , Michael Santana Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 8/8] ci: add checking of includes to CI builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 28, 2021 at 7:34 PM Bruce Richardson wrote: > > On Thu, Jan 28, 2021 at 11:41:44AM +0000, Bruce Richardson wrote: > > On Thu, Jan 28, 2021 at 12:12:44PM +0100, Thomas Monjalon wrote: > > > 27/01/2021 18:33, Bruce Richardson: > > > > For CI builds, turn on the checking of includes. > > > > > > > > Signed-off-by: Bruce Richardson Acked-by: > > > > Aaron Conole --- .ci/linux-build.sh | 1 + 1 file > > > > changed, 1 insertion(+) > > > > > > > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index > > > > afa3689a09..fdbeb5a616 100755 --- a/.ci/linux-build.sh +++ > > > > b/.ci/linux-build.sh @@ -57,6 +57,7 @@ fi OPTS="$OPTS > > > > -Dmachine=default" OPTS="$OPTS --default-library=$DEF_LIB" OPTS="$OPTS > > > > --buildtype=debugoptimized" +OPTS="$OPTS -Dcheck_includes=true" > > > > > > Which percentage of time does it add on GHA? > > > > > I'd have to gather some before/after tests to know for sure, but to check > > it wasn't too heavy-weight I was just monitoring the log at the end of a > > build on GHA. The specific build I watched took nearly 15 minutes, and I > > would guess-timate that the extra task took about 20 seconds of that. > > Related to this, and to ensure we don't increase the GHA build time > massively, is there a reliably way to test this out? Looking at the daily > builds on GHA I see some successful builds completing in 7.5 mins, while > others take almost 18 minutes. I guess it depends on the changes being tested. We have a ccache regenerated once a week against the main branch. That might help compilations for changes on drivers only. And it might depend on luck too / the resources available on the system that runs the tests. We once hit a case with OVS GHA where the cached DPDK binaries were built on a system that had a more recent cpu (and this is the reason why we now build with -Dmachine=default). > The extra build time from this chkincs takes very little time on my own > system but perhaps we want to limit it to a single build on GHA. I'm not > very familiar with configuring those builds, so perhaps someone could > suggest how to do so. >From what I see in ovsrobot/dpdk/actions logs, the impact is small. -- David Marchand