From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dmarchan@redhat.com> Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id D97D45F1D for <dev@dpdk.org>; Thu, 2 May 2019 15:32:31 +0200 (CEST) Received: by mail-ua1-f66.google.com with SMTP id s30so711726uas.8 for <dev@dpdk.org>; Thu, 02 May 2019 06:32:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HdS87vy/4q4ptadEbIdlOAgeisQhHXmy9nkhcd/2XoE=; b=NsuUnhYjDObN2S3BhYR7FjWdYQyGDW9SOX+9XYXczcTqgV9i0ZiUXqxMuLD0MkFzIo U/hS+x960fu8rWSQ/+sAhLeMQYRG4saLEm9LriX5vyXWlAtyA/l4UCr4cOC1O6IN6dsl 151wYMeMH9j/eZ2Rqxj5qDXBIYDVZQJ6lhNjtLJ/JdUalbekZ6ThZMYN7vBgq9ZWO2Sl zhrJgeTs0PKBdKVKOnMrNrhO2fde2+bTjrVUQVu7Wuv1MxJ8brH+E445ox3OT51HPlTc njLxCWNy7IXFZYThsIjeg/RYl1J3/6TL01d8Fw0NlTIzTD8vBQsEbLWqS8D+KR0IdGnW 0jTg== X-Gm-Message-State: APjAAAWm7d3kRVCLjHcIwWaK11/W9+IpFmTH+DFf8EftYKNqRyHjLSFu Upzk0pQd9wcjN0O6GGxSZ2NF2dVNjYELGzlmZzbRsOr4 X-Google-Smtp-Source: APXvYqyYU9xL87QlfBA5b0ixSJUmijPe0GCPRJSYJIRNaaLNkC1HRquJvHIQqX0oxiW7eWVbY+cGZAWjJcN2Ih2ALyk= X-Received: by 2002:ab0:413:: with SMTP id 19mr1766222uav.87.1556803951229; Thu, 02 May 2019 06:32:31 -0700 (PDT) MIME-Version: 1.0 References: <20190501195014.2938-1-bruce.richardson@intel.com> <8175150.iIoqqa2Iee@xps> <CAJFAV8zyLxKWNLCB=CazXQbSaWjW4SaXStPQwyB9ExdVsSjnPA@mail.gmail.com> <20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com> From: David Marchand <david.marchand@redhat.com> Date: Thu, 2 May 2019 15:32:20 +0200 Message-ID: <CAJFAV8yn8qjNJ+Gy+1dNhr-AUvY2wyp9F6A4tURGoiA1+ZVxOg@mail.gmail.com> To: Bruce Richardson <bruce.richardson@intel.com> Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org> Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 02 May 2019 13:32:32 -0000 On Thu, May 2, 2019 at 3:24 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: > > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <[1] > thomas@monjalon.net> > > wrote: > > > > 01/05/2019 21:50, Bruce Richardson: > > > This set of changes fixes warnings seen when compiling DPDK on > > Fedora 30. > > > In most cases these warnings appear to be false positives, which > > means we > > > have the option to just disable the warning. Because the changes > > required > > > to the code to silence the warnings are fairly small I've chosen > > in all cases > > > to change the code rather than disable the warnings, but I'm open > > to doing > > > the opposite if it's felt it's a better solution. [One thing I > > didn't like > > > about disabling the warnings is that the disabling flags are not > > supported > > > by clang, so adding them involves compiler checks :-(] > > > > > > NOTE: this set does not cover all warnings with GCC9, but it does > > cover > > > those seen when building with meson. There is still one warning > > disable > > > flag needed when building with make, which will need a follow-on > > set to > > > fix. > > > > > > Bruce Richardson (4): > > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > > bus/fslmc: fix printf of null pointer > > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > > Cc: [2]stable@dpdk.org > > Applied, thanks > > > > I had a comment on patch 2, and the bigger problem is > > -Waddress-of-packed-member. > > The quicker solution for now is to downgrade it to warning only so > that > > we can fix the parts later rather than globally disable it. > > -- > Well, it is already a warning, it's just that with make we build by default > with -Werror when building from git. > Err, why don't we have -Werror for meson ? Also, that particular warning is already disabled for clang compilation, so > extending that to being disabled for gcc seems fine for a fix for this > release. > Arf, indeed.. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AAC61A0AC5 for <public@inbox.dpdk.org>; Thu, 2 May 2019 15:32:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8072D5F2A; Thu, 2 May 2019 15:32:33 +0200 (CEST) Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id D97D45F1D for <dev@dpdk.org>; Thu, 2 May 2019 15:32:31 +0200 (CEST) Received: by mail-ua1-f66.google.com with SMTP id s30so711726uas.8 for <dev@dpdk.org>; Thu, 02 May 2019 06:32:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HdS87vy/4q4ptadEbIdlOAgeisQhHXmy9nkhcd/2XoE=; b=NsuUnhYjDObN2S3BhYR7FjWdYQyGDW9SOX+9XYXczcTqgV9i0ZiUXqxMuLD0MkFzIo U/hS+x960fu8rWSQ/+sAhLeMQYRG4saLEm9LriX5vyXWlAtyA/l4UCr4cOC1O6IN6dsl 151wYMeMH9j/eZ2Rqxj5qDXBIYDVZQJ6lhNjtLJ/JdUalbekZ6ThZMYN7vBgq9ZWO2Sl zhrJgeTs0PKBdKVKOnMrNrhO2fde2+bTjrVUQVu7Wuv1MxJ8brH+E445ox3OT51HPlTc njLxCWNy7IXFZYThsIjeg/RYl1J3/6TL01d8Fw0NlTIzTD8vBQsEbLWqS8D+KR0IdGnW 0jTg== X-Gm-Message-State: APjAAAWm7d3kRVCLjHcIwWaK11/W9+IpFmTH+DFf8EftYKNqRyHjLSFu Upzk0pQd9wcjN0O6GGxSZ2NF2dVNjYELGzlmZzbRsOr4 X-Google-Smtp-Source: APXvYqyYU9xL87QlfBA5b0ixSJUmijPe0GCPRJSYJIRNaaLNkC1HRquJvHIQqX0oxiW7eWVbY+cGZAWjJcN2Ih2ALyk= X-Received: by 2002:ab0:413:: with SMTP id 19mr1766222uav.87.1556803951229; Thu, 02 May 2019 06:32:31 -0700 (PDT) MIME-Version: 1.0 References: <20190501195014.2938-1-bruce.richardson@intel.com> <8175150.iIoqqa2Iee@xps> <CAJFAV8zyLxKWNLCB=CazXQbSaWjW4SaXStPQwyB9ExdVsSjnPA@mail.gmail.com> <20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190502132433.GC1980@bricha3-MOBL.ger.corp.intel.com> From: David Marchand <david.marchand@redhat.com> Date: Thu, 2 May 2019 15:32:20 +0200 Message-ID: <CAJFAV8yn8qjNJ+Gy+1dNhr-AUvY2wyp9F6A4tURGoiA1+ZVxOg@mail.gmail.com> To: Bruce Richardson <bruce.richardson@intel.com> Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org> Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190502133220.x3zr8zGJeQfyNP9mem3tuLFPCgH0x4kaTBg7RWlfBBA@z> On Thu, May 2, 2019 at 3:24 PM Bruce Richardson <bruce.richardson@intel.com> wrote: > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: > > On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <[1] > thomas@monjalon.net> > > wrote: > > > > 01/05/2019 21:50, Bruce Richardson: > > > This set of changes fixes warnings seen when compiling DPDK on > > Fedora 30. > > > In most cases these warnings appear to be false positives, which > > means we > > > have the option to just disable the warning. Because the changes > > required > > > to the code to silence the warnings are fairly small I've chosen > > in all cases > > > to change the code rather than disable the warnings, but I'm open > > to doing > > > the opposite if it's felt it's a better solution. [One thing I > > didn't like > > > about disabling the warnings is that the disabling flags are not > > supported > > > by clang, so adding them involves compiler checks :-(] > > > > > > NOTE: this set does not cover all warnings with GCC9, but it does > > cover > > > those seen when building with meson. There is still one warning > > disable > > > flag needed when building with make, which will need a follow-on > > set to > > > fix. > > > > > > Bruce Richardson (4): > > > net/ixgbe: fix warning with GCC 9 on Fedora 30 > > > bus/fslmc: fix printf of null pointer > > > raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30 > > > raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30 > > Cc: [2]stable@dpdk.org > > Applied, thanks > > > > I had a comment on patch 2, and the bigger problem is > > -Waddress-of-packed-member. > > The quicker solution for now is to downgrade it to warning only so > that > > we can fix the parts later rather than globally disable it. > > -- > Well, it is already a warning, it's just that with make we build by default > with -Werror when building from git. > Err, why don't we have -Werror for meson ? Also, that particular warning is already disabled for clang compilation, so > extending that to being disabled for gcc seems fine for a fix for this > release. > Arf, indeed.. -- David Marchand