From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8793CA0C47; Fri, 11 Jun 2021 11:54:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C376540E78; Fri, 11 Jun 2021 11:54:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 485244067C for ; Fri, 11 Jun 2021 11:54:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623405280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TC69yEPloIgyICdWaIkPfmTyXdvQYhcYNK+fCDOCeyg=; b=UHDHKOAC0GNnEohBGOKpZd4Z3QxLRSCdDmEKzvAQAmNabWt6bynb9+ANO3cJkhB0wmktK+ DppvbLllPTGBDhx2ZaV+qRct8m3i+N80d6AnwpdSKjZ98JFdgEllerIVPgnDFLxB6iXG5k 9oXYbMi1P7kXZnWACmilSHvgGf50Pc8= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-0Y8iKM9CNKC1TA6NNvE35Q-1; Fri, 11 Jun 2021 05:54:36 -0400 X-MC-Unique: 0Y8iKM9CNKC1TA6NNvE35Q-1 Received: by mail-ua1-f70.google.com with SMTP id 78-20020a9f26540000b02902426fc5ddd3so2280739uag.16 for ; Fri, 11 Jun 2021 02:54:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TC69yEPloIgyICdWaIkPfmTyXdvQYhcYNK+fCDOCeyg=; b=lC+ihaRnYmvs83+/dZC3VvKPnwVoJ3UMwidab+2hhmW+71VLTMI1kl40hhUCwQezFU 4yXJ+lsgmtbvGapl53P9vutxEpx1rw1OcxXaEujYTNPtxMQoEz62iXV2o7BcXUHvcGb0 cs05Mjw2kqxe6sNRiWk2d32SYtz+E2ZJ9RVL92GU7m7pFV56fSSWy4TWEivGLfnnXTTQ cGCI/zoJ+QxO2ZE0ZClp0dvl8QVjObs3MIE8EyopUMcXmCfiatDY1UYHy4MSj8NZdihz UAsxaQzGOqZHfNIbWbYRzibAv+iE03lm8kT1WQH8OUmh0AfH0qeLsHYbf7gdb52pJCNv 1Wmg== X-Gm-Message-State: AOAM531p3OEbp8slGwRsOOJeNct4zcnvGLIV83KjgNJZ5wQLemphBTw9 s2IPv3Z05YqzyVoYQkSbjnkzfDYrmqg6ZiC/QJChSPuYZ+sedxH6Iwc/0ZGo/GdkQeW2YULPvgA hKFO8BXF1UTlokSafI2E= X-Received: by 2002:a1f:26cd:: with SMTP id m196mr8347032vkm.9.1623405276483; Fri, 11 Jun 2021 02:54:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwORiDN9BT6PO5EfNNejxMrkz/ePMV2ZIjHcmjIAAKFEopdQqUA8AwKlLu1ihZpoUkUTy4mntH/gcMb+wZEPz8= X-Received: by 2002:a1f:26cd:: with SMTP id m196mr8347023vkm.9.1623405276214; Fri, 11 Jun 2021 02:54:36 -0700 (PDT) MIME-Version: 1.0 References: <20210609101755.20769-1-michael.pfeiffer@tu-ilmenau.de> In-Reply-To: <20210609101755.20769-1-michael.pfeiffer@tu-ilmenau.de> From: David Marchand Date: Fri, 11 Jun 2021 11:54:25 +0200 Message-ID: To: Bruce Richardson Cc: Jan Viktorin , Ruifeng Wang , Jerin Jacob , dev , Michael Pfeiffer , dpdk stable , kosar@rehivetech.com, Phil Yang , Joyce Kong Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v5] eal: arm: fix out of tree build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Bruce, On Wed, Jun 9, 2021 at 12:18 PM Michael Pfeiffer wrote: > > Including various headers may fail for ARM builds with 'Platform must > be built with RTE_FORCE_INTRINSICS' if rte_config.h is not included > before. Move the error message after the includes to ensure rte_config.h > is always included. > > Fixes: de966ccdcd7f ("eal/arm: add byte order operations for ARM") > Fixes: 17d5fa0fa90d ("eal/arm: add atomic operations for ARMv7") > Fixes: d708f01b7102 ("eal/arm: add atomic operations for ARMv8") > Fixes: 2173f3333b61 ("mcslock: add MCS queued lock implementation") > Fixes: 7860c3965483 ("eal/arm: add spinlock operations for ARM") > Fixes: ca49b92079df ("ticketlock: enable generic ticketlock on all arch") > Cc: stable@dpdk.org > Cc: kosar@rehivetech.com > Cc: phil.yang@arm.com > Cc: joyce.kong@arm.com > > Signed-off-by: Michael Pfeiffer The header check currently compiles all headers with an implicit "-include rte_config.h". I suppose this is because it comes from the project level meson configuration. Would there be a way to detect the issue fixed by this patch? -- David Marchand