From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DB374374F; Thu, 21 Dec 2023 10:43:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA8DD402E7; Thu, 21 Dec 2023 10:43:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9DA5D402C0 for <dev@dpdk.org>; Thu, 21 Dec 2023 10:43:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703151817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=db8e9T89gfRBT4oFpfMAem8pXqV90hMME0as6u59Zjg=; b=EsgPN3+qMsvcg+PK6Lx4y+v9G+nQsrX50D0sYuR77E7bhheJHuDqN4vimFCNvitq8VcUmA T2HOC9ZklVIhaJlbJKzsbYl/SOUfABQnindcmEskBeZBUQ6/qJAa2zZJQpAVrysnmJcLtj p4D5dUsYz+a3/FfvJtsh2EyA6C65BVg= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-gg8bkxjTMEelCsYXcvWQaw-1; Thu, 21 Dec 2023 04:43:35 -0500 X-MC-Unique: gg8bkxjTMEelCsYXcvWQaw-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-50e1b6039a6so519480e87.3 for <dev@dpdk.org>; Thu, 21 Dec 2023 01:43:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703151813; x=1703756613; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=db8e9T89gfRBT4oFpfMAem8pXqV90hMME0as6u59Zjg=; b=JQ1eamjNv3rxxNkZCk6TVoOvEkDf/4HsyrV+fhpYbrDKSIroa4m1Ucp3fpU0IARcjI c8O/zdw4pNgWTrczhi42oU+pgrZOtSJ4bYIkdWR5WblkqLh6iY8uH8ArX4r8pyh+MyVt PWxxFfY9xzEZpw6T8bSVAR9lWDKvKzodGwRTxx4U6Otc1+uoniQkkpIeGW82fQLtA91G 5YpQxjmOlOnhHlD48/v/bE38gPhNsNJccSjq674HtorlBVpP8Pd7CGeihxC9BtzvioCM CBQ7tqfT6hVZkvZo4AJ07C5N+ZZg7R8Ep/4HScyWQiTxxnq5gIUQr/wTlME/fgtznFbr z+yQ== X-Gm-Message-State: AOJu0YyYMPLW9Dhyne3m+80zPrW+HYbi3weLIxpksioGfkb3jIKE6TPP Jdid252oMRtNKkdmQSXOyRnxtwVcijHRwiH1iJcIjw43hJendZAR5zRW9Py4O7usvcJ/KKyPI49 kZSb/+YxzfrY9ReB7eXI= X-Received: by 2002:ac2:5dfc:0:b0:50e:61da:2981 with SMTP id z28-20020ac25dfc000000b0050e61da2981mr170248lfq.139.1703151813683; Thu, 21 Dec 2023 01:43:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYE2365xcym0mPxzfh+GpbOkWf8rhaEO1leVBPM6gKCQgiYyEBIPnXwrZX8K+liFM80VzoxAr79bRWqihtZ0Q= X-Received: by 2002:ac2:5dfc:0:b0:50e:61da:2981 with SMTP id z28-20020ac25dfc000000b0050e61da2981mr170244lfq.139.1703151813357; Thu, 21 Dec 2023 01:43:33 -0800 (PST) MIME-Version: 1.0 References: <20231213014408.612051-1-stephen@networkplumber.org> <20231218192631.699267-1-stephen@networkplumber.org> <20231218192631.699267-15-stephen@networkplumber.org> In-Reply-To: <20231218192631.699267-15-stephen@networkplumber.org> From: David Marchand <david.marchand@redhat.com> Date: Thu, 21 Dec 2023 10:43:22 +0100 Message-ID: <CAJFAV8ynGzVHKcVQ-nQ7SLYEZhOKRApQg0q3Y7OphK+SMOp+Ag@mail.gmail.com> Subject: Re: [PATCH v4 14/17] event/skeleton: replace logtype PMD with dynamic type To: Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, Dec 18, 2023 at 8:28=E2=80=AFPM Stephen Hemminger <stephen@networkplumber.org> wrote: > > The skeleton is supposed to match current best practices. > Change it to use dynamic logtype. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > --- > drivers/event/skeleton/skeleton_eventdev.c | 3 ++- > drivers/event/skeleton/skeleton_eventdev.h | 8 ++++++-- > 2 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/s= keleton/skeleton_eventdev.c > index 7df032b7daa1..df50d2e4e4ff 100644 > --- a/drivers/event/skeleton/skeleton_eventdev.c > +++ b/drivers/event/skeleton/skeleton_eventdev.c > @@ -457,7 +457,7 @@ skeleton_eventdev_probe(struct rte_vdev_device *vdev) > const char *name; > > name =3D rte_vdev_device_name(vdev); > - RTE_LOG(INFO, PMD, "Initializing %s on NUMA node %d\n", name, > + PMD_DRV_LOG(INFO, "Initializing %s on NUMA node %d\n", name, > rte_socket_id()); > return skeleton_eventdev_create(name, rte_socket_id(), vdev); > } No \n please. --=20 David Marchand